Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2BLF-0000HD-AT for pgadmin-hackers@arkaria.postgresql.org; Wed, 20 Jan 2021 11:08:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l2BLE-0007C4-7n for pgadmin-hackers@arkaria.postgresql.org; Wed, 20 Jan 2021 11:08:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2BLE-0007Bx-0Y for pgadmin-hackers@lists.postgresql.org; Wed, 20 Jan 2021 11:08:00 +0000 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l2BL7-0008Nj-5c for pgadmin-hackers@postgresql.org; Wed, 20 Jan 2021 11:07:59 +0000 Received: by mail-lj1-x233.google.com with SMTP id i17so437254ljn.1 for ; Wed, 20 Jan 2021 03:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tXt9qEgF5y8KV9xittgEQ27irvbBI8igo1dAMbjUqpg=; b=XTrQGbPCcEDCajxx2YlG90w7y1mdgqFIpjm8eCDusHAVx3zo7qCTGS6MDSI9Vb9xZ8 saYRczPTnpCVa+qGTMuj6LeNNZBkDR5+TqYUPSEs2Tijb/vdbg0iLEYnC0NY3wADT5NI 5bY0sy+6hkGYoEI1t2IfD8l6kLV8JEwtZ7qPsNG5VACXhDaZwGFp7Ptul+i+mnaezGhp 6H4IsQI/eGoSoU3dsvqW6PJgyaQGGVvjH04Ps6K/2m+FIUUaS3/3dNDfcP07A6qNosuK Jxo74N0GQ38Tlv3JWK/l0jkk3pnT2JtP9EG2VMOHOahGCfgzWAtJ7veu0fTBE5biZk42 XV4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tXt9qEgF5y8KV9xittgEQ27irvbBI8igo1dAMbjUqpg=; b=JYksHeESOaOfVfVNzBek3TDVA4OKvUyARLXjNzpUr9F8qEXvuqvf/qhy4xXutTwopI 3kAd2L9bXNrtrYn4aPr1sL/wL4CPR85TWba9qtdas9LN5ocrJHZKFt9pMm8WyajjqpXf 2U2tONeUm/FuGr80Imrfs9ktfpZmIzKYPVVymgIBc8gge+CDNI6hGQETPUDzWubtxIrH FTgKCHiZwW2a6ktScTVd7+Kt8fgYbJXd32cu1+xFZFXjPvHENvowQZ3zDMdIGrcyB037 ApS1r7J+CevHXlAnGXfAdLT/4YPN9EgS4lwTY9Ivdr4qQcBIxAVyLgiHMgBq6onJ9+wH xO8A== X-Gm-Message-State: AOAM531iXKW/oawySFyqiBDs3zdXGXiGyJkiJrs8qDR8YIPGhp5mZlaF omxqzNEM6KDX78dGUJT5LxtT7g42ZFUe8VMvSS1z54C2wGYIeF7847rHYWCv8lfGmoIFQWaSdLQ pgRGsby/Mp1SlmDe0Z8aAVQ3WYj1WxYFllgqavP+DgI1Ia6B24/FAQ+XANVWBK4DzCh/IkQWKQv mdf/gfDUGFrgWSLNhDi6JDX9gh9mYHh21edYovwom+F0TBVyf57mD7fNB1hE1BIcGyoQ== X-Google-Smtp-Source: ABdhPJytMSeM6JdA3LJeOTq2cRSPoWQbRZXqC89Z+Y5B/+0zuoCZ618ZkZKp4RvqKxBXUWUVzl1I7yCj7h7vXPD3BEI= X-Received: by 2002:a2e:9058:: with SMTP id n24mr3365432ljg.442.1611140870880; Wed, 20 Jan 2021 03:07:50 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Wed, 20 Jan 2021 16:37:14 +0530 Message-ID: Subject: Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000004afd1505b952f7f6" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004afd1505b952f7f6 Content-Type: multipart/alternative; boundary="0000000000004afd1305b952f7f4" --0000000000004afd1305b952f7f4 Content-Type: text/plain; charset="UTF-8" Hi Hackers, Attached patch: 1) Fixes the broken explain GUI test case. 2) Displays a tooltip "Click for details..." on hover over explain plan nodes. Please review. On Tue, Jan 12, 2021 at 4:45 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Jan 12, 2021 at 4:08 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Attached is the updated patch. Please review. >> >> On Tue, Jan 12, 2021 at 2:51 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> Code looks good to me. Below are the review comments: >>> >>> - Copy and Paste not working in the popup. >>> - Documentation needs to be updated. >>> >>> >>> On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached patch improves the way explain plan details tooltip for a node >>>> is shown. With the change, popup with details will be shown upon clicking a >>>> node, and it will remain open until explicitly closed. >>>> >>>> Please review. >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>> >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --0000000000004afd1305b952f7f4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

Attached patch:
1) Fixes the broken explain GU= I test case.
2) Displays a tooltip "Click for details..." on = hover over explain plan nodes.

Please review.

On Tue, Jan 12, 202= 1 at 4:45 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.
On = Tue, Jan 12, 2021 at 4:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb= .com> wrote:
Hi Akshay,

Attached is the updated patch. Please r= eview.

On Tue, Jan 12, 2021 at 2:51 PM Akshay Joshi <akshay.joshi@enterpris= edb.com> wrote:
Hi=C2=A0Aditya

Code looks good t= o me. Below are the review comments:
  • Copy and Paste not w= orking in the popup.
  • Documentation needs to be updated.

On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal <aditya.toshniwal@enter= prisedb.com> wrote:
Hi Hackers,

Attached patch improves the way ex= plain plan details tooltip for a node is shown. With the change, popup with= details will be shown upon clicking a node, and it will remain=C2=A0open u= ntil=C2=A0explicitly closed.

Please review.

-- <= br>
Thanks,
Adi= tya Toshniwal
pgAdmin hacker=C2=A0| <= font size=3D"2" color=3D"#000000" face=3D"arial, sans-serif">Sr. Software E= ngineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Softwa= re Engineer | edbpostgres.com<= /font>
"Don't Complain about Heat, Plant a TREE&qu= ot;
--0000000000004afd1305b952f7f4-- --0000000000004afd1505b952f7f6 Content-Type: application/octet-stream; name="RM5488.feature.patch" Content-Disposition: attachment; filename="RM5488.feature.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kk5bnfbr0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2ZlYXR1cmVfdGVzdHMveHNzX2NoZWNrc19wYW5lbHNf YW5kX3F1ZXJ5X3Rvb2xfdGVzdC5weSBiL3dlYi9wZ2FkbWluL2ZlYXR1cmVfdGVzdHMveHNzX2No ZWNrc19wYW5lbHNfYW5kX3F1ZXJ5X3Rvb2xfdGVzdC5weQppbmRleCBkMzA5YzRjZmQuLjkzOTcx ZWI4NiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vZmVhdHVyZV90ZXN0cy94c3NfY2hlY2tzX3Bh bmVsc19hbmRfcXVlcnlfdG9vbF90ZXN0LnB5CisrKyBiL3dlYi9wZ2FkbWluL2ZlYXR1cmVfdGVz dHMveHNzX2NoZWNrc19wYW5lbHNfYW5kX3F1ZXJ5X3Rvb2xfdGVzdC5weQpAQCAtMzEzLDcgKzMx Myw3IEBAIGNsYXNzIENoZWNrRm9yWHNzRmVhdHVyZVRlc3QoQmFzZUZlYXR1cmVUZXN0KToKICAg ICAgICAgICAgICAgICAgICAgc2VsZi5kcml2ZXIuZmluZF9lbGVtZW50X2J5X2Nzc19zZWxlY3Rv cigKICAgICAgICAgICAgICAgICAgICAgICAgICdkaXYucGdhZG1pbi1leHBsYWluLWNvbnRhaW5l ciA+IHN2ZyA+IGcgPiBnID4gaW1hZ2UnCiAgICAgICAgICAgICAgICAgICAgICkKLSAgICAgICAg ICAgICAgICApLnBlcmZvcm0oKQorICAgICAgICAgICAgICAgICkuY2xpY2soKS5wZXJmb3JtKCkK ICAgICAgICAgICAgICAgICBicmVhawogICAgICAgICAgICAgZXhjZXB0IEV4Y2VwdGlvbjoKICAg ICAgICAgICAgICAgICBpZiBpZHggIT0gMjoKQEAgLTMyNiw4ICszMjYsOCBAQCBjbGFzcyBDaGVj a0Zvclhzc0ZlYXR1cmVUZXN0KEJhc2VGZWF0dXJlVGVzdCk6CiAgICAgICAgICAgICAgICAgICAg ICkKICAgICAgICAgICAgICAgICAgICAgcmFpc2UKIAotICAgICAgICBzb3VyY2VfY29kZSA9IHNl bGYuZHJpdmVyLmZpbmRfZWxlbWVudF9ieV9pZCgKLSAgICAgICAgICAgICd0b29sVGlwJykuZ2V0 X2F0dHJpYnV0ZSgnaW5uZXJIVE1MJykKKyAgICAgICAgc291cmNlX2NvZGUgPSBzZWxmLmRyaXZl ci5maW5kX2VsZW1lbnRfYnlfY3NzX3NlbGVjdG9yKAorICAgICAgICAgICAgJy5wZ2FkbWluLWV4 cGxhaW4tZGV0YWlsczpub3QoLmQtbm9uZSknKS5nZXRfYXR0cmlidXRlKCdpbm5lckhUTUwnKQog CiAgICAgICAgIHNlbGYuX2NoZWNrX2VzY2FwZWRfY2hhcmFjdGVycygKICAgICAgICAgICAgIHNv dXJjZV9jb2RlLApkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vbWlzYy9zdGF0aWMvZXhwbGFpbi9q cy9leHBsYWluLmpzIGIvd2ViL3BnYWRtaW4vbWlzYy9zdGF0aWMvZXhwbGFpbi9qcy9leHBsYWlu LmpzCmluZGV4IGRhNTk1ZTZiMy4uYzQ3ODI4OGI4IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9t aXNjL3N0YXRpYy9leHBsYWluL2pzL2V4cGxhaW4uanMKKysrIGIvd2ViL3BnYWRtaW4vbWlzYy9z dGF0aWMvZXhwbGFpbi9qcy9leHBsYWluLmpzCkBAIC05NDcsNyArOTQ3LDEwIEBAIGRlZmluZSgn cGdhZG1pbi5taXNjLmV4cGxhaW4nLCBbCiAgICAgICAgIElNQUdFX1dJRFRILAogICAgICAgICBJ TUFHRV9IRUlHSFQKICAgICAgICk7Ci0gICAgICBpbWFnZS5hdHRyKHtzdHlsZTogJ2N1cnNvcjog cG9pbnRlcid9KTsKKyAgICAgIGltYWdlLmF0dHIoeworICAgICAgICBzdHlsZTogJ2N1cnNvcjog cG9pbnRlcicsCisgICAgICAgIGNsYXNzOiAnaW1hZ2Utbm9kZScsCisgICAgICB9KTsKIAogICAg ICAgLy8gRHJhdyB0b29sdGlwCiAgICAgICB2YXIgaW1hZ2VfZGF0YSA9IHRoaXMudG9KU09OKCks CkBAIC0xNDc4LDYgKzE0ODEsMTAgQEAgZGVmaW5lKCdwZ2FkbWluLm1pc2MuZXhwbGFpbicsIFsK ICAgICAgICAgICAgIH0KICAgICAgICAgICB9KTsKICAgICAgICAgfSk7CisgICAgICAgIGNvbnRh aW5lci5maW5kKCcuaW1hZ2Utbm9kZScpLnRvb2x0aXAoeworICAgICAgICAgIHRpdGxlOiBnZXR0 ZXh0KCdDbGljayBmb3IgZGV0YWlscy4uLicpLAorICAgICAgICAgIHRlbXBsYXRlOiAnPGRpdiBj bGFzcz0idG9vbHRpcCIgcm9sZT0idG9vbHRpcCI+PGRpdiBjbGFzcz0iYXJyb3cgZC1ub25lIj48 L2Rpdj48ZGl2IGNsYXNzPSJ0b29sdGlwLWlubmVyIj48L2Rpdj48L2Rpdj4nCisgICAgICAgIH0p CiAgICAgICB9KTsKIAogICAgICAgX3JlbmRlckV4cGxhaW5UYWJsZShjdHguX2V4cGxhaW5UYWJs ZSwgZXhwbGFpblRhYmxlKTsK --0000000000004afd1505b952f7f6--