Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hT3da-0000uH-Am for pgadmin-hackers@arkaria.postgresql.org; Tue, 21 May 2019 12:12:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hT3dY-00087q-FZ for pgadmin-hackers@arkaria.postgresql.org; Tue, 21 May 2019 12:12:56 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hT3dY-00087i-1J for pgadmin-hackers@lists.postgresql.org; Tue, 21 May 2019 12:12:56 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hT3dQ-0006r1-5v for pgadmin-hackers@postgresql.org; Tue, 21 May 2019 12:12:54 +0000 Received: by mail-lj1-x235.google.com with SMTP id 188so1440380ljf.9 for ; Tue, 21 May 2019 05:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N+EH0ewPeL+44+I6BJVAwndmmTNorVlzwiuELRqsLzs=; b=xTZ4zfFpEppw2ttTyHxyA6ZBd1uLBAcQSSIqMPt6xmENApjv7fcb5EoNIC04kcR2pM zq5qcZQZS/qrsl2PPptmfbdnA/J2v5lY81Z92hf3qmZWiQQaFW1fgUaolbFkGlst3PFH jEv6DTYKA3j+g3fu5StEC4AvZqLoLlMCDNDT0wkdKzyu6itUF3OxGv389YK2L08+z9K2 0lIgcJEaeu5m88UHZYhhUelNlSo7wANEIRI05mJuHunsxKLZ46tEvRsofUY9waqLoEwj 2vUaHX0L92fB+f/Yp2DTJbTKjd/rhsR1aahn6lzBj7XsXTG+UjYo0pUDLWmvvzGveoDV l4ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N+EH0ewPeL+44+I6BJVAwndmmTNorVlzwiuELRqsLzs=; b=l/6r7/UFizZ67X2pzVz+LZ2u79I9A3g54dbDOwheE4BBFQgH5wVkj48wysGh1DZmO+ OeaUfidu7YWMa7G4jFuXQMygsPZhkw0LGycUuYuZdy9PUC0j1KEnq9FFrIjm7Ispfj5F YAFNLow5BblVrF0ZcmCvzhvNLmi+J+Dm7DXA2DGkThK1X3L+rOK5bN0luXxm+FWJ2lYS gG8cr6/n0ejptw6hBOpP4l/g20JJH5q+FVi0BoGIQRDFl7qkNhwjE6jhhx2RqAUmMWLA OuZyt4bYivOTiv+EY+Wc+d+tPGJLM+0VvwYWsbkiJnK13uXA38X9JO/8na+B+0m5mJHU CaPQ== X-Gm-Message-State: APjAAAW5l0ObvO7AUK+WTHte0ciOPyg7a2kyUjPewsrr20wQQYkvn2k4 1jSHLeeV0+wChGFU/gTLdREtWfNW9CxNuTP6iOMY+g== X-Google-Smtp-Source: APXvYqzWqGWMPqKoouZq4V1uCKHELQjL8ifDd6C2cTwIXds65ZhjDu5zBNnersmlh4XgdFLRZQcw3ZqqbTT1kwQ1tf0= X-Received: by 2002:a2e:2d02:: with SMTP id t2mr394039ljt.148.1558440765672; Tue, 21 May 2019 05:12:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Tue, 21 May 2019 17:42:09 +0530 Message-ID: Subject: Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility) To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000003de095058964c46a" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000003de095058964c46a Content-Type: text/plain; charset="UTF-8" Hi, On Tue, May 21, 2019 at 5:32 PM Dave Page wrote: > Hi > > On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix the accessibility issue in query tool. >> >> The query tool can be completely restructured unlike previously where >> query tool used to stick at top and other tabs in the bottom. >> - I have added a new shortcut to switch between frames if in query tool >> the tab positions are changed. On switching the frames, the frame will >> blink to show it is focussed. >> - In the frame, you can switch tab same as previous. The tabs in SQL >> editor are cyclic now, which means if you execute shortcut to go right on >> the last tab then it will cycle to first tab. >> - I have also changed the default shortcut to switch between tabs from >> Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what we have in >> browser tabs. >> - Similar changes done for debugger also. >> > > Shouldn't there be documentation changes to go with this? > Yes, definitely :P Will send the updated patch. > > Otherwise, it seems to work :-) > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --0000000000003de095058964c46a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

=
On Tue, May 21, 2019 at 5:32 PM Dave = Page <dpage@pgadmin.org> wro= te:
Hi

On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal &= lt;a= ditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the accessibility issue in query tool.=

The query tool can be completely restructu= red unlike previously where query tool used to stick at top and other tabs = in the bottom.=C2=A0
- I= have added a new shortcut to switch between frames if in query tool the ta= b positions are changed. On switching the frames, the frame will blink to s= how it is focussed.=C2=A0
- In the frame, you can switch tab same as previous. The tabs in SQL edit= or are cyclic now, which means if you execute shortcut to go right on the l= ast tab then it will cycle to first tab.
- I have also changed the default shortcut to switch betwe= en tabs from Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what we = have in browser tabs.
- = Similar changes done for debugger also.

Shouldn't there be documentation changes to go with this?=C2= =A0
Yes, definitely :P
Will se= nd the updated patch.=C2=A0

<= div>Otherwise, it seems to work :-)

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

En= terpriseDB UK: ht= tp://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Adi= tya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"
--0000000000003de095058964c46a--