MIME-Version: 1.0
In-Reply-To: 
 <CAE+jjakwbfsbwkvwa6N1QGjGeVb36sWnde+C6amnHQLHdTE3kQ@mail.gmail.com>
References: 
 <CAM9w-_ntCUguZp2rVJXPsDvWJbWneAz4-AHJoYB+nUTSYMXc9g@mail.gmail.com>
 <CA+OCxozRjJY6RWrXpMLD6-dWnm2LdPs6bS+VmJa403vxVoLwhg@mail.gmail.com>
 <CAM9w-_m-cJax16zqBonx-d0-HSy5dNoOzB13HWAad5Xv0Wu=CA@mail.gmail.com>
 <CANxYE3+qrGeZYzdYEtzxS8i2P+325V5E+n1xVpyzTwn7vRqRDg@mail.gmail.com>
 <CAM9w-_mTe0gW+2cdhMutMWyBsRt7Om3G_Em126Ryntf0nOiHbA@mail.gmail.com>
 <CAM9w-_mXdJhuRFn87yAuqWtfrhnRgw1KvU2PpthL-hbnOt2QpA@mail.gmail.com>
 <CAE+jjampAPoDq7xJgeNf1L=i_1jf83PLr=dZYicfkEMp6_UBAg@mail.gmail.com>
 <CAM9w-_k2Fo-qDy+qxM5i=Aba__TAWxrryR+m3izTXB=koToKcQ@mail.gmail.com>
 <CA+OCxoz+Wo3pUuu8SMBzAsQvrOjYLPQHCfQMtO3X3HKezKcapw@mail.gmail.com>
 <CAM9w-_nEDycbeEEeUhKwXjxmkNC39YzqhggJR3Frc4pq6WcJ0Q@mail.gmail.com>
 <CAM9w-_kDQkAWRZrRRtmMDz8DZ5x2wGoUro6oQbQqTzLmZZGyBw@mail.gmail.com>
 <CAE+jjametYGjStNFZFW544Jcm_by1OABtb7yFQWKGzyfk08QiA@mail.gmail.com>
 <CAM9w-_=rsazJWCu5xRqLGkYX3FW22vVuyc0NcR5TPskO9PApUg@mail.gmail.com>
 <CAE+jjakwbfsbwkvwa6N1QGjGeVb36sWnde+C6amnHQLHdTE3kQ@mail.gmail.com>
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Tue, 5 Jun 2018 10:15:33 +0530
Message-ID: 
 <CAM9w-_km5Zv=Gw6CUZF8m3zzacOKL-ir-QNw3xPjP2MJfLRg7w@mail.gmail.com>
Subject: Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.
To: Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>
Cc: Dave Page <dpage@pgadmin.org>,
 pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000007e86b0056dddb8d3"
Precedence: bulk

--0000000000007e86b0056dddb8d3
Content-Type: text/plain; charset="UTF-8"

Hi

On Tue, Jun 5, 2018 at 1:08 AM, Joao De Almeida Pereira <
jdealmeidapereira@pivotal.io> wrote:

> Hello Aditya,
>
>>
>>
>> There is no change related to notifications in this patch.
>> The below code is minor fix related to connection status of sql editor.
>> Can you please share the code snippet if it is not the below.
>>
>> -        # Check for the asynchronous notifies statements.
>> -        conn.check_notifies(True)
>> -        notifies = conn.get_notifies()
>> +        if status is not None:
>> +            # Check for the asynchronous notifies statements.
>> +            conn.check_notifies(True)
>> +            notifies = conn.get_notifies()
>>
>>
> This is a minor fix, but is it related to querying SQL_ASCII database?
>
No its not. It is something I found when I was working on SQL_ASCII related
changes.
Well then, will send a separate patch for it.

>
> Thanks
> Victoria && Joao
>

--0000000000007e86b0056dddb8d3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<div class=3D"gmail_extra"><br><div class=3D"gmail_quote=
">On Tue, Jun 5, 2018 at 1:08 AM, Joao De Almeida Pereira <span dir=3D"ltr"=
>&lt;<a href=3D"mailto:jdealmeidapereira@pivotal.io" target=3D"_blank">jdea=
lmeidapereira@pivotal.io</a>&gt;</span> wrote:<br><blockquote class=3D"gmai=
l_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left=
:1ex"><div dir=3D"ltr">Hello Aditya,<br><div class=3D"gmail_quote"><span cl=
ass=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;borde=
r-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><br><div><br></div=
><div>There is no change related to notifications in this patch.=C2=A0</div=
><div>The below code is minor fix related to connection status of sql edito=
r. Can you please share the code snippet if it is not the below.</div><div>=
<br></div><div><div>-=C2=A0 =C2=A0 =C2=A0 =C2=A0 # Check for the asynchrono=
us notifies statements.</div><div>-=C2=A0 =C2=A0 =C2=A0 =C2=A0 conn.check_n=
otifies(True)</div><div>-=C2=A0 =C2=A0 =C2=A0 =C2=A0 notifies =3D conn.get_=
notifies()</div><div>+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if status is not None:</d=
iv><div>+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # Check for the asynchro=
nous notifies statements.</div><div>+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 conn.check_notifies(True)</div><div>+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 notifies =3D conn.get_notifies()</div></div><div><br></div></div></=
blockquote><div><br></div></span><div>This is a minor fix, but is it relate=
d to querying SQL_ASCII database?</div></div></div></blockquote><div>No its=
 not. It is something I found when I was working on SQL_ASCII related chang=
es.</div><div>Well then, will send a separate patch for it.</div><blockquot=
e class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc sol=
id;padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><div><br><=
/div><div>Thanks</div><div>Victoria &amp;&amp; Joao</div></div></div>
</blockquote></div><br></div></div>

--0000000000007e86b0056dddb8d3--