MIME-Version: 1.0
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Wed, 9 Sep 2020 15:18:27 +0530
Message-ID: 
 <CAM9w-_knay-688=uCiM7C=C+79H2-t9kBgFnVekohm75878JOg@mail.gmail.com>
Subject: [pgAdmin][RM5815] Generate script is not working in new window
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000a2119e05aede5cfa"
Precedence: bulk

--000000000000a2119e05aede5cfa
Content-Type: multipart/alternative; boundary="000000000000a2119b05aede5cf8"

--000000000000a2119b05aede5cf8
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

If schema diff is opened in a new tab and "Generate script" is clicked
(with query tool setting "open in new tab" set to true) then it shows a
forever spinner because of pop up blocks.

Attached patch will show an alert message in that case so that the user can
allow pop up and generate the script again.

Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"

--000000000000a2119b05aede5cf8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">Hi Hackers,</div><div class=3D"gmail_default" style=3D"font-fam=
ily:verdana,sans-serif"><br></div><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif">If schema diff is opened in a new tab and &quo=
t;Generate script&quot; is clicked (with query tool setting &quot;open in n=
ew tab&quot; set to true) then it shows a forever spinner because of pop up=
 blocks.</div><div class=3D"gmail_default" style=3D"font-family:verdana,san=
s-serif"><br></div><div class=3D"gmail_default" style=3D"font-family:verdan=
a,sans-serif">Attached patch will show an alert message in that case so tha=
t the user can allow pop up and generate the script again.<br></div><div cl=
ass=3D"gmail_default" style=3D"font-family:verdana,sans-serif"><br></div><d=
iv class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">Please =
review.</div><div><br></div>-- <br><div dir=3D"ltr" class=3D"gmail_signatur=
e" data-smartmail=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><di=
v dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div><font size=3D"2" color=
=3D"#000000" face=3D"arial, sans-serif">Thanks,</font><div><span style=3D"c=
olor:rgb(34,34,34)"><span style=3D"color:rgb(18,22,70)"><font face=3D"arial=
, sans-serif">Aditya Toshniwal</font></span></span><font size=3D"2" color=
=3D"#000000" face=3D"verdana, sans-serif"><br></font></div><div><span style=
=3D"color:rgb(18,22,70);font-family:Arial,sans-serif">pgAdmin hacker</span>=
<font size=3D"2" color=3D"#000000" style=3D"font-family:verdana,sans-serif"=
>=C2=A0| </font><font size=3D"2" color=3D"#000000" face=3D"arial, sans-seri=
f">Sr. Software Engineer</font><font size=3D"2" color=3D"#000000"><font fac=
e=3D"verdana, sans-serif"> | </font><a href=3D"http://edbpostgres.com" targ=
et=3D"_blank"><font face=3D"arial, sans-serif" color=3D"#000000"><b>edbpost=
gres.com</b></font></a></font></div><div><font color=3D"#38761d" size=3D"1"=
><font face=3D"arial, sans-serif">&quot;Don&#39;t Complain about Heat, Plan=
t a TREE&quot;</font></font></div></div></div></div></div></div></div></div=
></div>

--000000000000a2119b05aede5cf8--

--000000000000a2119e05aede5cfa
Content-Type: application/octet-stream; name="RM5815.patch"
Content-Disposition: attachment; filename="RM5815.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_kev79lji0>
X-Attachment-Id: f_kev79lji0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2RhdGFncmlkL3N0YXRpYy9qcy9kYXRhZ3Jp
ZC5qcyBiL3dlYi9wZ2FkbWluL3Rvb2xzL2RhdGFncmlkL3N0YXRpYy9qcy9kYXRhZ3JpZC5qcwpp
bmRleCA2NDBiMzI1YzQuLmJiNGQzMzNjYSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMv
ZGF0YWdyaWQvc3RhdGljL2pzL2RhdGFncmlkLmpzCisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL2Rh
dGFncmlkL3N0YXRpYy9qcy9kYXRhZ3JpZC5qcwpAQCAtMjM0LDggKzIzNCwxMiBAQCBkZWZpbmUo
J3BnYWRtaW4uZGF0YWdyaWQnLCBbCiAKICAgICAgICAgaWYgKHNlbGYucHJlZmVyZW5jZXMubmV3
X2Jyb3dzZXJfdGFiKSB7CiAgICAgICAgICAgdmFyIG5ld1dpbiA9IHdpbmRvdy5vcGVuKCcnLCAn
X2JsYW5rJyk7Ci0gICAgICAgICAgbmV3V2luLmRvY3VtZW50LndyaXRlKHF1ZXJ5VG9vbEZvcm0p
OwotICAgICAgICAgIG5ld1dpbi5kb2N1bWVudC50aXRsZSA9IHBhbmVsX3RpdGxlOworICAgICAg
ICAgIGlmKG5ld1dpbikgeworICAgICAgICAgICAgbmV3V2luLmRvY3VtZW50LndyaXRlKHF1ZXJ5
VG9vbEZvcm0pOworICAgICAgICAgICAgbmV3V2luLmRvY3VtZW50LnRpdGxlID0gcGFuZWxfdGl0
bGU7CisgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAg
ICAgICB9CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgLyogT24gc3VjY2Vzc2Z1bGx5IGlu
aXRpYWxpemF0aW9uIGZpbmQgdGhlIGRhc2hib2FyZCBwYW5lbCwKICAgICAgICAgICAgKiBjcmVh
dGUgbmV3IHBhbmVsIGFuZCBhZGQgaXQgdG8gdGhlIGRhc2hib2FyZCBwYW5lbC4KQEAgLTI4Myw2
ICsyODcsNyBAQCBkZWZpbmUoJ3BnYWRtaW4uZGF0YWdyaWQnLCBbCiAKICAgICAgICAgICBvcGVu
UXVlcnlUb29sVVJMKHF1ZXJ5VG9vbFBhbmVsKTsKICAgICAgICAgfQorICAgICAgICByZXR1cm4g
dHJ1ZTsKICAgICAgIH0sCiAgICAgfSwKICAgICBCYWNrYm9uZS5FdmVudHMpOwpkaWZmIC0tZ2l0
IGEvd2ViL3BnYWRtaW4vdG9vbHMvZGF0YWdyaWQvc3RhdGljL2pzL3Nob3dfcXVlcnlfdG9vbC5q
cyBiL3dlYi9wZ2FkbWluL3Rvb2xzL2RhdGFncmlkL3N0YXRpYy9qcy9zaG93X3F1ZXJ5X3Rvb2wu
anMKaW5kZXggNzgyYmY3OGUzLi4wZjM2MzZlNjUgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3Rv
b2xzL2RhdGFncmlkL3N0YXRpYy9qcy9zaG93X3F1ZXJ5X3Rvb2wuanMKKysrIGIvd2ViL3BnYWRt
aW4vdG9vbHMvZGF0YWdyaWQvc3RhdGljL2pzL3Nob3dfcXVlcnlfdG9vbC5qcwpAQCAtNjgsNyAr
NjgsNyBAQCBleHBvcnQgZnVuY3Rpb24gc2hvd1F1ZXJ5VG9vbChkYXRhZ3JpZCwgcGdCcm93c2Vy
LCBhbGVydGlmeSwgdXJsLCBhY2lUcmVlSWRlbnRpZgogICBkYXRhZ3JpZC5sYXVuY2hfZ3JpZCh0
cmFuc0lkLCBncmlkVXJsLCB0cnVlLCBxdWVyeVRvb2xUaXRsZSwgc1VSTCk7CiB9CiAKLWV4cG9y
dCBmdW5jdGlvbiBnZW5lcmF0ZVNjcmlwdChwYXJlbnREYXRhLCBkYXRhZ3JpZCkgeworZXhwb3J0
IGZ1bmN0aW9uIGdlbmVyYXRlU2NyaXB0KHBhcmVudERhdGEsIGRhdGFncmlkLCBhbGVydGlmeSkg
ewogICBjb25zdCBxdWVyeVRvb2xUaXRsZSA9IGAke3BhcmVudERhdGEuZGF0YWJhc2V9LyR7cGFy
ZW50RGF0YS51c2VyfUAke3BhcmVudERhdGEuc2VydmVyfWA7CiAgIGNvbnN0IHRyYW5zSWQgPSBn
ZXRSYW5kb21JbnQoMSwgOTk5OTk5OSk7CiAKQEAgLTgyLDYgKzgyLDEzIEBAIGV4cG9ydCBmdW5j
dGlvbiBnZW5lcmF0ZVNjcmlwdChwYXJlbnREYXRhLCBkYXRhZ3JpZCkgewogICAgICtgJnNlcnZl
cl90eXBlPSR7cGFyZW50RGF0YS5zdHlwZX1gCiAgICAgK2AmZGlkPSR7cGFyZW50RGF0YS5kaWR9
YDsKIAotICBkYXRhZ3JpZC5sYXVuY2hfZ3JpZCh0cmFuc0lkLCB1cmxfZW5kcG9pbnQsIHRydWUs
IHF1ZXJ5VG9vbFRpdGxlLCAnJyk7Ci0KKyAgbGV0IHJldFZhbCA9IGRhdGFncmlkLmxhdW5jaF9n
cmlkKHRyYW5zSWQsIHVybF9lbmRwb2ludCwgdHJ1ZSwgcXVlcnlUb29sVGl0bGUsICcnKTsKKyAg
aWYoIXJldFZhbCkgeworICAgIGFsZXJ0aWZ5LmFsZXJ0KAorICAgICAgZ2V0dGV4dCgnUXVlcnkg
dG9vbCBsYXVuY2ggZXJyb3InKSwKKyAgICAgIGdldHRleHQoCisgICAgICAgICdQbGVhc2UgYWxs
b3cgdGhlIHBvcCB1cHMgaWYgdGhleSBhcmUgYmxvY2tlZCBmb3IgcGdBZG1pbi4gSWYgdGhlIHBn
QWRtaW4gd2luZG93IGlzIGNsb3NlZCB0aGVuIGNsb3NlIHRoaXMgd2luZG93IGFuZCBvcGVuIGEg
bmV3IHBnQWRtaW4gc2Vzc2lvbi4nCisgICAgICApCisgICAgKTsKKyAgfQogfQpkaWZmIC0tZ2l0
IGEvd2ViL3BnYWRtaW4vdG9vbHMvc2NoZW1hX2RpZmYvc3RhdGljL2pzL3NjaGVtYV9kaWZmX3Vp
LmpzIGIvd2ViL3BnYWRtaW4vdG9vbHMvc2NoZW1hX2RpZmYvc3RhdGljL2pzL3NjaGVtYV9kaWZm
X3VpLmpzCmluZGV4IDIyODI3MTUxOC4uMmUwMzdlNDdkIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1p
bi90b29scy9zY2hlbWFfZGlmZi9zdGF0aWMvanMvc2NoZW1hX2RpZmZfdWkuanMKKysrIGIvd2Vi
L3BnYWRtaW4vdG9vbHMvc2NoZW1hX2RpZmYvc3RhdGljL2pzL3NjaGVtYV9kaWZmX3VpLmpzCkBA
IC0yMzksNyArMjM5LDcgQEAgZXhwb3J0IGRlZmF1bHQgY2xhc3MgU2NoZW1hRGlmZlVJIHsKICAg
ICAgICAgICAgIH0KIAogICAgICAgICAgICAgcGdXaW5kb3cucGdBZG1pbi5kZGxfZGlmZiA9IGdl
bmVyYXRlZF9zY3JpcHQ7Ci0gICAgICAgICAgICBnZW5lcmF0ZVNjcmlwdChzZXJ2ZXJfZGF0YSwg
cGdXaW5kb3cucGdBZG1pbi5EYXRhR3JpZCk7CisgICAgICAgICAgICBnZW5lcmF0ZVNjcmlwdChz
ZXJ2ZXJfZGF0YSwgcGdXaW5kb3cucGdBZG1pbi5EYXRhR3JpZCwgQWxlcnRpZnkpOwogICAgICAg
ICAgIH0KIAogICAgICAgICAgICQoJyNkaWZmX2ZldGNoaW5nX2RhdGEnKS5maW5kKCcuc2NoZW1h
LWRpZmYtYnVzeS10ZXh0JykudGV4dCgnJyk7CkBAIC00ODUsNyArNDg1LDcgQEAgZXhwb3J0IGRl
ZmF1bHQgY2xhc3MgU2NoZW1hRGlmZlVJIHsKICAgICAgIGNvbnRlbnRUeXBlOiAnYXBwbGljYXRp
b24vanNvbicsCiAgICAgfSkKICAgICAgIC5kb25lKGZ1bmN0aW9uIChyZXMpIHsKLSAgICAgICAg
bGV0IG1zZyA9IHJlcy5kYXRhLmNvbXBhcmVfbXNnOworICAgICAgICBsZXQgbXNnID0gXy5lc2Nh
cGUocmVzLmRhdGEuY29tcGFyZV9tc2cpOwogICAgICAgICBpZiAocmVzLmRhdGEuZGlmZl9wZXJj
ZW50YWdlICE9IDEwMCkgewogICAgICAgICAgIG1zZyA9IG1zZyArIGdldHRleHQoJyAodGhpcyBt
YXkgdGFrZSBhIGZldyBtaW51dGVzKS4uLicpOwogICAgICAgICB9Cg==
--000000000000a2119e05aede5cfa--