public inbox for [email protected]  

help / color / mirror / Atom feed
From: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5131] ctrl + a shortcut does not move cursor in sql editor with macOS
Date: Mon, 28 Sep 2020 18:12:05 +0530
Message-ID: <CAM9w-_ktc_d3Qump+X8mRtv7XoTqU8D3rWtM9s2hDpMBoYSLWg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDdUiwkRSNkNe3cqwQQ-Mdt+F9GeHpExnHxs2M5Oa-8xog@mail.gmail.com>
References: <CAM9w-_=98Ocz9tX9M9dAz5D_g8DjtZxriS1rw72V8Zx_v3Z73g@mail.gmail.com>
	<CANxoLDdUiwkRSNkNe3cqwQQ-Mdt+F9GeHpExnHxs2M5Oa-8xog@mail.gmail.com>

Hi,

Please find the updated patch.

On Mon, Sep 28, 2020 at 5:59 PM Akshay Joshi <[email protected]>
wrote:

> Hi Aditya
>
> The patch is not applying, rebase, and send it again.
>
> On Mon, Sep 28, 2020 at 3:23 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached patch removes the incorrect overriding of default CodeMirror
>> shortcuts.
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [application/octet-stream] RM5131.patch (729B, 3-RM5131.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/static/js/browser.js b/web/pgadmin/browser/static/js/browser.js
index 0eb7840b0..e9463f2ea 100644
--- a/web/pgadmin/browser/static/js/browser.js
+++ b/web/pgadmin/browser/static/js/browser.js
@@ -2171,22 +2171,6 @@ define('pgadmin.browser', [
       'Ctrl-Space': 'autocomplete',
       'Cmd-Space': 'autocomplete',
 
-      // Select All text
-      'Ctrl-A': 'selectAll',
-      'Cmd-A': 'selectAll',
-
-      // Redo text
-      'Ctrl-Y': 'redo',
-      'Cmd-Y': 'redo',
-
-      // Undo text
-      'Ctrl-Z': 'undo',
-      'Cmd-Z': 'undo',
-
-      // Delete Line
-      'Ctrl-D': 'deleteLine',
-      'Cmd-D': 'deleteLine',
-
       'Alt-Up': 'goLineUp',
       'Alt-Down': 'goLineDown',
 


view thread (4+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM5131] ctrl + a shortcut does not move cursor in sql editor with macOS
  In-Reply-To: <CAM9w-_ktc_d3Qump+X8mRtv7XoTqU8D3rWtM9s2hDpMBoYSLWg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox