Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jEpDj-0008QX-BF for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 07:03:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jEpDg-0004QG-1h for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 07:03:56 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jEpDf-0004Q9-IS for pgadmin-hackers@lists.postgresql.org; Thu, 19 Mar 2020 07:03:55 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEpDc-0000eQ-FX for pgadmin-hackers@postgresql.org; Thu, 19 Mar 2020 07:03:54 +0000 Received: by mail-ed1-x544.google.com with SMTP id h5so1322377edn.5 for ; Thu, 19 Mar 2020 00:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hJ/fZKvcvFysbQ/zNaEfTH2oZkYA4WM08esTrIanznw=; b=DLPjMbaxKAgumZPBuirPjy3c7jvZnOT4S+qzFWItF/bBNlFbGfedtefgn0V2LFX4om k0RWqBT3kvM+b4s4aNqjlAm2tYuOrHMgckS7Ls/RhnYs4n3PURMxjWJ5R6CmPsMkOYxp pS/VAXLKB2D4a8wn6k/QE5+d/HtWnrNqr9ONJV8rFZAyV+bgZeNLvoruZs/0kCN06Bmv zrVT6sxy5UGN8vO02gLpF9/9FldSBg7dxRgQw5axkVNvLjKE5qlt7QFHuVfRpv0yoPPH fTR5YJ+i3NWLPiT/+cqUeq2H2Be1J5JbrUPGP2Z42/JZuEYck3X8jCAK60pEke40Z+/K NbXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hJ/fZKvcvFysbQ/zNaEfTH2oZkYA4WM08esTrIanznw=; b=LkgNVMWpKgCTGOqbY/Muauiomn3d4+lZKQD21Fuytc2uRO0cwpjTUmzyyMUHFvILVG +mzsQFNYrnT1/V/GuCZd6f3csSiEzlf9U8N4cuxuk7h/S+Zk9do6hRvC8ncTIzh3B/Ab 227n+JJmCnGM4r+laiFvVj1QGbS59KZlqwegtmenSWSIFxLB+L3/f6/MNXZCYpOP9AnH ts3xD7adiWJDjaKdk/6QhujY5IRJelTelgABJ5yoaskmg4+GCZOTiKkMilPgH5TxjcIf qtg41YV9tvsQiZwCcxpdoT6rgjRk/s722l5pMYkudHQ6nxhHk3w1cuy6EBP4U3J64R3p pqiQ== X-Gm-Message-State: ANhLgQ3PngFvpSK6oC3z55JfabG+lm4F3f6meh36sE0vMeQrT0vzA+et Vrz4p34ALDapvssd+3v1BFNSLPVuMipRF+RA+lA+WsNMLAnft1bXXVT64aq2x7yRANOKmEgvHLj buKDczbX2JadrKdaE/nB8r6sF3hcbhZBZKt3tt1s9N/rSsC7gfBGipNn0FJXgj/JfAiW3p7FknO NUPRrwCLFQwWSL8xYYuYawiLKLLBWx6ntGEwL4FYuB+/qEornfaiQ= X-Google-Smtp-Source: ADFU+vuaMu6o7z/0+1z/vughh4vzo6euobSeej5/Ef99en9X1Iz58s2f6b2SjUttBLSAqG4lWttip5owP0ZRinDEan8= X-Received: by 2002:aa7:d0cb:: with SMTP id u11mr1151058edo.373.1584601430884; Thu, 19 Mar 2020 00:03:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Thu, 19 Mar 2020 12:33:14 +0530 Message-ID: Subject: Re: [pgAdmin4][RM 5271] To change the switch control colors To: Murtuza Zabuawala Cc: Chethana Kumar , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000006618c505a12fc5fa" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000006618c505a12fc5fa Content-Type: text/plain; charset="UTF-8" Hi Murtuza, The patch looks good to me. On Thu, Mar 19, 2020 at 12:10 PM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hello, > > PFA updated patch with new colors provided by Chethana, As discussed we > will be using the same primary success color in both theme so we don't have > add new variable. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > > On Wed, Mar 18, 2020 at 2:27 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Murtuza/Chethana, >> >> Irrespective of what color you suggest, there is no need to add new >> variables for switch buttons. It should use success for on and ternary for >> off. >> Having a separate green color for each and every control is absurd. If >> the green changes, it should change for all. >> >> On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar < >> chethana.kumar@enterprisedb.com> wrote: >> >>> Let us discuss on a call for better clarity and the conclusion part we >>> can put it on mail. >>> >>> --- >>> Chethana kumar >>> >>> On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hi Chethana, >>>> >>>> No it is not, As per current dark theme implementation we have used >>>> primary color '#1a522b' for switch but the color you suggested is '#43A047' >>>> for both theme. >>>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar < >>>> chethana.kumar@enterprisedb.com> wrote: >>>> >>>>> Hi Murtuza, >>>>> >>>>> The changes are already incorporated so no worries :) >>>>> >>>>> Thanks, >>>>> >>>>> --- >>>>> Chethana kumar >>>>> >>>>> On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> Hello, >>>>>> >>>>>> As per discussion with Chethana, We need to make switch box color >>>>>> change for light and dark theme, Color details provided by Chethana is >>>>>> updated on ticket. >>>>>> >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Murtuza Zabuawala >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>> >>>>> -- >>>>> Chethana Kumar >>>>> Principal UI/UX Designer >>>>> EnterpriseDB Corporation >>>>> >>>>> The Postgres Database Company >>>>> >>>>> P: +91 86981 57146 >>>>> www.enterprisedb.com >>>>> >>>> >>> >>> -- >>> Chethana Kumar >>> Principal UI/UX Designer >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >>> P: +91 86981 57146 >>> www.enterprisedb.com >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --0000000000006618c505a12fc5fa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Murtuza,

The patch looks good to me.

On Thu, Mar 1= 9, 2020 at 12:10 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
<= /div>
Hello,

PFA updated= patch with new colors provided by Chethana, As discussed we will be using = the same primary success=C2=A0color in both theme so we don't have add = new variable.


<= div dir=3D"ltr">
--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www= .enterprisedb.com
The Enterprise PostgreSQL Company

=


On Wed, Mar 18, 2020 at= 2:27 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:<= br>
Hi M= urtuza/Chethana,

Irrespective of what color you suggest, there is no n= eed to add new variables for switch buttons. It should use success for on a= nd ternary for off.
Having a separate green color for each and every contro= l is absurd. If the green changes, it should change for all.
On Wed, M= ar 18, 2020 at 2:24 PM Chethana Kumar <chethana.kumar@enterprisedb.com>= wrote:
Let us discuss on a call for better clarity and the conclusion par= t we can put it on mail.

---
Chethana kumar

On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala <murtuza.zabuawala@ent= erprisedb.com> wrote:
Hi Chethana,

No it = is not, As per current dark theme implementation=C2=A0we have used primary = color '#1a522b' for switch but the color you suggested is '#43A047' for bo= th theme.


--
Regards,
Murtuza Zabuawala
Enterprise= DB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany


<= /div>

On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar <chethana.kumar@ente= rprisedb.com> wrote:
Hi Murtuza,

The changes are= already incorporated so no worries :)

Thanks,

---
Chethana kumar

On Wed, Mar 18, 202= 0 at 12:43 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>= wrote:
= Hello,

As per discussion with Chethana, We need to make swit= ch box color change for light and dark theme, Color details provided by Che= thana is updated on ticket.
=C2=A0

--
Regards,
Murtuza Za= buawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The En= terprise PostgreSQL Company
=
<= /div>


--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation

The Postgres Database Company

P: +91 86981= 57146
=


--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation

The Postgres Database Company

P: +91 86981= 57146
=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks and Regards,Aditya Toshniwal
pgAdmin Hacker | Sr. S= oftware Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat= , Plant a TREE"
=
--0000000000006618c505a12fc5fa--