MIME-Version: 1.0
References: 
 <CAJ9T6Su+ib=bZ1EdHbD=HPfA6xBi0-N3RZ5dwsU6dReT2njeaQ@mail.gmail.com>
In-Reply-To: 
 <CAJ9T6Su+ib=bZ1EdHbD=HPfA6xBi0-N3RZ5dwsU6dReT2njeaQ@mail.gmail.com>
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Fri, 11 Jun 2021 19:37:54 +0530
Message-ID: 
 <CAM9w-_kyf8reg8pw+qa=CaRKiU0i5Vfmyj34BSDSTXB6dP8w4w@mail.gmail.com>
Subject: Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error
To: Pradip Parkale <pradip.parkale@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000d4750505c47e0a7b"
Archived-At: 
 <https://www.postgresql.org/message-id/CAM9w-_kyf8reg8pw%2Bqa%3DCaRKiU0i5Vfmyj34BSDSTXB6dP8w4w%40mail.gmail.com>
Precedence: bulk

--000000000000d4750505c47e0a7b
Content-Type: text/plain; charset="UTF-8"

Hi Pradip,

Just did a go through to your patch.
The variable "data" which you've formed, will be computed for every row
even though columns won't change. You should move it up and pass it to gen
directly. This will save repeated computations.
Secondly, it should not be named as data. It can be like - numeric_cols or
numeric_keys.

On Fri, Jun 11, 2021 at 7:17 PM Pradip Parkale <
pradip.parkale@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for #6520.Added check to typecast the
> numeric data while downloading the data in CSV format.
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"

--000000000000d4750505c47e0a7b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">Hi Pradip,</div><div class=3D"gmail_default" style=3D"font-fami=
ly:verdana,sans-serif"><br></div><div class=3D"gmail_default" style=3D"font=
-family:verdana,sans-serif">Just did a go through to your patch.=C2=A0</div=
><div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">The =
variable &quot;data&quot; which you&#39;ve formed, will be computed for eve=
ry row even though columns won&#39;t change. You should move it up and pass=
 it to gen directly. This will save repeated computations.</div><div class=
=3D"gmail_default" style=3D"font-family:verdana,sans-serif">Secondly, it sh=
ould=C2=A0not be named as data. It can be like - numeric_cols or numeric_ke=
ys.</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gma=
il_attr">On Fri, Jun 11, 2021 at 7:17 PM Pradip Parkale &lt;<a href=3D"mail=
to:pradip.parkale@enterprisedb.com">pradip.parkale@enterprisedb.com</a>&gt;=
 wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=
=3D"ltr">Hi Hackers,<div><br></div><div>Please find the attached patch for =
#6520.Added check to typecast the numeric data while downloading=C2=A0the d=
ata in CSV format.<br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr">=
<div dir=3D"ltr"><div style=3D"font-size:12.8px">Thanks &amp; Regards,<br><=
/div><div style=3D"font-size:12.8px">Pradip Parkale<br>Software Engineer | =
EnterpriseDB Corporation</div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"lt=
r"><div dir=3D"ltr"><div dir=3D"ltr"><div><font size=3D"2" color=3D"#000000=
" face=3D"arial, sans-serif">Thanks,</font><div><span style=3D"color:rgb(34=
,34,34)"><span style=3D"color:rgb(18,22,70)"><font face=3D"arial, sans-seri=
f">Aditya Toshniwal</font></span></span><font size=3D"2" color=3D"#000000" =
face=3D"verdana, sans-serif"><br></font></div><div><span style=3D"color:rgb=
(18,22,70);font-family:Arial,sans-serif">pgAdmin hacker</span><font size=3D=
"2" color=3D"#000000" style=3D"font-family:verdana,sans-serif">=C2=A0| </fo=
nt><font size=3D"2" color=3D"#000000" face=3D"arial, sans-serif">Sr. Softwa=
re Engineer</font><font size=3D"2" color=3D"#000000"><font face=3D"verdana,=
 sans-serif"> | </font><a href=3D"http://edbpostgres.com" target=3D"_blank"=
><font face=3D"arial, sans-serif" color=3D"#000000"><b>edbpostgres.com</b><=
/font></a></font></div><div><font color=3D"#38761d" size=3D"1"><font face=
=3D"arial, sans-serif">&quot;Don&#39;t Complain about Heat, Plant a TREE&qu=
ot;</font></font></div></div></div></div></div></div></div></div>

--000000000000d4750505c47e0a7b--