Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glukb-0004xi-Di for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 12:01:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1glukZ-0001Jn-VL for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 12:01:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glukZ-0001Jg-Q0 for pgadmin-hackers@lists.postgresql.org; Tue, 22 Jan 2019 12:01:51 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glukS-0004of-Pe for pgadmin-hackers@postgresql.org; Tue, 22 Jan 2019 12:01:51 +0000 Received: by mail-lj1-x241.google.com with SMTP id v15-v6so20298759ljh.13 for ; Tue, 22 Jan 2019 04:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5nOHiBLjphzsUnhnB+ADlhb3EX5wNyK9bx4c1f9qDTY=; b=J2t2g4oE5Z4DQoxNjkVyhsJ24Lut1qYcLIwfQIG291RazJqupIxuaz+Pg3eaJ/QMWq pov6ZJc0ScAjA/xPo7f9QeEczEUiMMkdMmcIFZ3qf403KEyhK9/Dq2+31UTM+PRNtb5N HhsqoG7yZpba1tNuNEVZcS6EiNnSfUk2SvgNl9fVJzPDnQgVWMyFIm7q58rSICtvFXK5 NOTR4dqNgHoinPVZWTuEBkjL04FOOY6o3KjfUyxBgFxiWGyMshMipdgEeJpjbQjVHHan 13dY7XDfGcpL8X1pn8jEsbsw6s64A0uRWw7h9VZqfsPi0v9oc8U3NkFUeg3qSaG7/Oeo +R+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5nOHiBLjphzsUnhnB+ADlhb3EX5wNyK9bx4c1f9qDTY=; b=ZoJFSgQ3xzv50R/l3SQ8LJKeTaxxrd3ZAtZXJYmuRGQRp+hT77wl8tVf4/NM7Dn1rH hbPC4oY+07XV70O67ft1n53piO93JRCGe80FTEqtVQdQhfVnb7ZNF5pvHXDezMsev2td ha1Ke9mwVeaa7EToZW834Ea7mMrRnBbfg+tZ8HBx+rPKwyE3qfm3FNhv7ZExULh1GeT8 AgZ8UYjbPFx4bTjfnnv4u7017a/ur2R2ydIP/h/aZOvldFyKL/nlPH/HFhvN+CoUNZM2 1WWE3W14TjPXrto9/h/RIp6jMX6UQ/YuYcgaFwkuHpyk7mjNR5BiSI3blB/52jkUi9BY XYbw== X-Gm-Message-State: AJcUukclAx6TjvK+uYqBzxGYhhTYEIilbLExO1ZL9ngOmRB8fvNnWW3l WcR7mwxs5vR+pWtatbOhKa/JS8uiVxe8AFYoyt8oig== X-Google-Smtp-Source: ALg8bN504flLXHm9V5MY56oVBEv2ejH0nK/4VBvjNAZMzKqwjPeCtRTuK0CTsVHUGJxJ0NvTjJQZH9Q1vKFbOk7d2dQ= X-Received: by 2002:a2e:9d17:: with SMTP id t23-v6mr19849803lji.57.1548158503525; Tue, 22 Jan 2019 04:01:43 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Tue, 22 Jan 2019 17:31:32 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000a8bec305800abd80" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000a8bec305800abd80 Content-Type: text/plain; charset="UTF-8" On Tue, Jan 22, 2019 at 5:27 PM Dave Page wrote: > On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal > wrote: > > > > Any suggestions on preferences name/desc ? > > Name: "Confirm on close" > Desc: "Confirm closure of the browser or browser tab is intended > before proceeding." > It also warns on refresh. > > > > On Tue, Jan 22, 2019 at 3:01 PM Dave Page > wrote: > >> > >> Hi > >> > >> On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi > >> wrote: > >> > > >> > Hi Aditya > >> > > >> > Below are my review comments: > >> > > >> > You have added new config parameter "DISABLE_BEFOREUNLOAD_MESSAGE" to > make this request configurable, should it be the part of preferences > setting instead of configuration? @Dave can you please comment on this. > >> > >> That does seem like something that should be a per-user preference, > >> not a global config option. > >> > >> > Name "DISABLE_BEFOREUNLOAD_MESSAGE" is not clear as users > perspective, can you please change it to some meaningful name. > >> > > >> > Apart from that code looks good to me. > >> > > >> > On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> >> > >> >> Hi Hackers, > >> >> > >> >> Attached is the patch to throw alert warning when user reloads or > closes the browser. > >> >> > >> >> Kindly review. > >> >> > >> >> -- > >> >> Thanks and Regards, > >> >> Aditya Toshniwal > >> >> Software Engineer | EnterpriseDB Software Solutions | Pune > >> >> "Don't Complain about Heat, Plant a tree" > >> > > >> > > >> > > >> > -- > >> > Akshay Joshi > >> > Sr. Software Architect > >> > > >> > > >> > Phone: +91 20-3058-9517 > >> > Mobile: +91 976-788-8246 > >> > >> > >> > >> -- > >> Dave Page > >> VP, Chief Architect, Tools & Installers > >> EnterpriseDB: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > >> > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > > > > > > > > -- > > Thanks and Regards, > > Aditya Toshniwal > > Software Engineer | EnterpriseDB Software Solutions | Pune > > "Don't Complain about Heat, Plant a tree" > > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --000000000000a8bec305800abd80 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Jan 22, 2019 at 5:27 PM Dave= Page <dave.page@enterpris= edb.com> wrote:
On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal
<= aditya.toshniwal@enterprisedb.com> wrote:
>
> Any suggestions on preferences name/desc ?

Name: "Confirm on close"
Desc: "Confirm closure of the browser or browser tab is intended
before proceeding."
It also warns on refresh.<= /div>


> On Tue, Jan 22, 2019 at 3:01 PM Dave Page <dave.page@enterprisedb.com> = wrote:
>>
>> Hi
>>
>> On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi
>> <akshay.joshi@enterprisedb.com> wrote:
>> >
>> > Hi Aditya
>> >
>> > Below are my review comments:
>> >
>> > You have added new config parameter "DISABLE_BEFOREUNLOA= D_MESSAGE" to make this request configurable, should it be the part of= preferences setting instead of configuration? @Dave can you please comment= on this.
>>
>> That does seem like something that should be a per-user preference= ,
>> not a global config option.
>>
>> > Name "DISABLE_BEFOREUNLOAD_MESSAGE" is not clear as= users perspective, can you please change it to some meaningful name.
>> >
>> > Apart from that code looks good to me.
>> >
>> > On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
>> >>
>> >> Hi Hackers,
>> >>
>> >> Attached is the patch to throw alert warning when user re= loads or closes the browser.
>> >>
>> >> Kindly review.
>> >>
>> >> --
>> >> Thanks and Regards,
>> >> Aditya Toshniwal
>> >> Software Engineer | EnterpriseDB Software Solutions | Pun= e
>> >> "Don't Complain about Heat, Plant a tree" >> >
>> >
>> >
>> > --
>> > Akshay Joshi
>> > Sr. Software Architect
>> >
>> >
>> > Phone: +91 20-3058-9517
>> > Mobile: +91 976-788-8246
>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


--
Thanks and Rega= rds,
Aditya Toshniwa= l
Softw= are Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
&q= uot;Don't Complain about Heat, Plant a tree"
--000000000000a8bec305800abd80--