Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fhunW-0001HQ-LD for pgadmin-hackers@arkaria.postgresql.org; Tue, 24 Jul 2018 10:44:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fhunU-0007fh-Ur for pgadmin-hackers@arkaria.postgresql.org; Tue, 24 Jul 2018 10:44:04 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fhunU-0007fa-HV for pgadmin-hackers@lists.postgresql.org; Tue, 24 Jul 2018 10:44:04 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fhunQ-0000Mp-HF for pgadmin-hackers@postgresql.org; Tue, 24 Jul 2018 10:44:02 +0000 Received: by mail-lj1-x241.google.com with SMTP id 203-v6so3140288ljj.13 for ; Tue, 24 Jul 2018 03:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8nLMGZ2Lr6gSMSXgpzbSObH23OPKvdH8mQma0lmiFjg=; b=aMLiXPSoGQOBVZivxFAwMa59I5r5+5PsHrOVWydHEITOpGSIU6dKBnkAbtcI3EnDn1 gUxI1bDelk0wOhUhiKoorPhWom3pYzDLSZvat5N+H8PczhY9NP9eNk5P4JGgCXrKVrdc gNubChKEG44FdeOl+eLwLfkiI6Kwd7wdsr02N7aplwCkCaYEeGRIXLg/FSH2uVn5BGhe pa8eGRtIezHq1s2JDpxU9RTrlGpy9wCordp4/kTuOCCBdOGY9ge8SH8N0Uim9BiWn4fd GPWDV4fwr7jpYHAo3NrJXi/FIqnXDaVt9beoSM0pnwz0iWV1SegdowySDPwXmkQAtyfS Cf1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8nLMGZ2Lr6gSMSXgpzbSObH23OPKvdH8mQma0lmiFjg=; b=ZVa3DOQbl2CNbH80R+vnqf9pOhVldzohroG+NzgWXKk6ykKolk3gMt2Ne6lUhoZ6yn 7lapKmicerfewJWnqT3BHCLf+uHEHm0CChKTTKNzXtlBRJdDtgELalFE30h4lnlYQvZH 1IREaFeUTWnr6ey5DKq2c1tHDDVzpb2rFFHko9MUwvgwg46LFhsOVSR3JX+UvSH4Tsgd FHM2YtjK5aZcWZ110iR9C0RPfzrVAy11jV6t/RhsqxXiYsoZfUObmPWCGzEIhO3agiTi DN9hYMsJ5iar6vNiRGgqkamBqlVryen/rQVqAO6z9lg6epFl51s3THr/MGhfLJFcDmS/ t6Ng== X-Gm-Message-State: AOUpUlGl8OVb8dGQBhMp7AzrJVYrWzrmbQZ8N72Ooy3/T0DgAqwDFxl4 iyvxKBH2zsyq0vkUOG/THkweslV/fVowP7ywZdqwCg== X-Google-Smtp-Source: AAOMgpeDi7DYYJvfg+scEGS+NZ82jhFPgpn6u90+DyqA8DSZcBLxjFPdO4OeuqZNLRRKlO0yrKRYA/GIkGyZaMLBmEk= X-Received: by 2002:a2e:40c:: with SMTP id 12-v6mr12178206lje.146.1532429037458; Tue, 24 Jul 2018 03:43:57 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:8703:0:0:0:0:0 with HTTP; Tue, 24 Jul 2018 03:43:57 -0700 (PDT) In-Reply-To: References: From: Aditya Toshniwal Date: Tue, 24 Jul 2018 16:13:57 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000006becca0571bc7009" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000006becca0571bc7009 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Adding to previous mail, I have removed shadow from graph lines and increased resolution for better visibility and fixed few issues related to graphs. On Tue, Jul 24, 2018 at 4:09 PM, Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the second part of the changes for making preferences > realtime. The patch includes dashboard and debugger modules. > I would also request to create RMs for javascript test cases for dashboar= d > and debugger modules as currently there is no setup for the test cases of > these two modules. > The changes are on the JS side and so patch does not have any test cases > included. > > Kindly review. > > > On Thu, Jul 5, 2018 at 4:09 PM, Dave Page wrote: > >> Thanks - patch applied! >> >> On Wed, Jul 4, 2018 at 10:19 AM, Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the updated patch for the RM. Change of the flags like auto >>> commit, explain->verbose, etc. will reflect in all other open sql edito= rs. >>> Kindly review. >>> >>> On Fri, Jun 29, 2018 at 10:39 PM, Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> On Fri, Jun 29, 2018 at 9:30 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Fri, Jun 29, 2018 at 3:14 PM, Aditya Toshniwal < >>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Attached is the updated patch. >>>>>> >>>>> >>>>> This seems to work for the most part, however I saw what seemed like >>>>> odd behaviour. If I have 2 query tool windows open; >>>>> >>>>> - Changing a preference from the Preferences dialogue updates both >>>>> query tools. >>>>> >>>>> - Changing a preference from a Query Tool updates the Preferences >>>>> dialogue. >>>>> >>>>> - Changing a preference from a Query Tool does *not* update the other >>>>> Query Tool. >>>>> >>>>> The last point seems odd to me, though it also kinda makes sense to >>>>> not have one query tool affect the other. The problem with that is th= at it >>>>> could get quite confusing when they get out of sync. I think it would= be >>>>> better for a change in one Query Tool to update the other(s). >>>>> >>>>> What do you think? Was this behaviour intentional? >>>>> >>>> >>>> =E2=80=8BNo this was not intentional. It should reflect in other query= tools as >>>> well because changing the flags like Auto Commit changes the preferenc= es >>>> config and is not local to a Query tool. I missed the fact that some >>>> preferences can be changed from other than preference dialog.=E2=80=8B >>>> >>>> =E2=80=8BWill send the updated patch with the fix.=E2=80=8B >>>> >>>>> >>>>> (FYI, in case this was a one-off bug, I was testing using "Auto >>>>> Commit?") >>>>> >>>>> >>>>>> >>>>>> On Fri, Jun 29, 2018 at 4:46 PM, Aditya Toshniwal < >>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Akshay, >>>>>>> >>>>>>> On Fri, Jun 29, 2018 at 3:42 PM, Akshay Joshi < >>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Aditya >>>>>>>> >>>>>>>> I have applied your patch and run pgAdmin4. I have found following >>>>>>>> two issue in the browser: >>>>>>>> >>>>>>>> - Found error while open Preferences dialog. Refer >>>>>>>> Open_Preferences_Dialog.png >>>>>>>> >>>>>>>> =E2=80=8BThis error occurs even with the latest pull without chang= es.=E2=80=8B >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> - Set the preferences setting "Open in new browser tab" to True >>>>>>>> and open the query tool. Refer "Open_In_New_Broswer.png". >>>>>>>> >>>>>>>> =E2=80=8BWill look into this.=E2=80=8B >>>>>>> >>>>>>> >>>>>>>> I haven't review the code. >>>>>>>> >>>>>>>> On Thu, Jun 28, 2018 at 8:04 PM, Aditya Toshniwal < >>>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Hackers, >>>>>>>>> >>>>>>>>> Attached is the patch for making preferences realtime and applyin= g >>>>>>>>> without reseting the layout. Please note, the patch is only for o= ne module >>>>>>>>> - SQL Editor and is the first part for the RM. There are lot of c= hanges to >>>>>>>>> be done to cover all and hence sending in parts. This will not af= fect/break >>>>>>>>> existing code. Further patches will cover other modules. >>>>>>>>> >>>>>>>>> Highlights of this patch include: >>>>>>>>> - Changes will affect SQL Editors in Create dialog boxes, SQL tab >>>>>>>>> of the main screen, Query tool, History entries in the query tool= , Query >>>>>>>>> tool opened in New Tab/Window >>>>>>>>> - All the components of SQL editor will refer to single source of >>>>>>>>> preferences which is cached in the Browser object. All other redu= ndant ajax >>>>>>>>> get preference calls are removed. >>>>>>>>> - SQL editor will not refer template JS variables anymore, once >>>>>>>>> all the references are removed the template variables will also b= e removed. >>>>>>>>> - Code refactoring wherever possible. >>>>>>>>> - Covered JS test cases wherever possible. >>>>>>>>> >>>>>>>>> Request you to kindly review. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Thanks and Regards, >>>>>>>>> Aditya Toshniwal >>>>>>>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>>>>>>> "Don't Complain about Heat, Plant a tree" >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Akshay Joshi* >>>>>>>> >>>>>>>> *Sr. Software Architect * >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Thanks and Regards, >>>>>>> Aditya Toshniwal >>>>>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>>>>> "Don't Complain about Heat, Plant a tree" >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks and Regards, >>>>>> Aditya Toshniwal >>>>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>>>> "Don't Complain about Heat, Plant a tree" >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>> "Don't Complain about Heat, Plant a tree" >>>> >>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > --=20 Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --0000000000006becca0571bc7009 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Adding to previous mail,

I have removed shadow from graph = lines and increased resolution for better visibility and fixed few issues r= elated to graphs.

On Tue, Jul 24, 2018 at 4:09 PM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the second par= t of the changes for making preferences realtime. The patch includes dashbo= ard and debugger modules.
I would also request to create RMs for javascript= test cases for dashboard and debugger modules as currently there is no set= up for the test cases of these two modules.
The changes are on the JS side = and so patch does not have any test cases included.

Kindly review.

On Thu, Jul 5, 2018 at 4:09 PM, Dave Pa= ge <dpage@pgadmin.org> wrote:
Thanks - patch applied!

On Wed, Jul 4, 2018 at 10:19 AM, = Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hacke= rs,

Attached is the updated patch for the RM. Change of the flags like= auto commit, explain->verbose, etc. will reflect in all other open sql = editors.
Kindly review.

On Fri= , Jun 29, 2018 at 10:39 PM, Aditya Toshniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
Hi Dave,

On Fri, Jun 29, 2018 at 9:30 PM, Dave Page <dpage@= pgadmin.org> wrote:
Hi

<= span>On Fri, Jun 29, 2018 at 3:14 PM, Aditya Toshniwal &l= t;ad= itya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,=C2=A0

Attached is = the updated patch.

This seems t= o work for the most part, however I saw what seemed like odd behaviour. If = I have 2 query tool windows open;

- Changing a pre= ference from the Preferences dialogue updates both query tools.
<= br>
- Changing a preference from a Query Tool updates the Prefere= nces dialogue.

- Changing a preference from a Quer= y Tool does *not* update the other Query Tool.

The= last point seems odd to me, though it also kinda makes sense to not have o= ne query tool affect the other. The problem with that is that it could get = quite confusing when they get out of sync. I think it would be better for a= change in one Query Tool to update the other(s).=C2=A0

What do you think? Was this behaviour intentional?
<= /div>
=C2=A0
=E2=80=8BNo this was not inte= ntional. It should reflect in other query tools as well because changing th= e flags like Auto Commit changes the preferences config and is not local to= a Query tool. I missed the fact that some preferences can be changed from = other than preference dialog.=E2=80=8B
=C2=A0
=E2=80=8BWill s= end the updated patch with the fix.=E2=80=8B

(FYI, in case this was a one-off bu= g, I was testing using "Auto Commit?")
=C2=A0

On = Fri, Jun 29, 2018 at 4:46 PM, Aditya Toshniwal <aditya.tos= hniwal@enterprisedb.com> wrote:
Hi= Akshay,

On Fri, Jun 29, 2018 at 3:42 PM, Akshay Joshi <akshay.joshi= @enterprisedb.com> wrote:
Hi Aditya=C2=A0

I have applied your= patch and run pgAdmin4. I have found following two issue in the browser:
  • Found error while open Preferences dialog. Refer Open_Pref= erences_Dialog.png
=E2=80=8BThis error occu= rs even with the latest pull without changes.=E2=80=8B
=C2=A0
  • Set the pre= ferences setting "Open in new browser tab" to True and open the q= uery tool. Refer "Open_In_New_Broswer.png".
=
=E2=80=8BWill look into this.=E2=80=8B
=C2=A0
I haven't review the cod= e.

On Thu, Jun 28, 2018 at 8:04 PM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached i= s the patch for making preferences realtime and applying without reseting t= he layout. Please note, the patch is only for one module - SQL Editor and i= s the first part for the RM. There are lot of changes to be done to cover a= ll and hence sending in parts. This will not affect/break existing code. Fu= rther patches will cover other modules.

Hig= hlights of this patch include:
- Changes will affect SQL Editors in Create dialog boxes, SQL tab of= the main screen, Query tool, History entries in the query tool, Query tool= opened in New Tab/Window
- All the components of SQL editor will refer to single source of prefere= nces which is cached in the Browser object. All other redundant ajax get pr= eference calls are removed.
-=C2=A0SQL editor will not refer template JS variables anymore, once = all the references are removed the template variables will also be removed.=
- Code refactori= ng wherever possible.
- = Covered JS test cases wherever possible.

Re= quest you to kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0Enterprise= DB Software Solutions |=C2=A0Pune
"Don't C= omplain about Heat, Plant a tree"



--
Akshay Joshi
= Sr. Software Architect

<= img src=3D"http://www.enterprisedb.com/sites/default/files/EDB-logo-4c.png"= width=3D"96" height=3D"54">

Phone: +91 20-3058-9517
= Mobile: +91 976-788-8246



--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB S= oftware Solutions |=C2=A0Pune
"Don't Complain about Heat,= Plant a tree"



--
<= font face=3D"trebuchet ms, sans-serif" size=3D"2" color=3D"#000000">Thanks = and Regards,
<= font face=3D"trebuchet ms, sans-serif" size=3D"2" color=3D"#000000">Aditya = Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0<= /span>Pune
"Don't Complain about Heat, Plant a tree"=



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
=
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



<= /div>--
Thanks and Regards,Aditya Toshniwal
Software Engineer |= =C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
"Don't = Complain about Heat, Plant a tree"



--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Solutions |=C2= =A0Pune
"Don't Complain about Heat, Plant a tree"



--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twit= ter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Post= greSQL Company



--
=
Thanks and Regards,Aditya Toshniwal
Software Engineer |= =C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
"Don't = Complain about Heat, Plant a tree"



--
=
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB So= ftware Solutions |=C2=A0Pune
"Don't Complain about Heat, = Plant a tree"
--0000000000006becca0571bc7009--