MIME-Version: 1.0
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Wed, 23 Jan 2019 11:01:06 +0530
Message-ID: 
 <CAM9w-_m3O-GHwDTOjjoqVM7xvc6RhX3y6fOdQXyELv1m7a+pdg@mail.gmail.com>
Subject: [pgAdmin4][patch] pgAdmin4 better exception handling
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000038f7a2058019675d"
Precedence: bulk

--00000000000038f7a2058019675d
Content-Type: multipart/alternative; boundary="00000000000038f79f058019675b"

--00000000000038f79f058019675b
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

Attached patch will improve exception handling for pgAdmin4 on the server
side. The app level exception handler will handle unhandled exception
gracefully, logging it and sending the exception message as response.
This will also help in getting the exception where users are facing query
tool initialise error.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

--00000000000038f79f058019675b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">Hi Hackers,</div><div class=3D"gmail_default" style=3D"font-fam=
ily:verdana,sans-serif"><br></div><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif">Attached patch will improve exception handling=
 for pgAdmin4 on the server side. The app level exception handler will hand=
le unhandled exception gracefully, logging it and sending the exception mes=
sage as response.</div><div class=3D"gmail_default" style=3D"font-family:ve=
rdana,sans-serif">This will also help in getting the exception where users =
are facing query tool initialise error.</div><div class=3D"gmail_default" s=
tyle=3D"font-family:verdana,sans-serif"><br></div><div class=3D"gmail_defau=
lt" style=3D"font-family:verdana,sans-serif">Kindly review.</div><div><br><=
/div>-- <br><div dir=3D"ltr" class=3D"gmail_signature" data-smartmail=3D"gm=
ail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><font face=3D"trebuch=
et ms, sans-serif" size=3D"2" color=3D"#000000">Thanks and Regards,</font><=
div><span style=3D"background-color:rgb(255,255,255)"><font face=3D"trebuch=
et ms, sans-serif" size=3D"2" color=3D"#000000">Aditya Toshniwal</font></sp=
an></div><div><span style=3D"background-color:rgb(255,255,255)"><font face=
=3D"trebuchet ms, sans-serif" size=3D"2" color=3D"#000000">Software Enginee=
r |=C2=A0EnterpriseDB Software Solutions |=C2=A0</font></span><span style=
=3D"color:rgb(0,0,0);font-family:&quot;trebuchet ms&quot;,sans-serif;font-s=
ize:small">Pune</span></div><div><span style=3D"font-family:&quot;trebuchet=
 ms&quot;,sans-serif;font-size:x-small"><font color=3D"#38761d">&quot;Don&#=
39;t Complain about Heat, Plant a tree&quot;</font></span></div></div></div=
></div></div></div>

--00000000000038f79f058019675b--

--00000000000038f7a2058019675d
Content-Type: application/octet-stream; name="pgadmin.errorhandle.patch"
Content-Disposition: attachment; filename="pgadmin.errorhandle.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_jr8r30o30>
X-Attachment-Id: f_jr8r30o30

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL19faW5pdF9fLnB5IGIvd2ViL3BnYWRtaW4vX19pbml0
X18ucHkKaW5kZXggMTY0OWIyYmMuLmM2NDI0NWRlIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9f
X2luaXRfXy5weQorKysgYi93ZWIvcGdhZG1pbi9fX2luaXRfXy5weQpAQCAtMzQsNiArMzQsOCBA
QCBmcm9tIHBnYWRtaW4udXRpbHMuc2Vzc2lvbiBpbXBvcnQgY3JlYXRlX3Nlc3Npb25faW50ZXJm
YWNlLCBwZ2FfdW5hdXRob3Jpc2VkCiBmcm9tIHBnYWRtaW4udXRpbHMudmVyc2lvbmVkX3RlbXBs
YXRlX2xvYWRlciBpbXBvcnQgVmVyc2lvbmVkVGVtcGxhdGVMb2FkZXIKIGZyb20gZGF0ZXRpbWUg
aW1wb3J0IHRpbWVkZWx0YQogZnJvbSBwZ2FkbWluLnNldHVwIGltcG9ydCBnZXRfdmVyc2lvbiwg
c2V0X3ZlcnNpb24KK2Zyb20gcGdhZG1pbi51dGlscy5hamF4IGltcG9ydCBpbnRlcm5hbF9zZXJ2
ZXJfZXJyb3IKKwogCiAjIElmIHNjcmlwdCBpcyBydW5uaW5nIHVuZGVyIHB5dGhvbjMsIGl0IHdp
bGwgbm90IGhhdmUgdGhlIHhyYW5nZSBmdW5jdGlvbgogIyBkZWZpbmVkCkBAIC02NjIsNiArNjY0
LDEyIEBAIGRlZiBjcmVhdGVfYXBwKGFwcF9uYW1lPU5vbmUpOgogICAgICAgICAgICAgJ2N1cnJl
bnRfYmx1ZXByaW50JzogY3VycmVudF9ibHVlcHJpbnQKICAgICAgICAgfQogCisgICAgQGFwcC5l
cnJvcmhhbmRsZXIoRXhjZXB0aW9uKQorICAgIGRlZiBhbGxfZXhjZXB0aW9uX2hhbmRsZXIoZSk6
CisgICAgICAgIGN1cnJlbnRfYXBwLmxvZ2dlci5lcnJvcihlKQorICAgICAgICByZXR1cm4gaW50
ZXJuYWxfc2VydmVyX2Vycm9yKGVycm9ybXNnPXN0cihlKSkKKworCiAgICAgIyMjIyMjIyMjIyMj
IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj
IyMjIyMKICAgICAjIEFsbCBkb25lIQogICAgICMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj
IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCmRpZmYgLS1naXQg
YS93ZWIvcGdhZG1pbi90b29scy9kYXRhZ3JpZC9zdGF0aWMvanMvZGF0YWdyaWQuanMgYi93ZWIv
cGdhZG1pbi90b29scy9kYXRhZ3JpZC9zdGF0aWMvanMvZGF0YWdyaWQuanMKaW5kZXggNmRlNzM4
OWYuLjg1MWQ1M2ZmIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi90b29scy9kYXRhZ3JpZC9zdGF0
aWMvanMvZGF0YWdyaWQuanMKKysrIGIvd2ViL3BnYWRtaW4vdG9vbHMvZGF0YWdyaWQvc3RhdGlj
L2pzL2RhdGFncmlkLmpzCkBAIC00MzgsOCArNDM4LDggQEAgZGVmaW5lKCdwZ2FkbWluLmRhdGFn
cmlkJywgWwogICAgICAgICAgICAgICBlcnIuZXJyb3Jtc2cKICAgICAgICAgICAgICk7CiAgICAg
ICAgICAgfSBjYXRjaCAoZSkgewotICAgICAgICAgICAgYWxlcnRpZnkuYWxlcnQoCi0gICAgICAg
ICAgICAgIGUuc3RhdHVzVGV4dCwgZ2V0dGV4dCgnUXVlcnkgVG9vbCBJbml0aWFsaXplIEVycm9y
JykKKyAgICAgICAgICAgIGFsZXJ0aWZ5LmFsZXJ0KGdldHRleHQoJ1F1ZXJ5IFRvb2wgSW5pdGlh
bGl6ZSBFcnJvcicpLAorICAgICAgICAgICAgICBlLnN0YXR1c1RleHQKICAgICAgICAgICAgICk7
CiAgICAgICAgICAgfQogICAgICAgICB9KTsK
--00000000000038f7a2058019675d--