Re: Explain details popover changes proposal

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Dave Page <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Explain details popover changes proposal
Date: Fri, 8 Jan 2021 17:07:28 +0530
Message-ID: <CAM9w-_m4uAGN1QJSaa6Raru86XbOX57Oh19A5580RdkrEqh-Gw@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoyLDVCJB=mL1LjwLNM23=zb-i4A9hMdi2bGbHN2c1wx8w@mail.gmail.com>
References: <CAM9w-_=+ifZrvJ-RpdaKo0Y7JX18wFurz8VPK35MAPY9=5t1ng@mail.gmail.com>
	<CAG7mmoyuJABP5b_2ngdZ5aKmkB_wSP7zp_WAQ+nnPJYRtB+84g@mail.gmail.com>
	<CA+OCxoyMTHwba6dVYVb73pPyKEGuL=2XEc7HywZrBJhb0T1Pug@mail.gmail.com>
	<CAG7mmozj+RaD2o3AzRj_=LGGZ0mz1pds+SbibHo1=GNKV_4_Og@mail.gmail.com>
	<CA+OCxowO_Wv1BWyiuBMzmaiJhOQYmaRbmSAZKBHKqGPzebK__w@mail.gmail.com>
	<CAM9w-_n82T_+H2DZaLjFS8k-FQerxQqK9duHS0Af=BXbfvgHfQ@mail.gmail.com>
	<CA+OCxoyLDVCJB=mL1LjwLNM23=zb-i4A9hMdi2bGbHN2c1wx8w@mail.gmail.com>

Hi,

On Fri, Jan 8, 2021 at 4:30 PM Dave Page <[email protected]> wrote:

>
>
> On Fri, Jan 8, 2021 at 10:46 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi,
>>
>>
>> On Fri, Jan 8, 2021 at 2:53 PM Dave Page <[email protected]> wrote:
>>
>>>
>>>
>>> On Fri, Jan 8, 2021 at 9:17 AM Ashesh Vashi <
>>> [email protected]> wrote:
>>>
>>>>
>>>>
>>>> On Fri, 8 Jan 2021 at 14:43, Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Fri, Jan 8, 2021 at 8:36 AM Ashesh Vashi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> On Fri, Jan 8, 2021 at 12:37 PM Aditya Toshniwal <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Hackers,
>>>>>>>
>>>>>>> I'm working on https://redmine.postgresql.org/issues/5488 and as
>>>>>>> per the discussion, we'll remove the current tooltip way for showing the
>>>>>>> details. Instead, we'll add some popover/panel upon clicking a node
>>>>>>> which will stay until closed.
>>>>>>> Below is the screenshot of partial implementation.
>>>>>>>
>>>>>> I like the idea of showing details in the pop up.
>>>>>>
>>>>>
>>>>> I agree, though I think the presentation could use some work to make
>>>>> the table-like layout a little cleaner (maybe alternating row shading or
>>>>> subtle cell borders or something). Perhaps check with Aradhana or Chethana
>>>>> for ideas?
>>>>>
>>>> Yes.
>>
>>>
>>>>>
>>>>>> We also need to think about the details in the SVG file downloaded.
>>>>>>
>>>>>
>>>>> We ignore the popups entirely at the moment don't we? It would be good
>>>>> to render any that are open though.
>>>>>
>>>>
>>>> We have put details in the title attribute, hence - it should be
>>>> visible as cluttered text on hover. (Assumption - I have not tried).
>>>>
>>>
>>> OK, well it seems reasonable to continue to do that for all nodes.
>>> However, maybe we should also render any popups that are open at time of
>>> download - that way, printing or converting to a raster format will still
>>> display those popups.
>>>
>> With the new changes, the SVG tooltip will be removed completely. The new
>> pop up is HTML based and floats above the diagram. I mean, if you zoom
>> in/out the plan, it does not affect the popup.
>> I'm thinking to append all the tables to the download SVG and add click
>> events on the nodes which will scroll to that table. This is just a
>> thought, not sure if it will work. But that would be a separate task.
>>
>
> We certainly shouldn't remove functionality that works now, without
> replacing it with something at least as good.
>

> I think this is relatively low priority though - can't we just fix the
> basic problem, or is that caused by the SVG tooltips, whose location is out
> of our control?
>
Currently toolips appear only on hover, and if they are large then there is
no way to see them completely. In the past, there have been attempts to fix
it but still it causes issues. Correcting my previous comment, it's a html
tooltip and not a SVG tooltip.
With the new changes, multiple issues are fixed together - tooltip will not
go out of screen, user can see full details, UX improved.


>
>
>>
>>>
>>>>
>>>> — Ashesh
>>>>
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>> -- Ashesh
>>>>>>
>>>>>>
>>>>>>> Please confirm if I can proceed with full implementation.
>>>>>>>
>>>>>>> [image: Screenshot 2021-01-08 at 12.31.06 PM.png]
>>>>>>>
>>>>>>> --
>>>>>>> Thanks,
>>>>>>> Aditya Toshniwal
>>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>>>>>> <http://edbpostgres.com;
>>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EDB: http://www.enterprisedb.com
>>>>>
>>>>> --
>>>>
>>>> --
>>>>
>>>> Thanks & Regards,
>>>>
>>>> Ashesh Vashi
>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>> <http://www.enterprisedb.com;
>>>>
>>>>
>>>> *http://www.linkedin.com/in/asheshvashi*
>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EDB: http://www.enterprisedb.com
>>>
>>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>

-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [image/png] Screenshot 2021-01-08 at 12.31.06 PM.png (317.7K, 3-Screenshot%202021-01-08%20at%2012.31.06%20PM.png)
  download | view image

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Explain details popover changes proposal
  In-Reply-To: <CAM9w-_m4uAGN1QJSaa6Raru86XbOX57Oh19A5580RdkrEqh-Gw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox