MIME-Version: 1.0
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Wed, 9 Jan 2019 16:16:03 +0530
Message-ID: 
 <CAM9w-_mBN5ZYxTZ2wcWuJ6RLvsffG+iha9Zb8bRJok=-cuNZ7w@mail.gmail.com>
Subject: [pgAdmin4][RM3575] Right click does not work on database node if
 server name changed
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000c4b07e057f042b3a"
Precedence: bulk

--000000000000c4b07e057f042b3a
Content-Type: multipart/alternative; boundary="000000000000c4b07b057f042b38"

--000000000000c4b07b057f042b38
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

Attached is the patch to fix the issue where changing the name (or any
visible property on tree) of the server node breaks the context menu on the
database nodes.

The user information of the server is updated on successful connection.
Here, the data is updated on the aciTreeNode(domNode). But, in the context
menu the user data is referred from TreeNode object (a wrapper to
aciTreeNode). After checking the code (and a lot of debugging) it was found
that aciTreeNode and TreeNode point to two different data(I don't know
why). Every time you change one, it should be synced to other, which is not
done everywhere.
Changes are done to point both aciTreeNode and TreeNode data to the same
data object.

Kindly review.
-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

--000000000000c4b07b057f042b38
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">Hi Hackers,</div><div class=3D"gmail_default" style=3D"font-fam=
ily:verdana,sans-serif"><br></div><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif">Attached is the patch to fix the issue where c=
hanging the name (or any visible property on tree) of the server node break=
s the context menu on the database nodes.</div><div class=3D"gmail_default"=
 style=3D"font-family:verdana,sans-serif"><br></div><div class=3D"gmail_def=
ault" style=3D"font-family:verdana,sans-serif">The user information of the =
server is updated on successful connection. Here, the data is updated on th=
e aciTreeNode(domNode). But, in the context menu the user data is referred =
from TreeNode object (a wrapper to aciTreeNode). After checking the code (a=
nd a lot of debugging) it was found that aciTreeNode and TreeNode point to =
two different data(I don&#39;t know why). Every time you change one, it sho=
uld be synced to other, which is not done everywhere.</div><div class=3D"gm=
ail_default" style=3D"font-family:verdana,sans-serif">Changes are done to p=
oint both aciTreeNode and TreeNode data to the same data object.</div><div =
class=3D"gmail_default" style=3D"font-family:verdana,sans-serif"><br></div>=
<div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">Kindl=
y review.</div>-- <br><div dir=3D"ltr" class=3D"gmail_signature" data-smart=
mail=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><font face=
=3D"trebuchet ms, sans-serif" size=3D"2" color=3D"#000000">Thanks and Regar=
ds,</font><div><span style=3D"background-color:rgb(255,255,255)"><font face=
=3D"trebuchet ms, sans-serif" size=3D"2" color=3D"#000000">Aditya Toshniwal=
</font></span></div><div><span style=3D"background-color:rgb(255,255,255)">=
<font face=3D"trebuchet ms, sans-serif" size=3D"2" color=3D"#000000">Softwa=
re Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0</font></span><sp=
an style=3D"color:rgb(0,0,0);font-family:&quot;trebuchet ms&quot;,sans-seri=
f;font-size:small">Pune</span></div><div><span style=3D"font-family:&quot;t=
rebuchet ms&quot;,sans-serif;font-size:x-small"><font color=3D"#38761d">&qu=
ot;Don&#39;t Complain about Heat, Plant a tree&quot;</font></span></div></d=
iv></div></div></div></div>

--000000000000c4b07b057f042b38--

--000000000000c4b07e057f042b3a
Content-Type: application/octet-stream; name="RM3575.patch"
Content-Disposition: attachment; filename="RM3575.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_jqp264xg0>
X-Attachment-Id: f_jqp264xg0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy90cmVlL3RyZWUuanMgYi93ZWIvcGdh
ZG1pbi9zdGF0aWMvanMvdHJlZS90cmVlLmpzCmluZGV4IGVkMmY2M2Q5Li43ODJmNGQ1OSAxMDA2
NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL2pzL3RyZWUvdHJlZS5qcworKysgYi93ZWIvcGdh
ZG1pbi9zdGF0aWMvanMvdHJlZS90cmVlLmpzCkBAIC0xMzUsNyArMTM1LDcgQEAgZXhwb3J0IGNs
YXNzIFRyZWUgewogICAgIH0KICAgICBjb25zdCBvbGROb2RlID0gdGhpcy5maW5kTm9kZShvbGRO
b2RlUGF0aCk7CiAgICAgaWYgKG9sZE5vZGUgIT09IG51bGwpIHsKLSAgICAgIG9sZE5vZGUuZGF0
YSA9IE9iamVjdC5hc3NpZ24oe30sIGRhdGEpOworICAgICAgb2xkTm9kZS5kYXRhID0gZGF0YTsK
ICAgICAgIHJldHVybiBvbGROb2RlOwogICAgIH0KIAo=
--000000000000c4b07e057f042b3a--