Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPfme-00082I-Ko for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Oct 2019 04:40:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iPfmc-0008CC-VH for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Oct 2019 04:40:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPfmc-0008C5-IK for pgadmin-hackers@lists.postgresql.org; Wed, 30 Oct 2019 04:40:34 +0000 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPfmX-0000WU-FC for pgadmin-hackers@postgresql.org; Wed, 30 Oct 2019 04:40:33 +0000 Received: by mail-ot1-x341.google.com with SMTP id z6so1004501otb.2 for ; Tue, 29 Oct 2019 21:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hKL9g5FFenOmXhy0wJ+HHUHYe6H4YI5t2PTAvaOCmZ0=; b=wGYVHy6HzyFU54fOX+U0AVijt12nKjnxP3dtTLnYBU/9jOtJMQQEUv02i/nFoyN3De ejY1XEzBn4hmX8pFFc6qGIrPZt0GxJPGwG9r3aRn8y1oSBvqsZh+mQ0eBsd9n+4D3WAI enO1iDUkKhWLMmWaASf933OFkMc7MIRNaxMRgLHaElYMjlcILa8jjRHImGRtj2UzWtR2 0ddcJkJ5SmlWz8ylhvuCtp+C2xOOXARHvGMsYOQzjA2BkOGMvBst5jA4GZ9SxhlGKml4 ivpCpkJEgkG+FZX8xjycqbU6SKE8UC0LWKparCBHxCMRuGM10Ho1vL8uTSeB4l4cc501 7G5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hKL9g5FFenOmXhy0wJ+HHUHYe6H4YI5t2PTAvaOCmZ0=; b=kzaOxTcXGsNinyKH1O02mmC5UVAkKLjitrIO7kyBEJsmnFGMRVZLXaetihCb1Vc7ut omVZMhyQtqyYtQ72xumW7yUTyHQw8BN3MFM4rO6Br99chC1i6Y3rfiGCjBZ8DjfM3jPE svV2Z0BLUOIoQJh7fJVaqlBruqDbEKIS/rzUj6+9/Qz6EELkN5e00iftb11MSep9JGxi YYJ8M/Jn76LgmEYGQQ0RoPJrh+NjOoofQvklVNC8f3b1e0asLFA5kwdS1ePed02oEjmq cTJelnB8KwV0ufmCLWcii7yo6/vxjwe6EKixENmPkOz01SSfsBSaCz7BODr6Na/+X/3q 0Cqw== X-Gm-Message-State: APjAAAW/u99qhsWJbarCt/LQT5VfmsZRRlnX4Yzs1osB0bd1hwI4aBVQ 3SgyHDDSYVxM9iZ4/bbD/gyDMoBbBFf9Xlfc+Osla02FEVLpkdYukz7rIhuQFvMC63D3MsldaWv z/8LZC2SsaVUjLlzAJPKemLpcv1tMNveahKKDZSLjegadcupmwO4cV397LGz0vJeYBQlWI8VI43 sZVFg6WxIPEW5QNwrWmH4ZQxzeK0aqctdGCMrhuvfCYnC0kOldtpFjrjul X-Google-Smtp-Source: APXvYqx9aZlFy51uRa5SFVe18iunoYuN3sGvQsD2PFYb6fdk/vwlyl3Dr5vTCysB+a6OwCNkS4TWa4fh0swiKbYfvlo= X-Received: by 2002:a9d:65cb:: with SMTP id z11mr7830444oth.195.1572410426954; Tue, 29 Oct 2019 21:40:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Wed, 30 Oct 2019 10:09:50 +0530 Message-ID: Subject: Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000f0ced80596195414" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000f0ced80596195414 Content-Type: multipart/alternative; boundary="000000000000f0ced60596195412" --000000000000f0ced60596195412 Content-Type: text/plain; charset="UTF-8" Hi, On Tue, Oct 29, 2019 at 9:01 PM Dave Page wrote: > Hi > > I just found an, umm, embarrassing issue with this. It asks for the cancel > confirmation even when pressing the OK button :-o > Tested all but missed the obvious. Bad miss :/ Attached is the patch to fix the issue. > > Can you fix that ASAP please? > > On Tue, Oct 29, 2019 at 2:35 PM Dave Page wrote: > >> Thanks, applied. >> >> On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to warn the user before closing an unsaved >>> properties dialog. >>> Additionally, I have added a preference option in Browser->Display where >>> the user can disable this. Default is enabled. >>> Docs updated. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --000000000000f0ced60596195412 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

On Tue, Oct 29, 2019 at 9:01 PM Dave= Page <dpage@pgadmin.org> wr= ote:
Hi

I just found an, umm, em= barrassing issue with this. It asks for the cancel confirmation even when p= ressing the OK button :-o
Tested all but missed th= e obvious. Bad miss :/
Attached is the patch to fix the issue.= =C2=A0

Can you fix that ASAP please?

=
On Tue, Oc= t 29, 2019 at 2:35 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.
On Tue, O= ct 29, 2019 at 6:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to warn the user before= closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser-&g= t;Display where the=C2=A0user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB In= dia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"
=
--000000000000f0ced60596195412-- --000000000000f0ced80596195414 Content-Type: application/octet-stream; name="RM4351.part2.patch" Content-Disposition: attachment; filename="RM4351.part2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k2csjecn0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL25vZGUuanMgYi93ZWIv cGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9ub2RlLmpzCmluZGV4IDU1OWNhZWZmYi4uMjkyZDYw YzBkIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9ub2RlLmpzCisr KyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL25vZGUuanMKQEAgLTEwMzMsNyArMTAz Myw4IEBAIGRlZmluZSgncGdhZG1pbi5icm93c2VyLm5vZGUnLCBbCiAgICAgICAgIGogPSBwYW5l bC4kY29udGFpbmVyLmZpbmQoJy5vYmpfcHJvcGVydGllcycpLmZpcnN0KCksCiAgICAgICAgIHZp ZXcgPSBqLmRhdGEoJ29iai12aWV3JyksCiAgICAgICAgIGNvbnRlbnQgPSAkKCc8ZGl2IHRhYmlu ZGV4PSIxIj48L2Rpdj4nKQotICAgICAgICAgIC5hZGRDbGFzcygncGctcHJvcC1jb250ZW50IGNv bC0xMicpOworICAgICAgICAgIC5hZGRDbGFzcygncGctcHJvcC1jb250ZW50IGNvbC0xMicpLAor ICAgICAgICBjb25maXJtX2Nsb3NlID0gdHJ1ZTsKIAogICAgICAgLy8gSGFuZGxlIGtleSBwcmVz cyBldmVudHMgZm9yIENhbmNlbCwgc2F2ZSBhbmQgaGVscCBidXR0b24KICAgICAgIHZhciBoYW5k bGVLZXlEb3duID0gZnVuY3Rpb24oZXZlbnQsIGNvbnRleHQpIHsKQEAgLTEwNDIsNyArMTA0Myw3 IEBAIGRlZmluZSgncGdhZG1pbi5icm93c2VyLm5vZGUnLCBbCiAKICAgICAgICAgc3dpdGNoIChl dmVudC53aGljaCkgewogICAgICAgICBjYXNlIGtleUNvZGUuRVNDQVBFOgotICAgICAgICAgIGNs b3NlUGFuZWwoKTsKKyAgICAgICAgICBjbG9zZVBhbmVsKHRydWUpOwogICAgICAgICAgIGJyZWFr OwogICAgICAgICBjYXNlIGtleUNvZGUuRU5URVI6CiAgICAgICAgICAgLy8gUmV0dXJuIGlmIGV2 ZW50IGlzIGZpcmVkIGZyb20gY2hpbGQgZWxlbWVudApAQCAtMTQwMCw3ICsxNDAxLDcgQEAgZGVm aW5lKCdwZ2FkbWluLmJyb3dzZXIubm9kZScsIFsKICAgICAgICAgICAgICAgICBidG4ub24oJ2Ns aWNrJywoKSA9PiB7CiAgICAgICAgICAgICAgICAgICAvLyBSZW1vdmluZyB0aGUgYWN0aW9uLW1v ZGUKICAgICAgICAgICAgICAgICAgIHBhbmVsLiRjb250YWluZXIucmVtb3ZlQXR0cignYWN0aW9u LW1vZGUnKTsKLSAgICAgICAgICAgICAgICAgIG9uQ2FuY2VsRnVuYy5jYWxsKGFyZ3VtZW50cyk7 CisgICAgICAgICAgICAgICAgICBvbkNhbmNlbEZ1bmMuY2FsbCh0cnVlKTsKICAgICAgICAgICAg ICAgICB9KTsKICAgICAgICAgICAgICAgfSwKICAgICAgICAgICAgIH0sIHsKQEAgLTE0NTUsNyAr MTQ1NiwxMCBAQCBkZWZpbmUoJ3BnYWRtaW4uYnJvd3Nlci5ub2RlJywgWwogICAgICAgICAgIC8v IFNob3cgY29udGVudHMgYmVmb3JlIGJ1dHRvbnMKICAgICAgICAgICBqLnByZXBlbmQoY29udGVu dCk7CiAgICAgICAgIH0uYmluZChwYW5lbCksCi0gICAgICAgIGNsb3NlUGFuZWwgPSBmdW5jdGlv bigpIHsKKyAgICAgICAgY2xvc2VQYW5lbCA9IGZ1bmN0aW9uKGNvbmZpcm1fY2xvc2VfZmxhZykg eworICAgICAgICAgIGlmKCFfLmlzVW5kZWZpbmVkKGNvbmZpcm1fY2xvc2VfZmxhZykpIHsKKyAg ICAgICAgICAgIGNvbmZpcm1fY2xvc2UgPSBjb25maXJtX2Nsb3NlX2ZsYWc7CisgICAgICAgICAg fQogICAgICAgICAgIC8vIENsb3NpbmcgdGhpcyBwYW5lbAogICAgICAgICAgIHRoaXMuY2xvc2Uo KTsKICAgICAgICAgfS5iaW5kKHBhbmVsKSwKQEAgLTE0ODQsNyArMTQ4OCw3IEBAIGRlZmluZSgn cGdhZG1pbi5icm93c2VyLm5vZGUnLCBbCiAgICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICB9 CiAgICAgICAgICAgKTsKLSAgICAgICAgICBjbG9zZVBhbmVsKCk7CisgICAgICAgICAgY2xvc2VQ YW5lbChmYWxzZSk7CiAgICAgICAgIH0sCiAgICAgICAgIHNhdmVOZXdOb2RlID0gZnVuY3Rpb24o dGhhdCkgewogICAgICAgICAgIHZhciBwYW5lbCA9IHRoaXMsCkBAIC0xNTAzLDcgKzE1MDcsNyBA QCBkZWZpbmUoJ3BnYWRtaW4uYnJvd3Nlci5ub2RlJywgWwogICAgICAgICAgIH0gY2F0Y2ggKGUp IHsKICAgICAgICAgICAgIGNvbnNvbGUud2FybihlLnN0YWNrIHx8IGUpOwogICAgICAgICAgIH0K LSAgICAgICAgICBjbG9zZVBhbmVsKCk7CisgICAgICAgICAgY2xvc2VQYW5lbChmYWxzZSk7CiAg ICAgICAgIH0uYmluZChwYW5lbCwgdGhhdCksCiAgICAgICAgIGVkaXRJbk5ld1BhbmVsID0gZnVu Y3Rpb24oKSB7CiAgICAgICAgICAgLy8gT3BlbiBlZGl0IGluIHNlcGFyYXRlIHBhbmVsCkBAIC0x NTQxLDcgKzE1NDUsNyBAQCBkZWZpbmUoJ3BnYWRtaW4uYnJvd3Nlci5ub2RlJywgWwogICAgICAg ICAgICAgc2VsZiA9IHRoaXM7CiAKICAgICAgICAgICBsZXQgY29uZmlybV9vbl9wcm9wZXJ0aWVz X2Nsb3NlID0gcGdCcm93c2VyLmdldF9wcmVmZXJlbmNlc19mb3JfbW9kdWxlKCdicm93c2VyJyku Y29uZmlybV9vbl9wcm9wZXJ0aWVzX2Nsb3NlOwotICAgICAgICAgIGlmICh2aWV3ICYmIHZpZXcu bW9kZWwgJiYgY29uZmlybV9vbl9wcm9wZXJ0aWVzX2Nsb3NlKSB7CisgICAgICAgICAgaWYgKGNv bmZpcm1fb25fcHJvcGVydGllc19jbG9zZSAmJiBjb25maXJtX2Nsb3NlICYmIHZpZXcgJiYgdmll dy5tb2RlbCkgewogICAgICAgICAgICAgaWYodmlldy5tb2RlbC5zZXNzQ2hhbmdlZCgpKXsKICAg ICAgICAgICAgICAgQWxlcnRpZnkuY29uZmlybSgKICAgICAgICAgICAgICAgICBnZXR0ZXh0KCdX YXJuaW5nJyksCg== --000000000000f0ced80596195414--