Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp89h-0006Zd-U3 for pgadmin-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 08:57:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gp89e-0005Fb-7b for pgadmin-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 08:57:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp89d-0005FT-T2 for pgadmin-hackers@lists.postgresql.org; Thu, 31 Jan 2019 08:57:02 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp89a-00012w-1p for pgadmin-hackers@postgresql.org; Thu, 31 Jan 2019 08:57:01 +0000 Received: by mail-lj1-x243.google.com with SMTP id t18-v6so1989676ljd.4 for ; Thu, 31 Jan 2019 00:56:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FF0db/AmqtRTB0MBtk+QIKVzcCLVbP8LhzCr7WyHajA=; b=BP9eL1/NvTw0uQa8/iizyoxaV9RIGmDxRE8CxZaKYuz17iDpEHBPOmRCBJdETf3x1f xJQ60u52vUjscu1M4t+8Gu0SURrFNh/lPXvVixfNuVIFpKG0RK7J26LPq+iNXiweOqJw LwdbtVRE5L9ReVe5NU595prISgRrfesw1viU+HmmZX4huwSMoB4qB/Esi59JzqlU1Fpi uDTWRC8yWH96QAMRRljU6NV4YCCnGl3VcUDwAgMpvPu+F4j4UpKItEmN8FOeKFbXQcL+ fwtm54b6Mjql8BM3DGiiumCPces/nvqtiPNULJ1gpMaFnIUIkRnrC/MoVysywtsm7bpG AMnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FF0db/AmqtRTB0MBtk+QIKVzcCLVbP8LhzCr7WyHajA=; b=X2NiZxdMRmLZf29Uq7uKxYXKCoIKSAHQI9kabZmArI9oc67cyywHGwK9DmXkkpWcko ygZZLazNvuM9tLe6FZQIGNWOP7NY17Ku6fSAhDWFWbu/02rHsnjoKonZ7aiVy90J6wu5 5wlUxJ+xQt1v2f8zf+3Y4LYx5pFj8nkY/OBqEjZ049ohfb765VOrPnKwvctH/R/Pmhy7 BQAG5MRnL40OvyqjWsFaGEf1whUGF8bSz1WI3/je5bjpk73/cpjDI6bM1/3zamE+ly/X zLcZT96+xHd5ZsYwuJcnz8mm9lIg/WrLRqt17zIC1Navq43jElglTEzz688gbYFdqUCt G/4g== X-Gm-Message-State: AHQUAub4/YxotynMSe3vWgO5nwP+9vWxwKq0fFwRDiwBv6Kdq08DYC5T py9ArUmsnr3kwnUi87mljltsWybQtViyiisDqFY+Mg== X-Google-Smtp-Source: AHgI3IZpszRQDj705qiU8mSpcO8CArVoLgbb0IAhPWesTXBedN4Ox/3JuUPjDV5pEZwiWsNqlHGMnOs6n/L8cgoCxS8= X-Received: by 2002:a2e:3a10:: with SMTP id h16-v6mr22909720lja.184.1548925016743; Thu, 31 Jan 2019 00:56:56 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Thu, 31 Jan 2019 14:26:44 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables To: Khushboo Vashi Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000068475a0580bd353c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000068475a0580bd353c Content-Type: text/plain; charset="UTF-8" Hi Khushboo, The patch looks good to me and statistics works great now. Tested with 2000 tables. However, I did not get what did the below change do. *diff --git a/web/pgadmin/misc/statistics/static/js/statistics.js b/web/pgadmin/misc/statistics/static/js/statistics.js* *index cfd573e1..5441f883 100644* *--- a/web/pgadmin/misc/statistics/static/js/statistics.js* *+++ b/web/pgadmin/misc/statistics/static/js/statistics.js* @@ -104,7 +104,9 @@ define('misc.statistics', [ offText: gettext('False'), onColor: 'success', offColor: 'primary', - size: 'mini', + size: 'small', + width: null, + height: null, } ); @Committer, Except above change, all looks good to me. On Tue, Jan 29, 2019 at 3:17 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > I have also improved the performance of the properties tab. > Please also apply the bootstrap toggle patch to check the properties tab > performance. > > Thanks, > Khushboo > > On Tue, Jan 22, 2019 at 5:05 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Khushboo, >> >> There is improvement than before but the UI still lags. I tested with >> 2000 tables and statistics on Tables node. >> I would also suggest to add further rows only if scrolling down. Rows >> adding can be avoided even if the scroll does not take to the last element. >> Currently, if I scroll slightly down it add rows and if I scroll back up >> it adds more. I think the scroll up fetch can be avoided. >> >> On Mon, Jan 21, 2019 at 4:43 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> Can you please review it. >>> >>> On Thu, Jan 17, 2019 at 11:36 AM Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Please find the attached patch to fix the RM 3664 - Statistic panel >>>> hangs when 1000+ tables >>>> >>>> The statistics tab hangs with more rows. So, now the rows will be >>>> pushed in the backgrid collection in bunches on scroll event to fix this >>>> issue. >>>> >>>> Thanks, >>>> Khushboo >>>> >>> >>> >>> -- >>> *Akshay Joshi* >>> >>> *Sr. Software Architect * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --00000000000068475a0580bd353c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Khushboo,

The patch looks=C2=A0good to me and statistic= s works great now. Tested with 2000 tables.
However, I did not get what did= the below change do.

diff --git a/web/pgadmin/misc/st= atistics/static/js/statistics.js b/web/pgadmin/misc/statistics/static/js/st= atistics.js

index cfd573e1..5441f883 100644<= /p>

--- a/web/pgadmin/misc/statistics/static/js= /statistics.js

+++ b/web/pgadmin/misc/statistics/static/js= /statistics.js

@@ -104,7 +104,9 @@ define('misc.statistics', [

= =C2=A0=C2=A0 =C2=A0 =C2=A0 offText: gettext('False'),=

= =C2=A0=C2=A0 =C2=A0 =C2=A0 onColor: 'success',

= =C2=A0=C2=A0 =C2=A0 =C2=A0 offColor: 'primary',

-=C2=A0 =C2=A0 =C2=A0 size: 'mini',

+=C2=A0 =C2=A0 =C2=A0 size: 'small',

+=C2=A0 =C2=A0 =C2=A0 width: null,

+=C2=A0 =C2=A0 =C2=A0 height: null,

= =C2=A0=C2=A0 =C2=A0 }

=C2=A0=C2=A0 );


=


@Committer,

Except above change, all looks good to me.



On Tue, Jan 2= 9, 2019 at 3:17 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached updated patch.
I ha= ve also improved the performance of the properties tab.
Please al= so apply the bootstrap toggle patch to check the properties tab performance= .=C2=A0

Thanks,
Khushboo

On Tue, Jan 22, = 2019 at 5:05 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> = wrote:
Hi Khushboo,

There is improvement than before but the UI still = lags. I tested with 2000 tables and statistics on Tables node.
I would also suggest to add further = rows only if scrolling down. Rows adding can be avoided even if the scroll = does not take to the last element.
Currently, if I scroll slightly down it add rows and if I scroll= back up it adds more. I think the scroll up fetch can be avoided.

On Mon, Jan 21, 2019 at = 4:43 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya=C2= =A0

Can you please review it.

On Thu, Jan 1= 7, 2019 at 11:36 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wr= ote:
Hi,

Please find the attached patch to fix the RM 3= 664 - Statistic panel hangs when 1000+ tables

The = statistics tab hangs with more rows. So, now the rows will be pushed in the= backgrid collection in bunches on scroll event to fix this issue.

Thanks,
Khushboo


--
Akshay Joshi


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246<= /span>


--
Thanks and Regards,
Aditya Toshniwal
=
Software Engineer |=C2=A0E= nterpriseDB Software Solutions |=C2=A0P= une
"Don't Complai= n about Heat, Plant a tree"


--
Thanks and Rega= rds,
Aditya Toshniwa= l
Softw= are Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
&q= uot;Don't Complain about Heat, Plant a tree"
--00000000000068475a0580bd353c--