Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8y5S-0007YH-Nt for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Feb 2021 04:23:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l8y5R-0000yX-9L for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Feb 2021 04:23:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8y5R-0000yQ-2h for pgadmin-hackers@lists.postgresql.org; Mon, 08 Feb 2021 04:23:45 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l8y5O-0000AY-CY for pgadmin-hackers@postgresql.org; Mon, 08 Feb 2021 04:23:44 +0000 Received: by mail-lf1-x130.google.com with SMTP id w36so6699870lfu.4 for ; Sun, 07 Feb 2021 20:23:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=53Qme1PgacpSxoHfzJrky25msJqV37UKNLWbOdtYVg4=; b=KNuC57lnLGSFM3+Yv7lph0ei91bSNJ0Qq7ZhOh9WRQK8E/RGEytZPXovwoGENprvSY h2zKiIG4eJotvKUaKV2cS3bXLbv6y6y0qCVppj7O/47W22M3/ONLl5a59Mp+mCAYUFuW ZAYy4DbAV+wWVPjZLKr07mUFAf+dMi3WwxSledt6bDZyuYu3rjdufNYonKWvoCAaZ3XQ FfCfubtSaabvy8a7NsP79IeJkSDtnV9K2SfVcbAfM+2ySmaWWV7jQh5lNq88hEzLums/ /L5yrPQWrzCcOhRaMxGRmDc62/vY2PXnIwmIRaGv/wWE2XOdxyK2a2QpBcqnBQkvrYC8 DRRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=53Qme1PgacpSxoHfzJrky25msJqV37UKNLWbOdtYVg4=; b=U7qG7qUoeOOyetiHt7I3qjgvB0ApW5Nkc4up2jbt25llMl8kx4UsD+nIokkj2kRuM6 dTnDq4nascDY6TLZlJBMKxnpuzaZWNhASumiOS/JD4XyRNwWJXkmq0A/wmQW7+ACZivR hG909slso+s0MYWpVAUG+KmG34NkTKZ0aAr6kXpwFWaVsZAGtU5S1ARfkqjQMwZZzFaL tQ1ODGwHfkZCAuQ9jkclYWyU1MqX3mjDZdHWc/Wsx+Ekr2zPLEYyyx4SXe5RTdJAQIUr 2fAuX/jG6VOfpUc+2JlwT/NM+Pqz8R2B1yaNT18ZLciox1SePUPKhDkogBN8yCgzIhgE WfnQ== X-Gm-Message-State: AOAM5314JwMhKHt7rHFV8KrzrcmU5/WfygIV6aPcLxKXGVTzyVb4D4Zo LyYLiULBudRES+zC9YTUVXz3eclllo+sKpHqtx72HR0e+zZOYzyG+TEUCGKijIimbRPyBpcdOho QGGfuTS8Rquu8yoI1NYo7k6BcvitMbr3SvThcEdeFKZvKmGqqeuJqZWSmUqA1zlQgpxMPC4/KNq j+igMakIJ4CyfnmPg8Dkv8PYa7d43pj06VhGQ82p//7TtMws0g/32SHiThuQ== X-Google-Smtp-Source: ABdhPJzvQFUQpVN+xbf8Wah3HTYVekUg3R8vbXURYE+KbuuHWBm5gP/29BMb1RXByuiUbtxu9eqBR9cibQUWR7/fWfo= X-Received: by 2002:ac2:53a3:: with SMTP id j3mr8935001lfh.438.1612758221325; Sun, 07 Feb 2021 20:23:41 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Mon, 8 Feb 2021 09:53:05 +0530 Message-ID: Subject: Re: [pgAdmin] RM6117 Unable to update column level privileges from security tab. To: Rahul Shirsat Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e422e005bacb88cf" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e422e005bacb88cf Content-Type: text/plain; charset="UTF-8" Hi Rahul, On Sat, Feb 6, 2021 at 1:25 AM Rahul Shirsat wrote: > Hi Hackers, > > Please find the attached patch which resolves the issue of unable to > update column level privileges in the security tab. > > Additionally, when the user tries to change grantee, the sql wasn't > generating, this too issue is resolved. > > This security privilege issue is resolved for the following nodes: > > 1.) Tables (test cases are skipped as there are no resql test cases based > on pg & ppas) > 2.) Columns > 3.) Views > 4.) MViews > 5.) Types > 6.) Functions > 7.) Procedures > 8.) Trigger functions > 9.) Sequences > 10.) Schema > > P.S for committer : Warning of whitespaces after applying patch should be > ignored as it is a part of resql test case results. > Probably change the SQL generation logic to avoid the trailing whitespaces ? > > -- > *Rahul Shirsat* > Senior Software Engineer | EnterpriseDB Corporation. > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --000000000000e422e005bacb88cf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Rahul,

On Sat, Feb 6, 2021 at 1:25 AM = Rahul Shirsat <rahul.s= hirsat@enterprisedb.com> wrote:
Hi Hackers,

Plea= se=C2=A0find the attached patch which resolves the=C2=A0issue of unable to = update column level privileges=C2=A0in the security tab.

Additionally, when the user tries to change grantee, the sql wasn= 9;t generating, this too issue is resolved.

This s= ecurity privilege issue is resolved for the following nodes:

=
1.) Tables (test cases are skipped as there are no resql test ca= ses based on pg & ppas)
2.) Columns
3.) Views =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
4.) MViews =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0
5.) Types =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0
6.) Functions =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
7.) Proced= ures =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
8.) Trigger functions
9.) Seq= uences
10.) Schema

P.S for committer : Warn= ing of whitespaces after applying patch should be ignored as it is a part o= f resql test case results.
Probably change the SQL= generation logic to avoid the trailing whitespaces ?=C2=A0
=

--
=
Rahul Shirsat
Senior Software Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corpor= ation.


--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Softwa= re Engineer | edbpostgres.com<= /font>
"Don't Complain about Heat, Plant a TREE&qu= ot;
--000000000000e422e005bacb88cf--