public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Azad Salahlı <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin] Fix incorrect import in setup.py
Date: Mon, 28 Sep 2020 16:48:17 +0530
Message-ID: <CAM9w-_mSZoJRJHu3_3uQ2A_OG0w_ft3SAQb6SViFP+koUrwiQA@mail.gmail.com> (raw)
In-Reply-To: <CA+xqhcXzr-iSA5SDsKN5MbgC6i+AM-hRb5Pt+QjSaS20cRgEZg@mail.gmail.com>
References: <CA+xqhcXzr-iSA5SDsKN5MbgC6i+AM-hRb5Pt+QjSaS20cRgEZg@mail.gmail.com>
Hi Azad,
The patch looks good to me.
On Thu, Sep 24, 2020 at 6:33 PM Azad Salahlı <[email protected]> wrote:
> Hi,
>
> First time posting here. I've attached a fix for an incorrect import
> in `setup.py`. Trying to import from `pgadmin` before adding the root
> directory to the system path results in import error, when the script
> is invoked in any other way than running it directly. For example
>
> $ /path/to/venv/bin/pip install pgadmin4
> $ /path/to/venv/bin/python -m pgadmin4.setup
> Traceback (most recent call last):
> ...
> File "/path/to/venv/lib/python3.6/site-packages/pgadmin4/setup.py",
> line 18, in <module>
> from pgadmin.model import db, User, Version, ServerGroup, Server, \
> ModuleNotFoundError: No module named 'pgadmin'
>
> Please let me know what you think. Happy to address any feedback.
>
> Regards,
> Azad Salahlı
>
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin] Fix incorrect import in setup.py
In-Reply-To: <CAM9w-_mSZoJRJHu3_3uQ2A_OG0w_ft3SAQb6SViFP+koUrwiQA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox