public inbox for [email protected]  

help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM3988] Cursor disappears in Query Editor
Date: Mon, 6 Apr 2020 17:59:00 +0530
Message-ID: <CAM9w-_mWnAO+4mU=gA-Fr4kMSW6b+M+gjw4-XOXmVrzRiSnYBg@mail.gmail.com> (raw)

Hi Hackers,

Attached is a small patch to fix a cursor issue in the query editor.
The cursor disappears for some of the characters when zoomed out.

Please review.

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [application/octet-stream] RM3988.patch (574B, 3-RM3988.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/scss/_codemirror.overrides.scss b/web/pgadmin/static/scss/_codemirror.overrides.scss
index ed2541a7c..24528d166 100644
--- a/web/pgadmin/static/scss/_codemirror.overrides.scss
+++ b/web/pgadmin/static/scss/_codemirror.overrides.scss
@@ -63,8 +63,10 @@
   & .cm-hr {color: $color-editor-fg;}
   & .cm-link {color: $color-editor-fg;}
 
-  & .CodeMirror-cursor {
-    border-color: $color-editor-fg;
+  & :not(.cm-fat-cursor) .CodeMirror-cursor {
+    border-left: thin solid $color-editor-fg;;
+    border-right: none;
+    width: 0;
   }
 }
 

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin][RM3988] Cursor disappears in Query Editor
  In-Reply-To: <CAM9w-_mWnAO+4mU=gA-Fr4kMSW6b+M+gjw4-XOXmVrzRiSnYBg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox