Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gludY-0004OU-0a for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 11:54:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gludW-0004jp-Iy for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 11:54:34 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gludW-0004jg-AA for pgadmin-hackers@lists.postgresql.org; Tue, 22 Jan 2019 11:54:34 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gludS-0003v9-P0 for pgadmin-hackers@postgresql.org; Tue, 22 Jan 2019 11:54:32 +0000 Received: by mail-lj1-x244.google.com with SMTP id g11-v6so20346998ljk.3 for ; Tue, 22 Jan 2019 03:54:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ovrrV1Apps9VmswH42PFSq2JLJVsGHnEsWOFV1Wi7K4=; b=vE3Bd8tVr2sI8TwEnxHutkk6G+F2ay36H6nx+g3cpqUqSkX60021g2k8uSBtZyB13k NT015xlbLYgx9VCaly/KSWpgemXdK3Pxv/uSwe1qiOy2N9DhCwoSyWyz+H7K3nMLvuSj 26ffUJFDIxrIRnjSgrIjDzRnDOvBFnWZXCPOpYTNkJIcTYELwtTy8mQlog+ixYaE7hxB sZtrqFqP1om/GBRDHpytFJyK4zown0EP5dG6y9DAo6R0RRdLR1j7II0lEiAuh75wSZkn t1WGIFHyiPW+Xs8sNMlZJF7mR5Vs42BihyNWw3wgWyQ08x0K+PLM+Wn+Fw39kCLuh7Pt u+lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ovrrV1Apps9VmswH42PFSq2JLJVsGHnEsWOFV1Wi7K4=; b=Y++vuvgpEKLBDfd5PbKWl5aj7N932aRlxN9+jVHxZmGzvEt+d7FO2vvnyfGRcVtNas RfrvXnMVs9mFveWjZuIfdAsBxCc03UFVWj8s11W/cE3gukYYY8Sz9ZsITSY7/oKqc2J0 njM4LO5CByDnSdMiqalx7ecW/jkML6lIMAzNkP8Z3C8AWat3PPgfNYB1zHl9clVpSFeK o8qKYlG1EAEwlkv/vJTHi2rQmK11u9YEUCDUgDIheu6TmcD9HSOskVWYj5gbASrTChOh qo9bjP+O+YvofqaQVSIeZ8A1Dj/CCDG/COHZyh6XF8rdJRCln3Fz/VVCdi8gLGJkUfUF WSPA== X-Gm-Message-State: AJcUukegBL29SkbUh4EvMzSbCttmNaoP//Dw3MYOJMTTlnB4Wq0jHndX vBl3np7MuB/sFM6mXnaXrfk/3CjyAn7RwumjsShp8w== X-Google-Smtp-Source: ALg8bN6Af56vvRBLiRFNSJMA9htROLghHX6jrmo/dN9kKHwGNmORS5ZWcLDn8hwAC4MnR8Frcsi1U0sBWFrv/scNJ+4= X-Received: by 2002:a2e:81d3:: with SMTP id s19-v6mr17509566ljg.138.1548158068882; Tue, 22 Jan 2019 03:54:28 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Tue, 22 Jan 2019 17:24:18 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c0975905800aa353" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c0975905800aa353 Content-Type: text/plain; charset="UTF-8" Any suggestions on preferences name/desc ? On Tue, Jan 22, 2019 at 3:01 PM Dave Page wrote: > Hi > > On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi > wrote: > > > > Hi Aditya > > > > Below are my review comments: > > > > You have added new config parameter "DISABLE_BEFOREUNLOAD_MESSAGE" to > make this request configurable, should it be the part of preferences > setting instead of configuration? @Dave can you please comment on this. > > That does seem like something that should be a per-user preference, > not a global config option. > > > Name "DISABLE_BEFOREUNLOAD_MESSAGE" is not clear as users perspective, > can you please change it to some meaningful name. > > > > Apart from that code looks good to me. > > > > On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> > >> Hi Hackers, > >> > >> Attached is the patch to throw alert warning when user reloads or > closes the browser. > >> > >> Kindly review. > >> > >> -- > >> Thanks and Regards, > >> Aditya Toshniwal > >> Software Engineer | EnterpriseDB Software Solutions | Pune > >> "Don't Complain about Heat, Plant a tree" > > > > > > > > -- > > Akshay Joshi > > Sr. Software Architect > > > > > > Phone: +91 20-3058-9517 > > Mobile: +91 976-788-8246 > > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --000000000000c0975905800aa353 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Any suggestions on preferences name/desc ?

On Tue, Jan 22,= 2019 at 3:01 PM Dave Page <dave.page@enterprisedb.com> wrote:
Hi

On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi
<aksh= ay.joshi@enterprisedb.com> wrote:
>
> Hi Aditya
>
> Below are my review comments:
>
> You have added new config parameter "DISABLE_BEFOREUNLOAD_MESSAGE= " to make this request configurable, should it be the part of preferen= ces setting instead of configuration? @Dave can you please comment on this.=

That does seem like something that should be a per-user preference,
not a global config option.

> Name "DISABLE_BEFOREUNLOAD_MESSAGE" is not clear as users pe= rspective, can you please change it to some meaningful name.
>
> Apart from that code looks good to me.
>
> On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal <aditya.toshniwal@ente= rprisedb.com> wrote:
>>
>> Hi Hackers,
>>
>> Attached is the patch to throw alert warning when user reloads or = closes the browser.
>>
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>
>
>
> --
> Akshay Joshi
> Sr. Software Architect
>
>
> Phone: +91 20-3058-9517
> Mobile: +91 976-788-8246



--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


--
Thanks and Rega= rds,
Aditya Toshniwa= l
Softw= are Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
&q= uot;Don't Complain about Heat, Plant a tree"
--000000000000c0975905800aa353--