Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Olq-0007cB-Qc for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Feb 2021 08:53:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l9Olp-0005dB-Pi for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Feb 2021 08:53:17 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Olp-0005d3-Ax for pgadmin-hackers@lists.postgresql.org; Tue, 09 Feb 2021 08:53:17 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l9Olm-0003ch-7i for pgadmin-hackers@postgresql.org; Tue, 09 Feb 2021 08:53:16 +0000 Received: by mail-lj1-x22a.google.com with SMTP id q14so11590370ljp.4 for ; Tue, 09 Feb 2021 00:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jJNDq4N//R/kEYsmZguzUxBcbGqcIlwDUQsnjUdvlFc=; b=WtQCnZIhz4ewTVIXabJYO3K2p+gs6t1AcevwcUXOVwdPAqarRe6oYxJfVI5PqWf4f6 XygukuyE4pcqsCi3kEwatBV7evaGkRpt3+u/5Jj5x/4Ddh4D/oMyo3oqu761E/OIme3S tlsoKXSSZri648RuVxtQOB1XhT5J/pvHuMmsTID2Vr/KGiNAu1SX1JQbMBSQ9uGH3YJL kHMqOkBht7EbQcbGhaQ0aAlEmTTWi8SmLCgjbjYpgGpkxMzKB72J6M4j4WN23JyrTbQ3 NmuW11xxprRzSjDoKJhuBLnCR4L2sh6oN54qUba2Gj3kOfB0WCA0wt2ZRz7Ewp5ezRGV g43w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jJNDq4N//R/kEYsmZguzUxBcbGqcIlwDUQsnjUdvlFc=; b=f1s4niBRVNMHZyhXojO4ChJNnpZf/ja7pacG5QGWgXnNbVD0E+fk/Ml5ve/vx8TJ2T QmeLWtjjHPF1ArXcz97YhmVZ+v2GRbvxlihi/tZPrT8VxFa4ek4OEo8wEiwPytsXmvek GHUeeqx0qKfXWoBMP2TNX6RQn5Qp6RJuoKrWSHzlZ4SaAUpcwfkFEe8dowD9sQSd6LSm wNDCFPphblmt/F+faHB0zkGMm1yN9yj1SmysCdnsD9tLizMp3zqpf8PQcScRmOno6TYe HE6+xe2XrpfCAN20Fzo4zSiE8edkNDFhiitSfsdcTd8cLVb9lXFh8n6nQry3gCk5FWUG soRA== X-Gm-Message-State: AOAM53300CbWwReiM4zADJ+cxUe6GPvGpmX124pNjLjF5mCdsmY6Vk1c GQzZWDbCX0VoERx0gAtX1h+1hQrZt/8RdEi/0S1+8C0DTxIDIhZHMpJo4Qhnasm3HXa/NkMvkFC 1rJ4lJ7bf5rJGFcdQcN64eRZLvG/M03thBetfHwkt18rbV2ZkIb47tZGX+G0Brh6TpE4ZWkWvjU hg1tULA499GVErkdTpbIV+oBjysea+/cBtwbvattzmG2WBmk5dI5I7qWpMug== X-Google-Smtp-Source: ABdhPJy+s5Coi4EATSndVzu9YpLvVDy1f3XOGiKFaDe++XXyUXao8XS24ABAFL7+CgSKtJXMLr3geZDAu4LlAprLSQU= X-Received: by 2002:a2e:9c8e:: with SMTP id x14mr12174536lji.83.1612860792039; Tue, 09 Feb 2021 00:53:12 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Tue, 9 Feb 2021 14:22:35 +0530 Message-ID: Subject: Re: [pgAdmin][RM5091] Option to hide Statistics, Dependencies, Dependants tab To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000009510ed05bae36af3" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009510ed05bae36af3 Content-Type: text/plain; charset="UTF-8" Hello Akshay, The previous patch will fix the dashboard issue also. On Tue, Feb 9, 2021 at 12:41 PM Akshay Joshi wrote: > Hi Aditya > > Please fix the issue for Dashboard API calls as well and send the patch > again. > > On Mon, Feb 8, 2021 at 5:39 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi, >> >> The changes for not calling the ajax until the panel is focused were >> missed in the last patch. Please review the attached. >> >> On Wed, Feb 3, 2021 at 1:00 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Tue, Feb 2, 2021 at 5:44 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached patch will allow closing Statistics, Dependencies, Dependants >>>> tabs. The tabs can be added back by right clicking on the tab strip and >>>> selecting "Add panel", similar to that of Dashboard. >>>> Changes are also made to make sure statistics, dependencies, dependants >>>> are fetched only when they're visible, to avoid unnecessary ajax calls. >>>> >>>> Please review. >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>> >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --0000000000009510ed05bae36af3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Akshay,

The previous patch will fix the dashboard is= sue also.

On Tue, Feb 9, 2021 at 12:41 PM Akshay Joshi <akshay.joshi@enterprisedb.com>= ; wrote:
Hi=C2=A0Aditya

Please fix the issue for = Dashboard API calls as well and send the patch again.

On Mon, Feb 8, 2021 = at 5:39 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote= :
Hi= ,

The changes for not calling the ajax until the panel is focused were= missed in the last patch. Please review the attached.

On Wed, Feb 3, = 2021 at 1:00 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Than= ks, patch applied.

On Tue, Feb 2, 2021 at 5:44 PM Aditya Toshniwal <<= a href=3D"mailto:aditya.toshniwal@enterprisedb.com" target=3D"_blank">adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch wil= l allow closing=C2=A0Statistics, Dependencies, Dependants tabs. The tabs ca= n be added back=C2=A0by right clicking on the tab strip and selecting "= ;Add panel", similar to that of Dashboard.
Changes are also made to make sure statistics, dependencies, d= ependants are fetched only when they're visible, to avoid unnecessary ajax = calls.
=
Please rev= iew.
--
Thanks,
Aditya Toshniwal
pgAdmin hacker= =C2=A0| Sr. Software Engineer | edbpost= gres.com
"Don't Complain about Heat, Plan= t a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Softwa= re Engineer | edbpostgres.com<= /font>
"Don't Complain about Heat, Plant a TREE&qu= ot;
--0000000000009510ed05bae36af3--