MIME-Version: 1.0
References: 
 <CAM9w-_kMKPOGs47ph7ZmWAehgZy-AZdcRJOD_kK0J2oZRfKavw@mail.gmail.com>
 <CANxoLDcodBdSmA4nC57oajyp=zXf1g3eBNn30anQiXSpxAduew@mail.gmail.com>
In-Reply-To: 
 <CANxoLDcodBdSmA4nC57oajyp=zXf1g3eBNn30anQiXSpxAduew@mail.gmail.com>
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Fri, 5 Jun 2020 17:01:44 +0530
Message-ID: 
 <CAM9w-_matuqv+4ya=ZuK0dugg+zMpp=AGceCij+baHbUJcJMLg@mail.gmail.com>
Subject: Re: [pgAdmin][RM5197] Accessibility issues of external packages
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000004627ed05a7549d01"
Precedence: bulk

--0000000000004627ed05a7549d01
Content-Type: multipart/alternative; boundary="0000000000004627e905a7549dff"

--0000000000004627e905a7549dff
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

Attached is the patch to update Codemirror version to latest which allows
us to set screen reader labels on Codemirror editor. This is part of #5197.
Please review.

On Fri, Apr 3, 2020 at 5:14 PM Akshay Joshi <akshay.joshi@enterprisedb.com>
wrote:

> Thanks, patch applied.
>
> On Thu, Apr 2, 2020 at 4:46 PM Aditya Toshniwal <
> aditya.toshniwal@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached patch will replace the existing color picker -
>> spectrum-colorpicker with @simonwep/pickr.
>> spectrum-colorpicker has accessibility issues and is not maintained since
>> long. @simonwep/pickr is actively maintained and the package is improving
>> its accessibility actively.
>>
>> Please review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

--0000000000004627e905a7549dff
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">Hi Hackers,</div><div class=3D"gmail_default" style=3D"font-fam=
ily:verdana,sans-serif"><br></div><div class=3D"gmail_default" style=3D""><=
font face=3D"verdana, sans-serif">Attached is the patch to update Codemirro=
r version to latest which allows us to set screen reader labels on Codemirr=
or=C2=A0editor. This is part of #5197.</font></div><div class=3D"gmail_defa=
ult" style=3D""><font face=3D"verdana, sans-serif">Please review.</font></d=
iv></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_att=
r">On Fri, Apr 3, 2020 at 5:14 PM Akshay Joshi &lt;<a href=3D"mailto:akshay=
.joshi@enterprisedb.com">akshay.joshi@enterprisedb.com</a>&gt; wrote:<br></=
div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor=
der-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Than=
ks, patch applied.</div><br><div class=3D"gmail_quote"><div dir=3D"ltr" cla=
ss=3D"gmail_attr">On Thu, Apr 2, 2020 at 4:46 PM Aditya Toshniwal &lt;<a hr=
ef=3D"mailto:aditya.toshniwal@enterprisedb.com" target=3D"_blank">aditya.to=
shniwal@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail=
_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204=
,204);padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_default" style=
=3D"font-family:verdana,sans-serif">Hi Hackers,</div><div class=3D"gmail_de=
fault" style=3D"font-family:verdana,sans-serif"><br></div><div class=3D"gma=
il_default" style=3D"font-family:verdana,sans-serif">Attached patch will re=
place the existing color picker - spectrum-colorpicker with=C2=A0@simonwep/=
pickr.</div><div class=3D"gmail_default" style=3D"font-family:verdana,sans-=
serif">spectrum-colorpicker has accessibility issues and is not maintained =
since long.=C2=A0@simonwep/pickr is actively maintained and the package is =
improving its accessibility actively.<br></div><div class=3D"gmail_default"=
 style=3D"font-family:verdana,sans-serif"><br></div><div class=3D"gmail_def=
ault" style=3D"font-family:verdana,sans-serif">Please review.</div><div><br=
></div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><div><div dir=3D"ltr"><div>=
<div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><font size=3D"=
2" color=3D"#000000" face=3D"verdana, sans-serif">Thanks and Regards,</font=
><div><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2" co=
lor=3D"#000000" face=3D"verdana, sans-serif">Aditya Toshniwal</font></span>=
</div><div><font face=3D"verdana, sans-serif"><span style=3D"background-col=
or:rgb(255,255,255)"><font size=3D"2" color=3D"#000000">pgAdmin Hacker | Sr=
. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0</font></span><span st=
yle=3D"color:rgb(0,0,0)">Pune</span></font></div><div><font color=3D"#38761=
d" face=3D"verdana, sans-serif" size=3D"1">&quot;Don&#39;t Complain about H=
eat, Plant a TREE&quot;</font></div></div></div></div></div></div></div></d=
iv></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"l=
tr"><div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span style=3D"color:r=
gb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-collapse:colla=
pse">Thanks &amp; Regards</span></b></font></div><div><font color=3D"#3333F=
F"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-siz=
e:13px;border-collapse:collapse">Akshay Joshi</span></b></font></div><div><=
font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial=
,sans-serif;font-size:13px;border-collapse:collapse">Sr. Software Architect=
<br></span></b></font></div><div><span style=3D"border-collapse:collapse"><=
font color=3D"#000000" face=3D"arial, sans-serif"><b>EnterpriseDB Software =
India Private Limited</b></font><br></span></div><div><b style=3D"color:rgb=
(51,51,255)"><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;f=
ont-size:13px;border-collapse:collapse">Mobile: +91 976-788-8246</span></b>=
<br></div></div></div></div></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div=
 dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><font size=3D"2" c=
olor=3D"#000000" face=3D"verdana, sans-serif">Thanks and Regards,</font><di=
v><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2" color=
=3D"#000000" face=3D"verdana, sans-serif">Aditya Toshniwal</font></span></d=
iv><div><font face=3D"verdana, sans-serif"><span style=3D"background-color:=
rgb(255,255,255)"><font size=3D"2" color=3D"#000000">pgAdmin Hacker | Sr. S=
oftware Engineer |=C2=A0EnterpriseDB India |=C2=A0</font></span><span style=
=3D"color:rgb(0,0,0)">Pune</span></font></div><div><font color=3D"#38761d" =
face=3D"verdana, sans-serif" size=3D"1">&quot;Don&#39;t Complain about Heat=
, Plant a TREE&quot;</font></div></div></div></div></div></div></div></div>=
</div></div></div>

--0000000000004627e905a7549dff--

--0000000000004627ed05a7549d01
Content-Type: application/octet-stream; name="RM5197.codemirror.patch"
Content-Disposition: attachment; filename="RM5197.codemirror.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_kb24ot5j0>
X-Attachment-Id: f_kb24ot5j0

ZGlmZiAtLWdpdCBhL3dlYi9wYWNrYWdlLmpzb24gYi93ZWIvcGFja2FnZS5qc29uCmluZGV4IDUw
ZmEyOGI3My4uNmUzMTZjNjcwIDEwMDY0NAotLS0gYS93ZWIvcGFja2FnZS5qc29uCisrKyBiL3dl
Yi9wYWNrYWdlLmpzb24KQEAgLTY3LDcgKzY3LDcgQEAKICAgICAiYm9vdHN0cmFwNC10b2dnbGUi
OiAiMy40LjAiLAogICAgICJib3dzZXIiOiAiMi4xLjIiLAogICAgICJicm93c2VyaWZ5IjogIn4x
Ni4yLjMiLAotICAgICJjb2RlbWlycm9yIjogIl41LjUwLjAiLAorICAgICJjb2RlbWlycm9yIjog
Il41LjU0LjAiLAogICAgICJjc3MtbG9hZGVyIjogIjIuMS4wIiwKICAgICAiY3NzbmFubyI6ICJe
NC4xLjEwIiwKICAgICAiZHJvcHpvbmUiOiAiXjUuNS4xIiwKZGlmZiAtLWdpdCBhL3dlYi9wZ2Fk
bWluL2Jyb3dzZXIvc3RhdGljL2pzL2Jyb3dzZXIuanMgYi93ZWIvcGdhZG1pbi9icm93c2VyL3N0
YXRpYy9qcy9icm93c2VyLmpzCmluZGV4IDJhOTYzOTZmZC4uOWM2OGFmMWU1IDEwMDY0NAotLS0g
YS93ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9icm93c2VyLmpzCisrKyBiL3dlYi9wZ2Fk
bWluL2Jyb3dzZXIvc3RhdGljL2pzL2Jyb3dzZXIuanMKQEAgLTQyOCw2ICs0MjgsNyBAQCBkZWZp
bmUoJ3BnYWRtaW4uYnJvd3NlcicsIFsKICAgICAgICAgICBtb2RlOiAndGV4dC94LXBnc3FsJywK
ICAgICAgICAgICByZWFkT25seTogdHJ1ZSwKICAgICAgICAgICBleHRyYUtleXM6IHBnQWRtaW4u
QnJvd3Nlci5lZGl0b3Jfc2hvcnRjdXRfa2V5cywKKyAgICAgICAgICBzY3JlZW5SZWFkZXJMYWJl
bDogZ2V0dGV4dCgnU1FMJyksCiAgICAgICAgIH0pOwogICAgICAgLyogQ2FjaGUgbWF5IHRha2Ug
dGltZSB0byBsb2FkIGZvciB0aGUgZmlyc3QgdGltZQogICAgICAgICogUmVmbGVjdCB0aGUgY2hh
bmdlcyBvbmNlIGNhY2hlIGlzIGF2YWlsYWJsZQpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vc3Rh
dGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMgYi93ZWIvcGdhZG1pbi9zdGF0aWMvanMvYmFja2Zv
cm0ucGdhZG1pbi5qcwppbmRleCBlODEzM2E5ZmYuLmQ3Y2IzYjcxMCAxMDA2NDQKLS0tIGEvd2Vi
L3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMKKysrIGIvd2ViL3BnYWRtaW4v
c3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMKQEAgLTE4MTAsMTIgKzE4MTAsMTUgQEAgZGVm
aW5lKFsKICAgICAgIC8vIFVzZSB0aGUgQmFja2Zvcm0gQ29udHJvbCdzIHJlbmRlciBmdW5jdGlv
bgogICAgICAgQmFja2Zvcm0uQ29udHJvbC5wcm90b3R5cGUucmVuZGVyLmFwcGx5KHRoaXMsIGFy
Z3VtZW50cyk7CiAKKyAgICAgIHZhciBmaWVsZCA9IF8uZGVmYXVsdHModGhpcy5maWVsZC50b0pT
T04oKSwgdGhpcy5kZWZhdWx0cyk7CisKICAgICAgIHRoaXMuc3FsQ3RybCA9IENvZGVNaXJyb3Iu
ZnJvbVRleHRBcmVhKAogICAgICAgICAodGhpcy4kZWwuZmluZCgndGV4dGFyZWEnKVswXSksIHsK
ICAgICAgICAgICBsaW5lTnVtYmVyczogdHJ1ZSwKICAgICAgICAgICBtb2RlOiAndGV4dC94LXBn
c3FsJywKICAgICAgICAgICByZWFkT25seTogdHJ1ZSwKICAgICAgICAgICBleHRyYUtleXM6IHBn
QWRtaW4uQnJvd3Nlci5lZGl0b3Jfc2hvcnRjdXRfa2V5cywKKyAgICAgICAgICBzY3JlZW5SZWFk
ZXJMYWJlbDogZmllbGQubGFiZWwsCiAgICAgICAgIH0pOwogCiAgICAgICB0aGlzLnJlZmxlY3RQ
cmVmZXJlbmNlcygpOwpAQCAtMjU3NCw2ICsyNTc3LDcgQEAgZGVmaW5lKFsKICAgICAgICAgICBs
aW5lTnVtYmVyczogdHJ1ZSwKICAgICAgICAgICBtb2RlOiAndGV4dC94LXBnc3FsJywKICAgICAg
ICAgICBleHRyYUtleXM6IHBnQWRtaW4uQnJvd3Nlci5lZGl0b3Jfc2hvcnRjdXRfa2V5cywKKyAg
ICAgICAgICBzY3JlZW5SZWFkZXJMYWJlbDogZGF0YS5sYWJlbCwKICAgICAgICAgfSk7CiAKICAg
ICAgIHNlbGYucmVmbGVjdFByZWZlcmVuY2VzKCk7CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi90
b29scy9kYXRhZ3JpZC9zdGF0aWMvanMvc2hvd19kYXRhLmpzIGIvd2ViL3BnYWRtaW4vdG9vbHMv
ZGF0YWdyaWQvc3RhdGljL2pzL3Nob3dfZGF0YS5qcwppbmRleCBkMjcwMGNmYmYuLjIyMzIyOTRk
NiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvZGF0YWdyaWQvc3RhdGljL2pzL3Nob3df
ZGF0YS5qcworKysgYi93ZWIvcGdhZG1pbi90b29scy9kYXRhZ3JpZC9zdGF0aWMvanMvc2hvd19k
YXRhLmpzCkBAIC0xOTMsNiArMTkzLDcgQEAgZnVuY3Rpb24gaW5pdEZpbHRlckRpYWxvZyhhbGVy
dGlmeSwgcGdCcm93c2VyKSB7CiAgICAgICAgICAgICBsaW5lV3JhcHBpbmc6IHRoYXQucHJlZmVy
ZW5jZXMud3JhcF9jb2RlLAogICAgICAgICAgICAgYXV0b0Nsb3NlQnJhY2tldHM6IHRoYXQucHJl
ZmVyZW5jZXMuaW5zZXJ0X3BhaXJfYnJhY2tldHMsCiAgICAgICAgICAgICBtYXRjaEJyYWNrZXRz
OiB0aGF0LnByZWZlcmVuY2VzLmJyYWNlX21hdGNoaW5nLAorICAgICAgICAgICAgc2NyZWVuUmVh
ZGVyTGFiZWw6IGdldHRleHQoJ0ZpbHRlciBTUUwnKSwKICAgICAgICAgICB9KTsKIAogICAgICAg
ICAgIGxldCBzcWxfZm9udF9zaXplID0gU3FsRWRpdG9yVXRpbHMuY2FsY0ZvbnRTaXplKHRoYXQu
cHJlZmVyZW5jZXMuc3FsX2ZvbnRfc2l6ZSk7CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi90b29s
cy9kZWJ1Z2dlci9zdGF0aWMvanMvZGlyZWN0LmpzIGIvd2ViL3BnYWRtaW4vdG9vbHMvZGVidWdn
ZXIvc3RhdGljL2pzL2RpcmVjdC5qcwppbmRleCA1MDExYzRhNWEuLmVlNDFmOWM3ZiAxMDA2NDQK
LS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvZGVidWdnZXIvc3RhdGljL2pzL2RpcmVjdC5qcworKysg
Yi93ZWIvcGdhZG1pbi90b29scy9kZWJ1Z2dlci9zdGF0aWMvanMvZGlyZWN0LmpzCkBAIC0xODA2
LDYgKzE4MDYsNyBAQCBkZWZpbmUoWwogICAgICAgICAgIGxpbmVXcmFwcGluZzogcGdBZG1pbi5C
cm93c2VyLmVkaXRvcl9vcHRpb25zLndyYXBDb2RlLAogICAgICAgICAgIGF1dG9DbG9zZUJyYWNr
ZXRzOiBwZ0FkbWluLkJyb3dzZXIuZWRpdG9yX29wdGlvbnMuaW5zZXJ0X3BhaXJfYnJhY2tldHMs
CiAgICAgICAgICAgbWF0Y2hCcmFja2V0czogcGdBZG1pbi5Ccm93c2VyLmVkaXRvcl9vcHRpb25z
LmJyYWNlX21hdGNoaW5nLAorICAgICAgICAgIHNjcmVlblJlYWRlckxhYmVsOiBnZXR0ZXh0KCdE
ZWJ1Z2dlciBTUUwgZWRpdG9yJyksCiAgICAgICAgIH0pOwogCiAgICAgICAvLyBVc2VmdWwgZm9y
IGtleWJvYXJkIG5hdmlnYXRpb24sIHdoZW4gdXNlciBwcmVzc2VzIGVzY2FwZSBrZXkgd2Ugd2ls
bApkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3N0YXRpYy9qcy9zcWxl
ZGl0b3IuanMgYi93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3Ivc3RhdGljL2pzL3NxbGVkaXRv
ci5qcwppbmRleCBmZTRiNmI1ZTAuLjRhNjA0YTY5MSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4v
dG9vbHMvc3FsZWRpdG9yL3N0YXRpYy9qcy9zcWxlZGl0b3IuanMKKysrIGIvd2ViL3BnYWRtaW4v
dG9vbHMvc3FsZWRpdG9yL3N0YXRpYy9qcy9zcWxlZGl0b3IuanMKQEAgLTM3NCw2ICszNzQsNyBA
QCBkZWZpbmUoJ3Rvb2xzLnF1ZXJ5dG9vbCcsIFsKICAgICAgICAgZXh0cmFLZXlzOiBwZ0Jyb3dz
ZXIuZWRpdG9yX3Nob3J0Y3V0X2tleXMsCiAgICAgICAgIHNjcm9sbGJhclN0eWxlOiAnc2ltcGxl
JywKICAgICAgICAgZHJhZ0Ryb3A6IGZhbHNlLAorICAgICAgICBzY3JlZW5SZWFkZXJMYWJlbDog
Z2V0dGV4dCgnU1FMIGVkaXRvcicpLAogICAgICAgfSk7CiAKICAgICAgIGlmKHNlbGYuaGFuZGxl
ci5pc19xdWVyeV90b29sKSB7CmRpZmYgLS1naXQgYS93ZWIveWFybi5sb2NrIGIvd2ViL3lhcm4u
bG9jawppbmRleCAxNTFlOThjYjMuLmQ2MzZkZjVjYiAxMDA2NDQKLS0tIGEvd2ViL3lhcm4ubG9j
aworKysgYi93ZWIveWFybi5sb2NrCkBAIC0yMzYzLDEwICsyMzYzLDEwIEBAIGNvYUBeMi4wLjI6
CiAgICAgY2hhbGsgIl4yLjQuMSIKICAgICBxICJeMS4xLjIiCiAKLWNvZGVtaXJyb3JAXjUuNTAu
MDoKLSAgdmVyc2lvbiAiNS41Mi4yIgotICByZXNvbHZlZCAiaHR0cHM6Ly9yZWdpc3RyeS55YXJu
cGtnLmNvbS9jb2RlbWlycm9yLy0vY29kZW1pcnJvci01LjUyLjIudGd6I2MyOWUxZjcxNzlmODVl
YjBkZDE3YzA1ODZmYTgxMGU0ODM4ZmY1ODQiCi0gIGludGVncml0eSBzaGE1MTItV0NHQ2l4TlVj
azJIR3ZZOC9aTkkxallmeFBHNWNSSHYwVmptV3VOemJ0Q0x6OHFZQTVkK2plNFFoU1NDdENhYWd5
ZU93TWkvSG1tUFRqQmdpVG0ybFE9PQorY29kZW1pcnJvckBeNS41NC4wOgorICB2ZXJzaW9uICI1
LjU0LjAiCisgIHJlc29sdmVkICJodHRwczovL3JlZ2lzdHJ5Lnlhcm5wa2cuY29tL2NvZGVtaXJy
b3IvLS9jb2RlbWlycm9yLTUuNTQuMC50Z3ojODJiNmFkZjY2MmIyOWVlYjdiODY3ZmU3ODM5ZDQ5
ZTI1ZTRhMGIzOCIKKyAgaW50ZWdyaXR5IHNoYTUxMi1QZ2Yzc3VydjR6dncrS2FXM2RvVVU3cEdq
RjBCUFU4L3NqN2VnbFdKanpuaTQ2VS9ERFc4cHUzblpZMFFnUUtVY0lDRFhSa3E4alptcTB5Nkto
eE0zUT09CiAKIGNvbGxlY3Rpb24tdmlzaXRAXjEuMC4wOgogICB2ZXJzaW9uICIxLjAuMCIK
--0000000000004627ed05a7549d01--