public inbox for [email protected]  
help / color / mirror / Atom feed
From: Aditya Toshniwal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help
Date: Wed, 9 Jan 2019 18:30:59 +0530
Message-ID: <CAM9w-_mawt4Df8TRXbfC7AYxZJBhJKCSu37NrU+pfHky00qvkw@mail.gmail.com> (raw)

Hi Hackers,

Attached is a tiny patch to fix the Postgres help for backup and restore
dialog.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


Attachments:

  [application/octet-stream] backup_restore_help.patch (1.2K, 3-backup_restore_help.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/backup/static/js/backup_dialog_wrapper.js b/web/pgadmin/tools/backup/static/js/backup_dialog_wrapper.js
index d25fb717..931d0a02 100644
--- a/web/pgadmin/tools/backup/static/js/backup_dialog_wrapper.js
+++ b/web/pgadmin/tools/backup/static/js/backup_dialog_wrapper.js
@@ -114,7 +114,7 @@ export class BackupDialogWrapper extends DialogWrapper {
         event.button.element.name,
         event.button.element.getAttribute('url'),
         node,
-        selectedTreeNode,
+        selectedTreeNode.getHtmlIdentifier(),
         event.button.element.getAttribute('label')
       );
       return;
diff --git a/web/pgadmin/tools/restore/static/js/restore_dialog_wrapper.js b/web/pgadmin/tools/restore/static/js/restore_dialog_wrapper.js
index 1ed88b96..0d211aec 100644
--- a/web/pgadmin/tools/restore/static/js/restore_dialog_wrapper.js
+++ b/web/pgadmin/tools/restore/static/js/restore_dialog_wrapper.js
@@ -114,7 +114,7 @@ export class RestoreDialogWrapper extends DialogWrapper {
         event.button.element.name,
         event.button.element.getAttribute('url'),
         node,
-        selectedTreeNode,
+        selectedTreeNode.getHtmlIdentifier(),
         event.button.element.getAttribute('label')
       );
       return;


view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help
  In-Reply-To: <CAM9w-_mawt4Df8TRXbfC7AYxZJBhJKCSu37NrU+pfHky00qvkw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox