MIME-Version: 1.0
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Tue, 15 Jan 2019 19:17:44 +0530
Message-ID: 
 <CAM9w-_mb+SQwLbxRnUALXBHZ9QVr=t49tXgoXFL865nqdehFBQ@mail.gmail.com>
Subject: [pgAdmin4][RM3475] Execution time for a query or function shows only
 minutes part and not hour part
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000008df373057f7f68ec"
Precedence: bulk

--0000000000008df373057f7f68ec
Content-Type: multipart/alternative; boundary="0000000000008df370057f7f68ea"

--0000000000008df370057f7f68ea
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

Attached is the patch to also display the hour part if the query execution
exceeds more than 1 hour, with some improvements is code. Test case added.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

--0000000000008df370057f7f68ea
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">Hi Hackers,</div><div class=3D"gmail_default" style=3D"font-fam=
ily:verdana,sans-serif"><br></div><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif">Attached is the patch to also display the hour=
 part if the query execution exceeds more than 1 hour, with some improvemen=
ts is code. Test case added.</div><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif"><br></div><div class=3D"gmail_default" style=
=3D"font-family:verdana,sans-serif">Kindly review.</div><div><br></div>-- <=
br><div dir=3D"ltr" class=3D"gmail_signature" data-smartmail=3D"gmail_signa=
ture"><div dir=3D"ltr"><div><div dir=3D"ltr"><font face=3D"trebuchet ms, sa=
ns-serif" size=3D"2" color=3D"#000000">Thanks and Regards,</font><div><span=
 style=3D"background-color:rgb(255,255,255)"><font face=3D"trebuchet ms, sa=
ns-serif" size=3D"2" color=3D"#000000">Aditya Toshniwal</font></span></div>=
<div><span style=3D"background-color:rgb(255,255,255)"><font face=3D"trebuc=
het ms, sans-serif" size=3D"2" color=3D"#000000">Software Engineer |=C2=A0E=
nterpriseDB Software Solutions |=C2=A0</font></span><span style=3D"color:rg=
b(0,0,0);font-family:&quot;trebuchet ms&quot;,sans-serif;font-size:small">P=
une</span></div><div><span style=3D"font-family:&quot;trebuchet ms&quot;,sa=
ns-serif;font-size:x-small"><font color=3D"#38761d">&quot;Don&#39;t Complai=
n about Heat, Plant a tree&quot;</font></span></div></div></div></div></div=
></div>

--0000000000008df370057f7f68ea--

--0000000000008df373057f7f68ec
Content-Type: application/octet-stream; name="RM3475.patch"
Content-Disposition: attachment; filename="RM3475.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_jqxt9o5a0>
X-Attachment-Id: f_jqxt9o5a0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9zcWxlZGl0b3IvY2FsY3VsYXRlX3F1
ZXJ5X3J1bl90aW1lLmpzIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL3NxbGVkaXRvci9jYWxjdWxh
dGVfcXVlcnlfcnVuX3RpbWUuanMKaW5kZXggYjE2M2FhYzUuLmJhMzkwNTExIDEwMDY0NAotLS0g
YS93ZWIvcGdhZG1pbi9zdGF0aWMvanMvc3FsZWRpdG9yL2NhbGN1bGF0ZV9xdWVyeV9ydW5fdGlt
ZS5qcworKysgYi93ZWIvcGdhZG1pbi9zdGF0aWMvanMvc3FsZWRpdG9yL2NhbGN1bGF0ZV9xdWVy
eV9ydW5fdGltZS5qcwpAQCAtMTAsMjQgKzEwLDI1IEBACiBpbXBvcnQgbW9tZW50IGZyb20gJ21v
bWVudCc7CiAKIGV4cG9ydCBmdW5jdGlvbiBjYWxjdWxhdGVRdWVyeVJ1blRpbWUoc3RhcnRUaW1l
LCBlbmRUaW1lKSB7Ci0gIGNvbnN0IHRlbXBFbmREYXRlID0gbW9tZW50KGVuZFRpbWUpOwotICBs
ZXQgbWlsaXNlY29uZHMgPSB0ZW1wRW5kRGF0ZS5kaWZmKHN0YXJ0VGltZSk7Ci0gIGxldCBzZWNv
bmRzID0gdGVtcEVuZERhdGUuZGlmZihzdGFydFRpbWUsICdzZWNvbmRzJyk7Ci0gIGNvbnN0IG1p
bnV0ZXMgPSB0ZW1wRW5kRGF0ZS5kaWZmKHN0YXJ0VGltZSwgJ21pbnV0ZXMnKTsKLQorICBsZXQg
dG90YWxfbXMgPSBtb21lbnQoZW5kVGltZSkuZGlmZihzdGFydFRpbWUpOwogICBsZXQgcmVzdWx0
ID0gJyc7Ci0gIGlmIChtaW51dGVzID4gMCkgewotICAgIHJlc3VsdCArPSBtaW51dGVzICsgJyBt
aW4gJzsKLSAgICBzZWNvbmRzIC09IG1pbnV0ZXMgKiA2MDsKLSAgfQorICBsZXQgc2VjcywgbWlu
cywgaHJzOworCisgIC8qIEV4dHJhY3Qgc2Vjb25kcyBmcm9tIG1pbGxpc2VjcyAqLworICBzZWNz
ID0gcGFyc2VJbnQodG90YWxfbXMvMTAwMCk7CisgIHRvdGFsX21zID0gdG90YWxfbXMlMTAwMDsK
KworICAvKiBFeHRyYWN0IG1pbnMgZnJvbSBzZWNvbmRzICovCisgIG1pbnMgPSBwYXJzZUludChz
ZWNzLzYwKTsKKyAgc2VjcyA9IHNlY3MlNjA7CiAKLSAgaWYgKHNlY29uZHMgPiAwKSB7Ci0gICAg
cmVzdWx0ICs9IHNlY29uZHMgKyAnIHNlY3MgJzsKLSAgICBtaWxpc2Vjb25kcyAtPSBzZWNvbmRz
ICogMTAwMDsKLSAgfQorICAvKiBFeHRyYWN0IGhycyBmcm9tIG1pbnMgKi8KKyAgaHJzID0gcGFy
c2VJbnQobWlucy82MCk7CisgIG1pbnMgPSBtaW5zJTYwOwogCi0gIGlmKG1pbnV0ZXMgPD0gMCkg
ewotICAgIHJlc3VsdCArPSBtaWxpc2Vjb25kcyArICcgbXNlYyc7Ci0gIH0KKyAgcmVzdWx0ID0g
KGhycz4wID8gaHJzICsgJyBociAnOiAnJykKKyAgICAgICAgICArIChtaW5zPjAgPyBtaW5zICsg
JyBtaW4gJzogJycpCisgICAgICAgICAgKyAoaHJzPD0wICYmIHNlY3M+MCA/IHNlY3MgKyAnIHNl
Y3MgJzogJycpCisgICAgICAgICAgKyAoaHJzPD0wICYmIG1pbnM8PTAgPyB0b3RhbF9tcyArICcg
bXNlYyAnOicnKTsKICAgcmV0dXJuIHJlc3VsdC50cmltKCk7CiB9CmRpZmYgLS1naXQgYS93ZWIv
cmVncmVzc2lvbi9qYXZhc2NyaXB0L3NxbGVkaXRvci9jYWxjdWxhdGVfcXVlcnlfcnVuX3RpbWVf
c3BlYy5qcyBiL3dlYi9yZWdyZXNzaW9uL2phdmFzY3JpcHQvc3FsZWRpdG9yL2NhbGN1bGF0ZV9x
dWVyeV9ydW5fdGltZV9zcGVjLmpzCmluZGV4IGU1YTU4ZmU5Li41ZDQxODEzZiAxMDA2NDQKLS0t
IGEvd2ViL3JlZ3Jlc3Npb24vamF2YXNjcmlwdC9zcWxlZGl0b3IvY2FsY3VsYXRlX3F1ZXJ5X3J1
bl90aW1lX3NwZWMuanMKKysrIGIvd2ViL3JlZ3Jlc3Npb24vamF2YXNjcmlwdC9zcWxlZGl0b3Iv
Y2FsY3VsYXRlX3F1ZXJ5X3J1bl90aW1lX3NwZWMuanMKQEAgLTc5LDQgKzc5LDI3IEBAIGRlc2Ny
aWJlKCcjY2FsY3VsYXRlUXVlcnlSdW5UaW1lJywgKCkgPT4gewogICAgICAgICAgIC50b0VxdWFs
KCc5IG1pbiA1NCBzZWNzJyk7CiAgICAgfSk7CiAgIH0pOworCisgIGRlc2NyaWJlKCd0aW1lIGRp
ZmZlcmVuY2UgaXMgYmlnZ2VyIHRoZW4gMSBob3VyJywgKCkgPT4geworICAgIGl0KCdkaXNwbGF5
cyBzZWNvbmRzLCBtaWxsaXNlY29uZHMnLCAoKSA9PiB7CisgICAgICBsZXQgc3RhcnREYXRlID0g
bW9tZW50KHsKKyAgICAgICAgeWVhcnM6MjAxOCwKKyAgICAgICAgbW9udGhzOjQsCisgICAgICAg
IGRhdGU6MiwKKyAgICAgICAgaG91cnM6MTAsCisgICAgICAgIG1pbnV0ZXM6MzAsCisgICAgICAg
IHNlY29uZHM6MjAsCisgICAgICAgIG1pbGxpc2Vjb25kczoxMjN9KS50b0RhdGUoKTsKKyAgICAg
IGxldCBlbmREYXRlID0gbW9tZW50KHsKKyAgICAgICAgeWVhcnM6MjAxOCwKKyAgICAgICAgbW9u
dGhzOjQsCisgICAgICAgIGRhdGU6MiwKKyAgICAgICAgaG91cnM6MTEsCisgICAgICAgIG1pbnV0
ZXM6NDAsCisgICAgICAgIHNlY29uZHM6MTUsCisgICAgICAgIG1pbGxpc2Vjb25kczo3MH0pLnRv
RGF0ZSgpOworICAgICAgZXhwZWN0KGNhbGN1bGF0ZVF1ZXJ5UnVuVGltZShzdGFydERhdGUsIGVu
ZERhdGUpKQorICAgICAgICAgIC50b0VxdWFsKCcxIGhyIDkgbWluJyk7CisgICAgfSk7CisgIH0p
OwogfSk7Cg==
--0000000000008df373057f7f68ec--