Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1icQzp-00054Y-GJ for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Dec 2019 09:30:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1icQzo-0004nB-7l for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Dec 2019 09:30:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1icQzo-0004n4-05 for pgadmin-hackers@lists.postgresql.org; Wed, 04 Dec 2019 09:30:56 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1icQzl-0005ai-IR for pgadmin-hackers@postgresql.org; Wed, 04 Dec 2019 09:30:55 +0000 Received: by mail-ed1-x541.google.com with SMTP id v16so5998530edy.6 for ; Wed, 04 Dec 2019 01:30:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hjABCC0oQh+0oYUnm/cdlU8YTX0tOg3Ilf/Jy8IGjWo=; b=1AjSwSgmeppDK7INjQqE5m4BkU56iAiqsbJG8BUh6FmMIMmFtMUwtSIOWP3xQSWGtS umLvX4/l0TGj2MYYHEIqT98If8dJy5w2xpy7S9u3ekmEaDPxTakESExjQiJ2wJRCaX7U Tx2qVgWyllLhKC2jG6ZBtR8KWhLJIVWp9j4lvFEu+zm/gt9zpfqgGjMmjY+G8lROtyJz 9dimePOLje30rLj4tlJVYlynPUnm2bywalarjCbFg2JjtBafQtaaCVDp922YG1haxKWQ 3OFxC/dl1lm6OYwpoStI0iojjHdm9e/yHZOzw9qxechecYqEqBZUlkStoK3a/wulDIuc qF0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hjABCC0oQh+0oYUnm/cdlU8YTX0tOg3Ilf/Jy8IGjWo=; b=JQT8Ov7mNUsAvWuDvv3+ZcQacVMicJ1OZuqnmFFO9nepFQ0cLIcUpteqVNGGEvUVxE +Pfoxet2yFx6/vGMyZmwQwKkpC7qxBeoHYsuo7af/Biltzcwt34/ztCYWTJ1WUCy2dlz qIq7+mE2EVrgsF+VQThUTKS0j5hVxI5zVfsd1e6PXrDV5tm1iYiqzCI4hgwMiKmCTIkt mdKubq+kImAnRw8OHLmn3sJ78GvAWl7eD8nvmPX8iyK3rFl9TSvnqE/GxqzWDasTW6mB +zFItuvWT3I3ShYy74Z0/3FP5TxP6cP8QHLBeoBY+2BeEGXThONxnwZqHQfTWjc3hB0q 3uCw== X-Gm-Message-State: APjAAAXaE++OWRzMF8J33byHylIyNlKEhgK2NNLQfjXF6vRFw5O/Yl/l 1XFzovpPOPYEFDarPQL/wEgzwPwV8oDz+RgygM7tDONihb2sJVfoPKsLfD7IFc/eL6awRSW41TN UtfrV8rkScN+Q1gVUTtx0wNyeaK5A/PfWB7qWc/4Ieaa5eZIybWF/9Q3Uob5rABHK9DY1T0jeZk URaw7AGubEwhGHqekLKaTnPnE5LUCMIid3Uk6E6ypFBkn8vY4c/ORCZA== X-Google-Smtp-Source: APXvYqwelWjjK1LHdOUIvU0LTwwjrxbQNK2ag0T2zp052MsXuKjNs4pehJKyJ9HB5Rwr6dnm2+xXtZA4FTRIdgZRlzk= X-Received: by 2002:a17:906:828b:: with SMTP id h11mr1964487ejx.273.1575451852122; Wed, 04 Dec 2019 01:30:52 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Wed, 4 Dec 2019 15:00:15 +0530 Message-ID: Subject: Re: [pgAdmin][RM4772][Accessibility] Provide aria-label to an invisible label where a visible label cannot be used To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000001f1540598dd785d" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000001f1540598dd785d Content-Type: multipart/alternative; boundary="00000000000001f1510598dd785b" --00000000000001f1510598dd785b Content-Type: text/plain; charset="UTF-8" Hi Hackers, Attached is the patch to fix the feature tests which were failing after the commit. The reason being, the span elements which was used to show properties tab data is changed to input now as per accessibility requirements. Also, there is no way now to check XSS of input because the input tags returns the original value on extracting the value attribute and not the escaped value. Previously, the value was HTML element under the span tag. Not to worry, input is escaped and is XSS free, handled in underscore templates. On Tue, Dec 3, 2019 at 12:48 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Dec 3, 2019 at 11:39 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to add label and aria-label wherever applicable. >> The patch also fixes few other accessibility related errors raised by >> "WAVE" extension of Chrome. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --00000000000001f1510598dd785b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

Attached is the patch to fix the feature t= ests which were failing after the commit. The reason being, the span elemen= ts which was used to show properties tab data is changed to input now as pe= r accessibility requirements. Also, there is no way now to check XSS of inp= ut because the input tags returns the original value on extracting the valu= e attribute and not the escaped value. Previously, the value was HTML eleme= nt under the span tag.
Not to worry, input is escaped and is XSS free, hand= led in underscore templates.

On Tue, Dec 3, 2019 at 12:48 PM Akshay Jo= shi <akshay.joshi@enter= prisedb.com> wrote:
Thanks, patch applied.

On Tue, Dec 3, 2019 at 11= :39 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
<= div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">Hi Hac= kers,

Attached is the patch to add label and aria-label wherever appli= cable. The patch also fixes few other=C2=A0accessibility=C2=A0related error= s raised by "WAVE" extension of Chrome.

Kindly review.
=

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0Ente= rpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"<= /div>


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB In= dia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"
=
--00000000000001f1510598dd785b-- --00000000000001f1540598dd785d Content-Type: application/octet-stream; name="RM4772.feature.patch" Content-Disposition: attachment; filename="RM4772.feature.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k3r37swt0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2ZlYXR1cmVfdGVzdHMveHNzX2NoZWNrc19wYW5lbHNf YW5kX3F1ZXJ5X3Rvb2xfdGVzdC5weSBiL3dlYi9wZ2FkbWluL2ZlYXR1cmVfdGVzdHMveHNzX2No ZWNrc19wYW5lbHNfYW5kX3F1ZXJ5X3Rvb2xfdGVzdC5weQppbmRleCAxNWFhZDdiZTkuLjcxYjU4 YzAxMyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vZmVhdHVyZV90ZXN0cy94c3NfY2hlY2tzX3Bh bmVsc19hbmRfcXVlcnlfdG9vbF90ZXN0LnB5CisrKyBiL3dlYi9wZ2FkbWluL2ZlYXR1cmVfdGVz dHMveHNzX2NoZWNrc19wYW5lbHNfYW5kX3F1ZXJ5X3Rvb2xfdGVzdC5weQpAQCAtNjQsNyArNjQs NiBAQCBjbGFzcyBDaGVja0Zvclhzc0ZlYXR1cmVUZXN0KEJhc2VGZWF0dXJlVGVzdCk6CiAgICAg ICAgIHNlbGYucGFnZS5hZGRfc2VydmVyKHNlbGYuc2VydmVyKQogICAgICAgICBzZWxmLl90YWJs ZXNfbm9kZV9leHBhbmRhYmxlKCkKICAgICAgICAgc2VsZi5fY2hlY2tfeHNzX2luX2Jyb3dzZXJf dHJlZSgpCi0gICAgICAgIHNlbGYuX2NoZWNrX3hzc19pbl9wcm9wZXJ0aWVzX3RhYigpCiAgICAg ICAgIHNlbGYuX2NoZWNrX3hzc19pbl9zcWxfdGFiKCkKIAogICAgICAgICAjIHNvbWV0aW1lIHRo ZSB0YWIgZm9yIGRlcGVuZGVudCBkb2VzIG5vdCBzaG93IGluZm8sIHNvIHJlZnJlc2hpbmcKQEAg LTEyMSwyMSArMTIwLDYgQEAgY2xhc3MgQ2hlY2tGb3JYc3NGZWF0dXJlVGVzdChCYXNlRmVhdHVy ZVRlc3QpOgogICAgICAgICAgICAgIkJyb3dzZXIgdHJlZSIKICAgICAgICAgKQogCi0gICAgZGVm IF9jaGVja194c3NfaW5fcHJvcGVydGllc190YWIoc2VsZik6Ci0gICAgICAgIHByaW50KAotICAg ICAgICAgICAgIlxuXHRDaGVja2luZyB0aGUgUHJvcGVydGllcyB0YWIgZm9yIFhTUyB2dWxuZXJh YmlsaXRpZXMiLAotICAgICAgICAgICAgZmlsZT1zeXMuc3RkZXJyLCBlbmQ9IiIKLSAgICAgICAg KQotICAgICAgICBzZWxmLnBhZ2UuY2xpY2tfdGFiKCJQcm9wZXJ0aWVzIikKLSAgICAgICAgc291 cmNlX2NvZGUgPSBzZWxmLnBhZ2UuZmluZF9ieV94cGF0aCgKLSAgICAgICAgICAgICIvL3NwYW5b Y29udGFpbnMoQGNsYXNzLCd1bmVkaXRhYmxlLWlucHV0JyldIgotICAgICAgICApLmdldF9hdHRy aWJ1dGUoJ2lubmVySFRNTCcpCi0gICAgICAgIHNlbGYuX2NoZWNrX2VzY2FwZWRfY2hhcmFjdGVy cygKLSAgICAgICAgICAgIHNvdXJjZV9jb2RlLAotICAgICAgICAgICAgIiZsdDtoMSZndDtYIiwK LSAgICAgICAgICAgICJQcm9wZXJ0aWVzIHRhYiAoQmFja2Zvcm0gQ29udHJvbCkiCi0gICAgICAg ICkKLQogICAgIGRlZiBfY2hlY2tfeHNzX2luX3NxbF90YWIoc2VsZik6CiAgICAgICAgIHByaW50 KAogICAgICAgICAgICAgIlxuXHRDaGVja2luZyB0aGUgU1FMIHRhYiBmb3IgZm9yIFhTUyB2dWxu ZXJhYmlsaXRpZXMiLApkaWZmIC0tZ2l0IGEvd2ViL3JlZ3Jlc3Npb24vZmVhdHVyZV91dGlscy9w Z2FkbWluX3BhZ2UucHkgYi93ZWIvcmVncmVzc2lvbi9mZWF0dXJlX3V0aWxzL3BnYWRtaW5fcGFn ZS5weQppbmRleCAwOWZjMzBhYzguLmQzYjA4OTgzMiAxMDA2NDQKLS0tIGEvd2ViL3JlZ3Jlc3Np b24vZmVhdHVyZV91dGlscy9wZ2FkbWluX3BhZ2UucHkKKysrIGIvd2ViL3JlZ3Jlc3Npb24vZmVh dHVyZV91dGlscy9wZ2FkbWluX3BhZ2UucHkKQEAgLTk3Nyw3ICs5NzcsNyBAQCBjbGFzcyBQZ2Fk bWluUGFnZToKICAgICAgICAgZGVmIGVsZW1lbnRfaWZfaXRfZXhpc3RzKGRyaXZlcik6CiAgICAg ICAgICAgICB0cnk6CiAgICAgICAgICAgICAgICAgZWxlbWVudCA9IGZpbmRfbWV0aG9kX3dpdGhf YXJncyhkcml2ZXIpCi0gICAgICAgICAgICAgICAgaWYgZWxlbWVudC5pc19kaXNwbGF5ZWQoKSBh bmQgZWxlbWVudC5pc19lbmFibGVkKCk6CisgICAgICAgICAgICAgICAgaWYgZWxlbWVudC5pc19k aXNwbGF5ZWQoKToKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIFRydWUKICAgICAgICAgICAg IGV4Y2VwdCAoTm9TdWNoRWxlbWVudEV4Y2VwdGlvbiwgU3RhbGVFbGVtZW50UmVmZXJlbmNlRXhj ZXB0aW9uKToKICAgICAgICAgICAgICAgICByZXR1cm4gRmFsc2UK --00000000000001f1540598dd785d--