MIME-Version: 1.0
References: 
 <CAOBg0AP6zw+5M2Ux8u9igedVHKUOrPwEdH=+pwmCgfki=o=a=A@mail.gmail.com>
In-Reply-To: 
 <CAOBg0AP6zw+5M2Ux8u9igedVHKUOrPwEdH=+pwmCgfki=o=a=A@mail.gmail.com>
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Tue, 8 Sep 2020 15:30:52 +0530
Message-ID: 
 <CAM9w-_mgC6O1Pb36F_BiG8mt5_5BRAT1XCO0etkLCO+Ux78o8A@mail.gmail.com>
Subject: Re: Patch for SonarQube code scan fixes.
To: Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000344c2b05aeca6be5"
Precedence: bulk

--000000000000344c2b05aeca6be5
Content-Type: text/plain; charset="UTF-8"

Hi,

sqlautocomplete code is mostly inherited from the pgcli project. Changing
it might create trouble in updating the code with new versions.

On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com>
wrote:

> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
>
> 1. psycopg2/connection:
>
>    - Refactor this function to reduce its Cognitive Complexity from 32 to
>    the 15 allowed.
>    - Refactor this function to reduce its Cognitive Complexity from 17 to
>    the 15 allowed.
>
> 2. psycopg2/server_manager:
>
>    - Refactor this function to reduce its Cognitive Complexity from 20 to
>    the 15 allowed.
>    - Refactor this function to reduce its Cognitive Complexity from 33 to
>    the 15 allowed.
>    - Refactor this function to reduce its Cognitive Complexity from 26 to
>    the 15 allowed.
>
> 3. sqlautocomplete/parseutils:
>
>    - Refactor this function to reduce its Cognitive Complexity from 23 to
>    the 15 allowed.
>
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/>
> *Mob.No: +91-7798364578.*
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"

--000000000000344c2b05aeca6be5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">Hi,</div><div class=3D"gmail_default" style=3D"font-family:verd=
ana,sans-serif"><br></div><div class=3D"gmail_default" style=3D"font-family=
:verdana,sans-serif">sqlautocomplete=C2=A0code is mostly inherited from the=
 pgcli project. Changing it might create trouble in updating the code with =
new versions.</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" cl=
ass=3D"gmail_attr">On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite &lt;<a href=
=3D"mailto:nikhil.mohite@enterprisedb.com">nikhil.mohite@enterprisedb.com</=
a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p=
x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><d=
iv dir=3D"ltr"><div>Hi Team,<div><br></div><div>I have fixed some code smel=
l issues in the SonarQube scan, PFA patch.</div><div>Details as=C2=A0follow=
s:</div></div><div><br></div>1.=C2=A0psycopg2/connection:<div><ul><li>Refac=
tor this function to reduce its Cognitive Complexity from 32 to the 15 allo=
wed.</li><li>Refactor this function to reduce its Cognitive Complexity from=
 17 to the 15 allowed.</li></ul>2. psycopg2/server_manager:</div><ul><li>Re=
factor this function to reduce its Cognitive Complexity from 20 to the 15 a=
llowed.</li><li>Refactor this function to reduce its Cognitive Complexity f=
rom 33 to the 15 allowed.</li><li>Refactor this function to reduce its Cogn=
itive Complexity from 26 to the 15 allowed.</li></ul>3. sqlautocomplete/par=
seutils:<div><ul><li>Refactor this function to reduce its Cognitive Complex=
ity from 23 to the 15 allowed.</li></ul><div><br></div><div><br></div><div>=
-- <br><div dir=3D"ltr"><div dir=3D"ltr"><b><font face=3D"verdana, sans-ser=
if">Thanks &amp; Regards,</font></b><div><b><font face=3D"verdana, sans-ser=
if">Nikhil Mohite</font></b></div><div><b><font face=3D"verdana, sans-serif=
">Software Engineer.</font></b></div><div><a href=3D"https://www.enterprise=
db.com/" target=3D"_blank"><b><font face=3D"verdana, sans-serif">EDB Postgr=
es</font></b></a></div><div><b><font face=3D"verdana, sans-serif">Mob.No: +=
91-7798364578.</font></b></div></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"lt=
r"><div dir=3D"ltr"><div dir=3D"ltr"><div><font size=3D"2" color=3D"#000000=
" face=3D"arial, sans-serif">Thanks,</font><div><span style=3D"color:rgb(34=
,34,34)"><span style=3D"color:rgb(18,22,70)"><font face=3D"arial, sans-seri=
f">Aditya Toshniwal</font></span></span><font size=3D"2" color=3D"#000000" =
face=3D"verdana, sans-serif"><br></font></div><div><span style=3D"color:rgb=
(18,22,70);font-family:Arial,sans-serif">pgAdmin hacker</span><font size=3D=
"2" color=3D"#000000" style=3D"font-family:verdana,sans-serif">=C2=A0| </fo=
nt><font size=3D"2" color=3D"#000000" face=3D"arial, sans-serif">Sr. Softwa=
re Engineer</font><font size=3D"2" color=3D"#000000"><font face=3D"verdana,=
 sans-serif"> | </font><a href=3D"http://edbpostgres.com" target=3D"_blank"=
><font face=3D"arial, sans-serif" color=3D"#000000"><b>edbpostgres.com</b><=
/font></a></font></div><div><font color=3D"#38761d" size=3D"1"><font face=
=3D"arial, sans-serif">&quot;Don&#39;t Complain about Heat, Plant a TREE&qu=
ot;</font></font></div></div></div></div></div></div></div></div>

--000000000000344c2b05aeca6be5--