MIME-Version: 1.0
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Wed, 5 Jun 2019 12:43:37 +0530
Message-ID: 
 <CAM9w-_mhLAoL3ZgY3w8SCH6WbSF=_11tU3Ueh-voAWkfgVZtVw@mail.gmail.com>
Subject: [pgAdmin][RM4310] User can not connect to the Master Password with
 Enter button
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000003698b3058a8e585b"
Precedence: bulk

--0000000000003698b3058a8e585b
Content-Type: multipart/alternative; boundary="0000000000003698b0058a8e5859"

--0000000000003698b0058a8e5859
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

Attached is the patch to fix an issue where using browser autofills in
alertify dialogs triggers the help page button (#4317).
A workaround was added to master password dialog to avoid this, but that in
turn disabled the 'OK' button tigger on pressing enter button. This is also
fixed with this patch.(#4310)

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

--0000000000003698b0058a8e5859
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">Hi Hackers,<br clear=3D"all"></div><div class=3D"gmail_default"=
 style=3D"font-family:verdana,sans-serif"><br></div><div class=3D"gmail_def=
ault" style=3D"font-family:verdana,sans-serif">Attached is the patch to fix=
 an issue where using browser autofills in alertify dialogs triggers the he=
lp page button (#4317).</div><div class=3D"gmail_default" style=3D"font-fam=
ily:verdana,sans-serif">A workaround was added to master password dialog to=
 avoid this, but that in turn disabled the &#39;OK&#39; button tigger on pr=
essing enter button. This is also fixed with this patch.(#4310)</div><div><=
br></div>-- <br><div dir=3D"ltr" class=3D"gmail_signature" data-smartmail=
=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=
=3D"ltr"><font size=3D"2" color=3D"#000000" face=3D"verdana, sans-serif">Th=
anks and Regards,</font><div><span style=3D"background-color:rgb(255,255,25=
5)"><font size=3D"2" color=3D"#000000" face=3D"verdana, sans-serif">Aditya =
Toshniwal</font></span></div><div><font face=3D"verdana, sans-serif"><span =
style=3D"background-color:rgb(255,255,255)"><font size=3D"2" color=3D"#0000=
00">Software Engineer |=C2=A0EnterpriseDB India |=C2=A0</font></span><span =
style=3D"color:rgb(0,0,0)">Pune</span></font></div><div><font color=3D"#387=
61d" face=3D"verdana, sans-serif" size=3D"1">&quot;Don&#39;t Complain about=
 Heat, Plant a TREE&quot;</font></div></div></div></div></div></div></div><=
/div>

--0000000000003698b0058a8e5859--

--0000000000003698b3058a8e585b
Content-Type: application/octet-stream; name="RM4310_4317.patch"
Content-Disposition: attachment; filename="RM4310_4317.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_jwiwb6cy0>
X-Attachment-Id: f_jwiwb6cy0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL2Jyb3dzZXIuanMgYi93
ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9icm93c2VyLmpzCmluZGV4IDRhZjY5NjAzLi41
NDA3NmM2MyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvanMvYnJvd3Nl
ci5qcworKysgYi93ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9icm93c2VyLmpzCkBAIC0x
Miw3ICsxMiw3IEBAIGRlZmluZSgncGdhZG1pbi5icm93c2VyJywgWwogICAnc291cmNlcy9nZXR0
ZXh0JywgJ3NvdXJjZXMvdXJsX2ZvcicsICdyZXF1aXJlJywgJ2pxdWVyeScsICd1bmRlcnNjb3Jl
JywgJ3VuZGVyc2NvcmUuc3RyaW5nJywKICAgJ2Jvb3RzdHJhcCcsICdzb3VyY2VzL3BnYWRtaW4n
LCAncGdhZG1pbi5hbGVydGlmeWpzJywgJ2J1bmRsZWRfY29kZW1pcnJvcicsCiAgICdzb3VyY2Vz
L2NoZWNrX25vZGVfdmlzaWJpbGl0eScsICcuL3Rvb2xiYXInLCAncGdhZG1pbi5oZWxwJywKLSAg
J3NvdXJjZXMvY3NyZicsICdzb3VyY2VzL2tleWJvYXJkX3Nob3J0Y3V0cycsICdwZ2FkbWluLmJy
b3dzZXIudXRpbHMnLAorICAnc291cmNlcy9jc3JmJywgJ3BnYWRtaW4uYnJvd3Nlci51dGlscycs
CiAgICd3Y2RvY2tlcicsICdqcXVlcnkuY29udGV4dG1lbnUnLCAnanF1ZXJ5LmFjaXBsdWdpbics
ICdqcXVlcnkuYWNpdHJlZScsCiAgICdwZ2FkbWluLmJyb3dzZXIucHJlZmVyZW5jZXMnLCAncGdh
ZG1pbi5icm93c2VyLm1lc3NhZ2VzJywKICAgJ3BnYWRtaW4uYnJvd3Nlci5tZW51JywgJ3BnYWRt
aW4uYnJvd3Nlci5wYW5lbCcsICdwZ2FkbWluLmJyb3dzZXIubGF5b3V0JywKQEAgLTI0LDcgKzI0
LDcgQEAgZGVmaW5lKCdwZ2FkbWluLmJyb3dzZXInLCBbCiAgIHRyZWUsCiAgIGdldHRleHQsIHVy
bF9mb3IsIHJlcXVpcmUsICQsIF8sIFMsCiAgIEJvb3RzdHJhcCwgcGdBZG1pbiwgQWxlcnRpZnks
IGNvZGVtaXJyb3IsCi0gIGNoZWNrTm9kZVZpc2liaWxpdHksIHRvb2xCYXIsIGhlbHAsIGNzcmZU
b2tlbiwga2V5Ym9hcmRGdW5jCisgIGNoZWNrTm9kZVZpc2liaWxpdHksIHRvb2xCYXIsIGhlbHAs
IGNzcmZUb2tlbgogKSB7CiAgIHdpbmRvdy5qUXVlcnkgPSB3aW5kb3cuJCA9ICQ7CiAgIC8vIFNv
bWUgc2NyaXB0cyBkbyBleHBvcnQgdGhlaXIgb2JqZWN0IGluIHRoZSB3aW5kb3cgb25seS4KQEAg
LTUxOCw2ICs1MTgsOSBAQCBkZWZpbmUoJ3BnYWRtaW4uYnJvd3NlcicsIFsKICAgICAgICAgICAg
ICAgdGhpcy5tZXNzYWdlID0gbWVzc2FnZTsKICAgICAgICAgICAgICAgdGhpcy5yZXNldCA9IHJl
c2V0OwogICAgICAgICAgICAgfSwKKyAgICAgICAgICAgIGJ1aWxkOiBmdW5jdGlvbigpIHsKKyAg
ICAgICAgICAgICAgQWxlcnRpZnkucGdEaWFsb2dCdWlsZC5hcHBseSh0aGlzKTsKKyAgICAgICAg
ICAgIH0sCiAgICAgICAgICAgICBzZXR1cDpmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgcmV0
dXJuIHsKICAgICAgICAgICAgICAgICBidXR0b25zOlt7CkBAIC01NjIsOSArNTY1LDcgQEAgZGVm
aW5lKCdwZ2FkbWluLmJyb3dzZXInLCBbCiAKICAgICAgICAgICAgICAgLyogRW5hYmxlIG9rIG9u
bHkgaWYgcGFzc3dvcmQgZW50ZXJlZCAqLwogICAgICAgICAgICAgICAkb2tCdG4ucHJvcCgnZGlz
YWJsZWQnLCB0cnVlKTsKLSAgICAgICAgICAgICAgJHBhc3N3b3JkLm9uKCdpbnB1dCBjaGFuZ2Ug
a2V5dXAnLCAoZXZlbnQpPT57Ci0gICAgICAgICAgICAgICAga2V5Ym9hcmRGdW5jLl9zdG9wRXZl
bnRQcm9wYWdhdGlvbihldmVudCk7Ci0KKyAgICAgICAgICAgICAgJHBhc3N3b3JkLm9uKCdpbnB1
dCBjaGFuZ2UnLCAoKT0+ewogICAgICAgICAgICAgICAgIGlmKCRwYXNzd29yZC52YWwoKSAhPSAn
JykgewogICAgICAgICAgICAgICAgICAgJG9rQnRuLnByb3AoJ2Rpc2FibGVkJywgZmFsc2UpOwog
ICAgICAgICAgICAgICAgIH0gZWxzZSB7CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9zdGF0aWMv
anMvYWxlcnRpZnkucGdhZG1pbi5kZWZhdWx0cy5qcyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9h
bGVydGlmeS5wZ2FkbWluLmRlZmF1bHRzLmpzCmluZGV4IDgxNTAzOTliLi41OTJjMWU1NiAxMDA2
NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2FsZXJ0aWZ5LnBnYWRtaW4uZGVmYXVsdHMu
anMKKysrIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2FsZXJ0aWZ5LnBnYWRtaW4uZGVmYXVsdHMu
anMKQEAgLTI2Niw2ICsyNjYsMTcgQEAgZGVmaW5lKFsKICAgICB0aGlzLnNldCgnb25yZXNpemVk
JywgYWxlcnRpZnlEaWFsb2dSZXNpemVkLmJpbmQodGhpcywgdHJ1ZSkpOwogICAgIHRoaXMuc2V0
KCdvbm1heGltaXplZCcsIGFsZXJ0aWZ5RGlhbG9nUmVzaXplZCk7CiAgICAgdGhpcy5zZXQoJ29u
cmVzdG9yZWQnLCBhbGVydGlmeURpYWxvZ1Jlc2l6ZWQpOworCisgICAgLyogU2V0IHRoZSBrZXkg
dG8gbnVsbCBpZiBpdCBpcyBub3QgZGVmaW5lZAorICAgICAqIFdoZW4gQnJvd3NlciBhdXRvZmls
bCBkcm9wIGRvd24gdmFsdWUgaXMgY2xpY2tlZCBpdCByYWlzZXMgYSBrZXl1cCBldmVudAorICAg
ICAqIHdpdGggdW5kZWZpbmVkIGtleUNvZGUuIFRoZSB1bmRlZmluZWQga2V5Q29kZSBtYXRjaGVz
IHRoZSB1bmRlZmluZWQga2V5CisgICAgICogb2YgYWxlcnRpZnkgYW5kIHRyaWdnZXJzIHRoZSBi
dXR0b24KKyAgICAgKi8KKyAgICBmb3IobGV0IGk9MDsgaTx0aGlzLl9faW50ZXJuYWwuYnV0dG9u
cy5sZW5ndGg7IGkrKykgeworICAgICAgaWYoXy5pc1VuZGVmaW5lZCh0aGlzLl9faW50ZXJuYWwu
YnV0dG9uc1tpXVsna2V5J10pKSB7CisgICAgICAgIHRoaXMuX19pbnRlcm5hbC5idXR0b25zW2ld
WydrZXknXSA9IG51bGw7CisgICAgICB9CisgICAgfQogICB9OwogCiAgIGFsZXJ0aWZ5LnBnSGFu
ZGxlSXRlbUVycm9yID0gZnVuY3Rpb24oeGhyLCBlcnJvciwgbWVzc2FnZSwgYXJncykgewo=
--0000000000003698b3058a8e585b--