Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiDpk-0005rX-6O for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 08:08:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hiDph-0003qF-Mo for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 08:08:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiDph-0003lO-CP for pgadmin-hackers@lists.postgresql.org; Tue, 02 Jul 2019 08:08:09 +0000 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiDpe-0007cT-GE for pgadmin-hackers@postgresql.org; Tue, 02 Jul 2019 08:08:07 +0000 Received: by mail-lj1-x233.google.com with SMTP id p17so15955774ljg.1 for ; Tue, 02 Jul 2019 01:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=lsQpSfPFGWxLPitCxuP5bwX+xMpLeY/HGqIJhhJWvFI=; b=s5yPjmDE4GMkllaTn8zDoJDroomAc9KYePxpLqnN/Oe/P89hH5SYJzofAZSguxyS6e ohcJCeneO8sY70ea5OApKPMSXWLikByvC8QLSZzSAPNfJhdFyApX1UUzV8Gd2OLjbKNP onevaijTuQvoJqWcZdg2K53/i7TgL1RfRn+bexIUs+5K3XjjLddFx2BVpAVPVjXrPdLC GGYvSrH02B2SDHEupzV8z0SB7ecGABh0bxLEFO7Xa0gFJ1s7HwROHZ7u/rP6JUSvg29x i4MxHPQgHPDKaayfmmjLDT9VJoq/xjEeQiWqO9QeI4iBzD/Y6MjQUF0nA13mmtjXKnDt Ax5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=lsQpSfPFGWxLPitCxuP5bwX+xMpLeY/HGqIJhhJWvFI=; b=m4fPQb6aFS+NG+9WoBCDYE+lyLKI+JM47ujErB+1Y6ERT8UvjBE/yo18nZ4SmM+Jhc 4nSGFSKOvz/TKoTAT3/Y9TfdyxFimiOyWB9ENeWNRhh27uWcydOXVM2GrWJv1CXEUrKC 43BTIbcOhz51zovAycpPWx5+BsZoFo0POB+4PuhtmAM/MqAOnvwElWyaNgjR6xdDEfH8 SsOneIyvKZ1X+fKbtkS3NECJV1c69SHUb1S8wh/YJz8HtxoqTp6e0zGf3oBQkfiNLii5 GC8qUfINhB/XLwhI3RCSDRsrP2t6hEwpEWcY4TnYuzj6hwHWWRgiu1QVf7VRzTCxBXKG 1hKQ== X-Gm-Message-State: APjAAAWPP1ddowVNPjojzDzTVWPCiZ1ykr+x6dBBaW+PlLjIzdjGEJ5R kqmQk9rTE+OAYndq0+cUTWdRrcua9MjjX5x5xxepXY1r X-Google-Smtp-Source: APXvYqzDbcS1ZoM46HKD3NpEW1wLVRlVMixHcmn90519y2RCPkm4pU1X4FTyz5g8XuuYh2Nr0PLg8byfhNGWDHiZ8YY= X-Received: by 2002:a2e:5c09:: with SMTP id q9mr16753963ljb.120.1562054884171; Tue, 02 Jul 2019 01:08:04 -0700 (PDT) MIME-Version: 1.0 From: Aditya Toshniwal Date: Tue, 2 Jul 2019 13:37:28 +0530 Message-ID: Subject: [pgAdmin][RM4421] Inno setup script version compare fix To: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000007e01cc058cae3ebc" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000007e01cc058cae3ebc Content-Type: multipart/alternative; boundary="0000000000007e01c9058cae3eba" --0000000000007e01c9058cae3eba Content-Type: text/plain; charset="UTF-8" Hi Hackers, Attached is the patch to fix a potential issue where version compare while upgrading will be incorrect. Currently, it is comparing strings. So while comparing '4.9' and '4.10' it will consider '4.9' as greater. The patch will convert the values to float and compare. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --0000000000007e01c9058cae3eba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

Attached is the patch to fix a potential issue= where version compare while upgrading will be incorrect. Currently, it is = comparing strings. So while comparing '4.9' and '4.10' it w= ill consider '4.9' as greater.
The patch will convert the values to= float and compare.

Kindly review.

--
Thanks and Regards,Aditya Toshniwal
Software Engineer |=C2= =A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"<= /font>
--0000000000007e01c9058cae3eba-- --0000000000007e01cc058cae3ebc Content-Type: application/octet-stream; name="win.ver_compare.patch" Content-Disposition: attachment; filename="win.ver_compare.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxlj3jsd0 ZGlmZiAtLWdpdCBhL3BrZy93aW4zMi9pbnN0YWxsZXIuaXNzLmluIGIvcGtnL3dpbjMyL2luc3Rh bGxlci5pc3MuaW4KaW5kZXggMjk5ZDdlMjcuLjI0NWY1ZDkzIDEwMDY0NAotLS0gYS9wa2cvd2lu MzIvaW5zdGFsbGVyLmlzcy5pbgorKysgYi9wa2cvd2luMzIvaW5zdGFsbGVyLmlzcy5pbgpAQCAt MTAzLDcgKzEwMyw4IEBAIGJlZ2luCiAgIGJlZ2luCiAJVXBncmFkZU1vZGUgOj0gVHJ1ZTsKICAg ICBSZWdRdWVyeVN0cmluZ1ZhbHVlKEhLRVlfTE9DQUxfTUFDSElORSwnU29mdHdhcmVceyNNeUFw cE5hbWV9XHsjTXlBcHBWZXJzaW9ufScsICdWZXJzaW9uJywgVmVyc2lvbik7Ci0gICAgaWYgVmVy c2lvbiA+ICd7I015QXBwRnVsbFZlcnNpb259JyB0aGVuCisgICAgLy9wZ0FkbWluIHZlcnNpb24g Y2FuIGJlIGNvbnZlcnRlZCB0byBmbG9hdCBkaXJlY3RseQorICAgIGlmIFN0clRvRmxvYXQoVmVy c2lvbikgPiBTdHJUb0Zsb2F0KCd7I015QXBwRnVsbFZlcnNpb259JykgdGhlbgogICAgIGJlZ2lu CiAgICAgICBNc2dCb3goRXhwYW5kQ29uc3RhbnQoJ3tjbTpOZXdlclZlcnNpb25FeGlzdHN9JyAr ICcodicgKyBWZXJzaW9uICsgJykgaXMgYWxyZWFkeSBpbnN0YWxsZWQnICksIG1iSW5mb3JtYXRp b24sIE1CX09LKTsKICAgICAgIFJlc3VsdCA6PSBGYWxzZTsK --0000000000007e01cc058cae3ebc--