public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Pradip Parkale <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM-7132]: Port Properties collection, Dashboard and SQL panel in React
Date: Tue, 15 Mar 2022 17:39:31 +0530
Message-ID: <CAM9w-_mnm_gk_03xONOCY7WaXmQMnww1NieuO4-KmvaFFPQRGA@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDdOUwHyUJ=-pDS94B9nX+5pRw3vZDQfMxHR-dH3d4c0CA@mail.gmail.com>
References: <CAJ9T6SsL-tzYYchh2KghWkHTY6y4L0=qCJ9VoGVCuu1WyT-0vQ@mail.gmail.com>
<CANxoLDdOUwHyUJ=-pDS94B9nX+5pRw3vZDQfMxHR-dH3d4c0CA@mail.gmail.com>
Hi Pradip,
I did some basic usage and review and found below issues:
1. The code fails if you refresh the page and go to properties, when no
node is selected.
2. I found below UI issues on selecting a database node. Also, checkbox
column is too wide.
[image: image.png]
3. Why is this in the node.js file. It should be in node_view.jsx.
+
+ ReactDOM.render(
+ <Theme>
+ <CollectionNodeView
+ node={node}
+ treeNodeInfo={treeNodeInfo}
+ item={item}
+ itemNodeData={d}
+ pgBrowser={pgBrowser}
+ ></CollectionNodeView>
+ </Theme>,
+ b.panels['properties'].panel.$container[0]
+ );
4. I have seen a lot of commented codes. Few samples:
+ // if (that.canHide) {
+ // pgBrowser.Events.off('pgadmin-browser:tree:selected', ()
=> {
+
+ // removePanelView($container[0]);
+ // });
5. In WelcomeDashboard.jsx, the complete SVG code is put. Please move it to
a file and import it.
6. Cleanup web/pgadmin/dashboard/static/js/dashboardDummy.js
7. Cleanup web/pgadmin/dashboard/static/js/dashboard_ponents.jsx
8. Rename Sql.jsx to SQL.jsx
9. The search is not working. It filters all.
10. If there is huge data then it should show some spinner.
11. Delete buttons should be disabled if no object is selected.
12. Delete buttons and search box should be on the same line.
On Tue, Mar 15, 2022 at 4:01 PM Akshay Joshi <[email protected]>
wrote:
> Hi Aditya
>
> Can you please review/test it?
>
> On Mon, Mar 14, 2022 at 7:17 PM Pradip Parkale <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for #7132
>> <https://redmine.postgresql.org/issues/7132; Port Properties collection,
>> Dashboard and SQL panel in React.
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"
Attachments:
[image/png] image.png (249.1K, 3-image.png)
download | view image
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin][RM-7132]: Port Properties collection, Dashboard and SQL panel in React
In-Reply-To: <CAM9w-_mnm_gk_03xONOCY7WaXmQMnww1NieuO4-KmvaFFPQRGA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox