public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Pradip Parkale <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM-5732] : Scan and fix accessibility issues reported by WAVE.
Date: Wed, 16 Sep 2020 11:58:35 +0530
Message-ID: <CAM9w-_mo7L_2Uceejy4e5a1k8EUkpVwOY_YWDos-ycXu_6YzFg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcb1kjCxCU4T8zv89BH4CZ=pFyoT_HSptEmHQZcf8PjLw@mail.gmail.com>
References: <CAJ9T6SsU0=zm0NrHoqXJJcNCmG9Bjv6v+39=3TuMBJSduY471g@mail.gmail.com>
<CANxoLDcb1kjCxCU4T8zv89BH4CZ=pFyoT_HSptEmHQZcf8PjLw@mail.gmail.com>
Hi,
Attached is the patch to fix a couple more fixes.
On Tue, Sep 15, 2020 at 1:20 PM Akshay Joshi <[email protected]>
wrote:
> Thanks, patch applied.
>
> On Mon, Sep 14, 2020 at 8:27 PM Pradip Parkale <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for some of the accessibility issues.
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] accessibility.sql.patch (2.2K, 3-accessibility.sql.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/static/js/database.js b/web/pgadmin/browser/server_groups/servers/databases/static/js/database.js
index f70221632..3605e1d57 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/static/js/database.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/static/js/database.js
@@ -461,6 +461,7 @@ define('pgadmin.node.database', [
id: 'schema_res', label: gettext('Schema restriction'),
type: 'select2', group: gettext('Advanced'),
mode: ['properties', 'edit', 'create'],
+ helpMessage: gettext('Note: Changes to the schema restriction will require the Schemas node in the browser to be refreshed before they will be shown.'),
select2: {
multiple: true, allowClear: false, tags: true,
tokenSeparators: [','], first_empty: false,
@@ -488,11 +489,6 @@ define('pgadmin.node.database', [
},
}),
},
- {
- id: 'note', label: gettext('Note: Changes to the schema restriction will require the Schemas node in the browser to be refreshed before they will be shown.'),
- group: gettext('Advanced'), type: 'help',
- mode: ['edit', 'create'],
- },
],
validate: function() {
var name = this.get('name');
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index cfee5dfc1..f48111b21 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -1810,15 +1810,13 @@ define([
// Use the Backform Control's render function
Backform.Control.prototype.render.apply(this, arguments);
- var field = _.defaults(this.field.toJSON(), this.defaults);
-
this.sqlCtrl = CodeMirror.fromTextArea(
(this.$el.find('textarea')[0]), {
lineNumbers: true,
mode: 'text/x-pgsql',
readOnly: true,
extraKeys: pgAdmin.Browser.editor_shortcut_keys,
- screenReaderLabel: field.label,
+ screenReaderLabel: 'SQL',
});
this.reflectPreferences();
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin][RM-5732] : Scan and fix accessibility issues reported by WAVE.
In-Reply-To: <CAM9w-_mo7L_2Uceejy4e5a1k8EUkpVwOY_YWDos-ycXu_6YzFg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox