Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWGcG-0002Aw-QR for pgadmin-hackers@arkaria.postgresql.org; Thu, 30 May 2019 08:40:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hWGcD-00083o-A2 for pgadmin-hackers@arkaria.postgresql.org; Thu, 30 May 2019 08:40:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWGcC-000833-SC for pgadmin-hackers@lists.postgresql.org; Thu, 30 May 2019 08:40:49 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWGc9-0003Be-7I for pgadmin-hackers@postgresql.org; Thu, 30 May 2019 08:40:48 +0000 Received: by mail-lj1-x22e.google.com with SMTP id y15so2024456ljd.9 for ; Thu, 30 May 2019 01:40:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fo86A39QJGrOLVFWi9IDuOj8tg12nhlKiZQhqQov8HU=; b=n186qHzAxcuh1wyptWkmc5B74JCOtPkESuNiwiS2O9DHNh5Ylhv6ygwvUGOJwfL6TZ M19Joog/3lQadxpRb5JEBG3T0XE1T7nXFU5QYxDc7u7r4PAGcaBp5wTDoUQCLFLRLwTO h4pq/LPQd4PMrOyFLZvJV3R6O9daZl4jmYXUJJwLHhFMCF6/L6eyJgbzfK3a84ouGjEM 5V260wjrsVkJV8ljAUoAX09YPAkvCcAsR64OS3iE83YG9nqZPT+wDXKABJDbD45HfYYc HYwZOw6usuqfg/S7GBnTnj8TRN2YTSIV2oY4VcoibSCR4MCDxWGQocTzKjQcZTIS1cB9 xOdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fo86A39QJGrOLVFWi9IDuOj8tg12nhlKiZQhqQov8HU=; b=fjrXgu0g2tVKSyNUEAs7gD0fgXxDtL2rVFRe3+bx2Szo+6o6eDjzpEUCZFHUJxgv1e 48PGI3Ui9MzhM755ljAHejZlS5zfclfmwgXn296vwLFSzAje0by9/Wew7MV0SU4aJkZo GyT4mJOPk3qpZ+BTEd1+1zqLcP/I2PQmDepAAz/rvANoL9Y38JZd0M3p6zBLVjMNvbCQ Govr1/dWBT+pOdalwpHDOyypqAu+bWGvtG9lbVwjZuQPFMhsVOfbawfLXIt0qB9HaOAB 3A5mylqRo2BxLBvpyCUowDhLnp52v0BqCiXeUUvhQfxkq12D80aAHpE4+qfazHqueVhG xKYA== X-Gm-Message-State: APjAAAUe1PSqzxnDnCh7HfA1/PYLO9n6YdxErUCk+E1048n3u82mUOVR dllvRBnJso0dCI+LFxgrn/Mgs7hOgVU3b7SKNLjI7w== X-Google-Smtp-Source: APXvYqwapPsAspL43yqN8De7NwhnTC1mqM6CLXIG7OB39faO1Jeais4Tpf5xj0UwSGa/WT/+d319RmMIMpQSPMRoHSw= X-Received: by 2002:a2e:8197:: with SMTP id e23mr1474631ljg.28.1559205641490; Thu, 30 May 2019 01:40:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Thu, 30 May 2019 14:10:05 +0530 Message-ID: Subject: Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility) To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000064a846058a16dab7" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000064a846058a16dab7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Thu, May 30, 2019 at 1:38 AM Dave Page wrote: > Hi > > On Tue, May 28, 2019 at 3:41 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi, >> >> On Thu, May 23, 2019 at 1:31 PM Dave Page wrote: >> >>> Hi, >>> >>> On further testing, this doesn't seem to be working as expected. >>> Alt+Shift+] or [ in the query tool are typing =E2=80=99 and =E2=80=9D a= nd not changing the >>> tab. If I switch to a non-input tab (e.g. History), they still don't wo= rk. >>> >> I am not able to simulate the quotes problem, but I have made a few >> corrections to fix the switching. >> Attached is the updated patch, kindly review. >> > > Alt+Shift+[ (or ]) don[t work at all for me now :-( > Did you restart the server after applying the patch ? What shortcut does preferences show ? > > >> >>> Alt+Shift+Tab changes the panel successfully though, and does cause the >>> flash as expected. >>> >>> I'm using Chrome 74.0.3729.131 on Mojave. >>> >>> On Wed, May 22, 2019 at 6:53 AM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Attached is the updated patch with doc changes. >>>> >>>> On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> On Tue, May 21, 2019 at 5:32 PM Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal < >>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> >>>>>>> Attached is the patch to fix the accessibility issue in query tool. >>>>>>> >>>>>>> The query tool can be completely restructured unlike previously >>>>>>> where query tool used to stick at top and other tabs in the bottom. >>>>>>> - I have added a new shortcut to switch between frames if in query >>>>>>> tool the tab positions are changed. On switching the frames, the fr= ame will >>>>>>> blink to show it is focussed. >>>>>>> - In the frame, you can switch tab same as previous. The tabs in SQ= L >>>>>>> editor are cyclic now, which means if you execute shortcut to go ri= ght on >>>>>>> the last tab then it will cycle to first tab. >>>>>>> - I have also changed the default shortcut to switch between tabs >>>>>>> from Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what we = have in >>>>>>> browser tabs. >>>>>>> - Similar changes done for debugger also. >>>>>>> >>>>>> >>>>>> Shouldn't there be documentation changes to go with this? >>>>>> >>>>> Yes, definitely :P >>>>> Will send the updated patch. >>>>> >>>>>> >>>>>> Otherwise, it seems to work :-) >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --=20 Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --00000000000064a846058a16dab7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,=C2=A0

On Thu, May 30, 2019 at 1:38 AM= Dave Page <dpage@pgadmin.org&g= t; wrote:
Hi

On Tue, May 28, 2019 at 3:41 AM Aditya Toshniwal <aditya.t= oshniwal@enterprisedb.com> wrote:
Hi,

On Thu, May 23, 2019 at 1:31 PM Dave= Page <dpage@pgad= min.org> wrote:
Hi,

On further testing, this doesn't seem to be working as expected. = Alt+Shift+] or [ in the query tool are typing=C2=A0=E2=80=99 and =E2=80=9D = and not changing the tab. If I switch to a non-input tab (e.g. History), th= ey still don't work.=C2=A0
I am no= t able to simulate the quotes problem, but I have made a few corrections to= fix the switching.
Attached is the updated patch, kindly revi= ew.=C2=A0

Alt+Shif= t+[ (or ]) don[t work at all for me now :-(
<= div>= Did you restart the server after applying the patch ?=C2=A0 What shortcut d= oes preferences show ?=C2=A0
=C2=A0

Alt+Shif= t+Tab changes the panel successfully though, and does cause the flash as ex= pected.=C2=A0

I'm using Chrome=C2=A074.0.3729.= 131 on Mojave.

On Wed, May 22, 2019 at 6:53 AM Aditya Tosh= niwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

Attached is = the updated patch with doc changes.

On Tue, May 21, 2019 at 5:42 PM Ad= itya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

<= div class=3D"gmail_quote">
On Tue, May= 21, 2019 at 5:32 PM Dave Page <dpage@pgadmin.org> wrote:
Hi
=
On Tue= , May 21, 2019 at 10:01 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.c= om> wrote:
Hi Hackers= ,

=
Attached is the patch t= o fix the accessibility issue in query tool.

The query tool can be completely restructured unlike previously where que= ry tool used to stick at top and other tabs in the bottom.=C2=A0
- I have added a new shortcut to s= witch between frames if in query tool the tab positions are changed. On swi= tching the frames, the frame will blink to show it is focussed.=C2=A0
=
- In the frame, you can switc= h tab same as previous. The tabs in SQL editor are cyclic now, which means = if you execute shortcut to go right on the last tab then it will cycle to f= irst tab.
- I have also = changed the default shortcut to switch between tabs from Shift+Ctrl+ArrowKe= ys to Shift+Ctrl+[ and ] similar to what we have in browser tabs.
- Similar changes done for debugg= er also.

Shouldn't there be= documentation changes to go with this?=C2=A0
Yes, definitely :P
Will send the updated patch.=C2= =A0

Otherwise, it seems to work= :-)

--
Dave Page
Blog: http://pgsnake.blogspot.comTwitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise= PostgreSQL Company


--
Thanks and Reg= ards,
Aditya Toshniwal
Software= Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant= a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0Enterpri= seDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twit= ter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Post= greSQL Company


--
Thanks and Regards= ,
Aditya Toshniwal
Software E= ngineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a= TREE"


--
Dave Page
Blog: <= a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blo= gspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company


--
Adi= tya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"
--00000000000064a846058a16dab7--