Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ieZvi-0000hN-99 for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 Dec 2019 07:27:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ieZvf-0003q5-Ts for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 Dec 2019 07:27:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ieZvf-0003py-9v for pgadmin-hackers@lists.postgresql.org; Tue, 10 Dec 2019 07:27:31 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ieZvZ-00067z-BY for pgadmin-hackers@postgresql.org; Tue, 10 Dec 2019 07:27:29 +0000 Received: by mail-ed1-x52c.google.com with SMTP id dc19so15028026edb.10 for ; Mon, 09 Dec 2019 23:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PU+bllAmIpwTezZZkVzfHJQGCWudDOoI+G8Gi4DVdqE=; b=rySJIzDMfogO+d1hrP3gky8vSO1Y+eHkQGaC7+5ewkiNZT7ich21aIyZVjR+BhcGIl BFNQdDsUFrDOFo2/lALn7uZ0SE5M1hJ8YnLjSDIcTUDqUAhipIuOi66FRyDkdyx/Jwtb mxaItXyURbIi1evNoeVI/NNgKSQAgUtzi1Cljgpa5Eh8cJ90bZYUwTNf9aRgFdGS7Z61 coiWWMdYV9lpFjmBLgjFFLhBcT9/mYztv7fWUdaTHBUFo5QnO1w71GF2UJITv3V55ByC gEMpu/txuPxfckUNEnI2m/z2bneq0UQsHE67TQQWuYPAhqf3sbxkfX8Tu/3o9YxMuRO8 XHTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PU+bllAmIpwTezZZkVzfHJQGCWudDOoI+G8Gi4DVdqE=; b=DUxgFdrVmUo7Xpou5oBwJJLQJTQVH4bTVYf3cLCSFCWg62SKEz3aQUNyVGp4v30CwP JKhUzD3kVdqb9O3r6nPc9uo5ycgRkSPxgDWxOJb9re33Xpep1ccH4f4xygx70wExzTMl JeqawuXrQWCA37DSOvrb+jjYV3TqrfAM+wl4cUXl1PbUhVaNY+oAnf45ryrDs6LZfT1B 44kKVQDRQbr2ZyHuIKPifnu9kfsys9tlWZkx13nI87KQygOW3exkCzhiKXk4RUJxkGwF 3D44/suTT5vbEITUnQKzzUMhsrH2YQ0uRwbodhomXt3o0h7ZsO7mHZdMxwxSDsMa6qzF pBUA== X-Gm-Message-State: APjAAAWCbbzr5ov85mJfpCidLXvnAMX9xLvFS+zQXliieXJlahZ7kRrK a/NWVzsiQjqrVqRtye2YHHKAeyl3GBzu5bsfIQlLbiAV+9rE288oq7CNZwr3xfxm1VEHvPZSPw6 ADATjaU6i7mZknkny1WLvx2LshRRMO8wIM6FZ6uDURmqenjvg+AHd/O8xTavs6DvwTS8eVXfzy+ GKCytzlGSia4NlSGgbRbAWp/1eDSuv2KOoSZV4j9/jCAINWeMGSJ/f6g== X-Google-Smtp-Source: APXvYqwX0oJsv3ekRBKIf/le5hRBbHED5oa71i0FHhCKdXYH90aimrrYLgKnhG9uuA1jGsEHQyCVsk7hXjwdu0MLX0g= X-Received: by 2002:a17:906:3718:: with SMTP id d24mr2080296ejc.14.1575962842658; Mon, 09 Dec 2019 23:27:22 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Tue, 10 Dec 2019 12:56:46 +0530 Message-ID: Subject: Re: [pgAdmin][RM4506] "can't execute an empty query" message displayed if user remove fill factor of any existing table To: pgadmin-hackers Cc: Akshay Joshi Content-Type: multipart/mixed; boundary="0000000000006bf84405995471c5" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000006bf84405995471c5 Content-Type: multipart/alternative; boundary="0000000000006bf83d05995471c3" --0000000000006bf83d05995471c3 Content-Type: text/plain; charset="UTF-8" Hi Hackers, Attached is the updated patch. The modified SQL missed the reset clause for FILLFACTOR. That's added now. I've changed the int/numeric field validation to disallow spaces in the form field. Currently, fill factor allows spaces and fails while saving as "invalid value". Also, added min and max for fill factor in Mview dialog. All the test cases are passing. Kindly review. On Mon, Dec 9, 2019 at 4:30 PM Akshay Joshi wrote: > Hi Aditya > > The issue has not been resolved. Remove fill factor it won't generate > MSQL. Please verify and fix it. > > On Mon, Dec 9, 2019 at 3:33 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix an issue where just clicking on an >> empty textbox like fill factor in tables dialog considers it a change and >> so the save button is enabled. >> The fix is common will apply at other places also. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --0000000000006bf83d05995471c3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

Attached is the updated patch. The modifie= d SQL missed the=C2=A0reset clause for FILLFACTOR. That's added now.
I&= #39;ve changed the int/numeric field validation to disallow spaces in the f= orm field. Currently,=C2=A0 fill factor allows spaces and fails while savin= g as "invalid value".
Also, added min and max for fill factor in = Mview dialog.

All the test cases are passing. Kindly review.


On Mon, Dec 9, 2019 at 4:30 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2= =A0Aditya

The issue has not=C2=A0been resolved. Remove f= ill factor it won't generate MSQL. Please verify and fix it.=C2=A0

On Mon, Dec 9, 2019 at 3:33 PM Aditya Toshniwal <aditya.toshniwal@enterpris= edb.com> wrote:
Hi Hackers,

Attached is the patch to fix an issue w= here just clicking on an empty=C2=A0textbox like fill factor in tables dial= og considers it a change and so the save button is enabled.
The fix is comm= on will apply at other places also.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India= |=C2=A0Pune
&q= uot;Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB In= dia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"
=
--0000000000006bf83d05995471c3-- --0000000000006bf84405995471c5 Content-Type: application/octet-stream; name="RM4506_v2.patch" Content-Disposition: attachment; filename="RM4506_v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k3zjk8640 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh dGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0ZXMvdGFibGVzL3NxbC8xMl9wbHVzL3VwZGF0 ZS5zcWwgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFz ZXMvc2NoZW1hcy90YWJsZXMvdGVtcGxhdGVzL3RhYmxlcy9zcWwvMTJfcGx1cy91cGRhdGUuc3Fs CmluZGV4IGQxMmE4Mzg1MS4uODA0NjIwODk4IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93 c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90YWJsZXMvdGVtcGxh dGVzL3RhYmxlcy9zcWwvMTJfcGx1cy91cGRhdGUuc3FsCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dz ZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0 ZXMvdGFibGVzL3NxbC8xMl9wbHVzL3VwZGF0ZS5zcWwKQEAgLTU2LDYgKzU2LDkgQEAgQUxURVIg VEFCTEUge3tjb25ufHF0SWRlbnQoZGF0YS5zY2hlbWEsIGRhdGEubmFtZSl9fQogeyUgaWYgZGF0 YS5maWxsZmFjdG9yIGFuZCBkYXRhLmZpbGxmYWN0b3IgIT0gb19kYXRhLmZpbGxmYWN0b3IgJX0K IEFMVEVSIFRBQkxFIHt7Y29ubnxxdElkZW50KGRhdGEuc2NoZW1hLCBkYXRhLm5hbWUpfX0KICAg ICBTRVQgKEZJTExGQUNUT1I9e3tkYXRhLmZpbGxmYWN0b3J9fSk7Cit7JSBlbGlmIGRhdGEuZmls bGZhY3RvciA9PSAnJyBhbmQgZGF0YS5maWxsZmFjdG9yICE9IG9fZGF0YS5maWxsZmFjdG9yICV9 CitBTFRFUiBUQUJMRSB7e2Nvbm58cXRJZGVudChkYXRhLnNjaGVtYSwgZGF0YS5uYW1lKX19Cisg ICAgUkVTRVQgKEZJTExGQUNUT1IpOwogCiB7JSBlbmRpZiAlfQogeyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyN9CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9n cm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90YWJsZXMvdGVtcGxhdGVzL3RhYmxlcy9z cWwvZGVmYXVsdC91cGRhdGUuc3FsIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBz L3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL3RlbXBsYXRlcy90YWJsZXMvc3FsL2Rl ZmF1bHQvdXBkYXRlLnNxbAppbmRleCBjOGJmNmRiOTQuLjU2NzNjZmY3MyAxMDA2NDQKLS0tIGEv d2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVt YXMvdGFibGVzL3RlbXBsYXRlcy90YWJsZXMvc3FsL2RlZmF1bHQvdXBkYXRlLnNxbAorKysgYi93 ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1h cy90YWJsZXMvdGVtcGxhdGVzL3RhYmxlcy9zcWwvZGVmYXVsdC91cGRhdGUuc3FsCkBAIC02NCw2 ICs2NCw5IEBAIEFMVEVSIFRBQkxFIHt7Y29ubnxxdElkZW50KGRhdGEuc2NoZW1hLCBkYXRhLm5h bWUpfX0KIHslIGlmIGRhdGEuZmlsbGZhY3RvciBhbmQgZGF0YS5maWxsZmFjdG9yICE9IG9fZGF0 YS5maWxsZmFjdG9yICV9CiBBTFRFUiBUQUJMRSB7e2Nvbm58cXRJZGVudChkYXRhLnNjaGVtYSwg ZGF0YS5uYW1lKX19CiAgICAgU0VUIChGSUxMRkFDVE9SPXt7ZGF0YS5maWxsZmFjdG9yfX0pOwor eyUgZWxpZiBkYXRhLmZpbGxmYWN0b3IgPT0gJycgYW5kIGRhdGEuZmlsbGZhY3RvciAhPSBvX2Rh dGEuZmlsbGZhY3RvciAlfQorQUxURVIgVEFCTEUge3tjb25ufHF0SWRlbnQoZGF0YS5zY2hlbWEs IGRhdGEubmFtZSl9fQorICAgIFJFU0VUIChGSUxMRkFDVE9SKTsKIAogeyUgZW5kaWYgJX0KIHsj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjfQpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4v YnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdmlld3Mvc3Rh dGljL2pzL212aWV3LmpzIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZl cnMvZGF0YWJhc2VzL3NjaGVtYXMvdmlld3Mvc3RhdGljL2pzL212aWV3LmpzCmluZGV4IDZkM2Rm YmMwNS4uNzdmNWQ2YjYwIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9n cm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy92aWV3cy9zdGF0aWMvanMvbXZpZXcuanMK KysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2Vz L3NjaGVtYXMvdmlld3Mvc3RhdGljL2pzL212aWV3LmpzCkBAIC0yMDMsNyArMjAzLDcgQEAgZGVm aW5lKCdwZ2FkbWluLm5vZGUubXZpZXcnLCBbCiAgICAgICAgIH0sewogICAgICAgICAgIGlkOiAn ZmlsbGZhY3RvcicsIGxhYmVsOiBnZXR0ZXh0KCdGaWxsIGZhY3RvcicpLAogICAgICAgICAgIGdy b3VwOiBnZXR0ZXh0KCdTdG9yYWdlJyksIG1vZGU6IFsnZWRpdCcsICdjcmVhdGUnXSwKLSAgICAg ICAgICB0eXBlOiAnaW50JywKKyAgICAgICAgICB0eXBlOiAnaW50JywgbWluOiAxMCwgbWF4OiAx MDAsCiAgICAgICAgIH0sewogICAgICAgICAgIHR5cGU6ICduZXN0ZWQnLCBjb250cm9sOiAndGFi JywgaWQ6ICdtYXRlcmlhbGl6YXRpb24nLAogICAgICAgICAgIGxhYmVsOiBnZXR0ZXh0KCdQYXJh bWV0ZXInKSwgbW9kZTogWydlZGl0JywgJ2NyZWF0ZSddLApkaWZmIC0tZ2l0IGEvd2ViL3BnYWRt aW4vYnJvd3Nlci9zdGF0aWMvanMvZGF0YW1vZGVsLmpzIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9z dGF0aWMvanMvZGF0YW1vZGVsLmpzCmluZGV4IDUxNGM0MDM5Mi4uNTY0ZjdmMmM5IDEwMDY0NAot LS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9kYXRhbW9kZWwuanMKKysrIGIvd2Vi L3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvanMvZGF0YW1vZGVsLmpzCkBAIC0zNjcsNyArMzY3LDgg QEAgZGVmaW5lKFsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICB9CiAgICAgICAgICAg YXR0cnNba10gPSB2OwotICAgICAgICAgIGlmIChfLmlzRXF1YWwoc2VsZi5vcmlnU2Vzc0F0dHJz W2tdLCB2KSkgeworICAgICAgICAgIC8qIElmIHRoZSBvcmlnIHZhbHVlIHdhcyBudWxsIGFuZCBu ZXcgb25lIGlzIGVtcHR5IHN0cmluZywgdGhlbiBpdHMgYSAibm8gY2hhbmdlIiAqLworICAgICAg ICAgIGlmIChfLmlzRXF1YWwoc2VsZi5vcmlnU2Vzc0F0dHJzW2tdLCB2KSB8fCAoc2VsZi5vcmln U2Vzc0F0dHJzW2tdID09PSBudWxsICYmIHYgPT09ICcnKSkgewogICAgICAgICAgICAgZGVsZXRl IHNlbGYuc2Vzc0F0dHJzW2tdOwogICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBzZWxm LnNlc3NBdHRyc1trXSA9IHY7CkBAIC03MzgsOSArNzM5LDcgQEAgZGVmaW5lKFsKICAgICAgICAg ZmllbGQgPSB0aGlzLmZpZWxkRGF0YVtrZXlzW2ldXTsKICAgICAgICAgbXNnID0gbnVsbDsKIAot ICAgICAgICBpZiAoIShfLmlzVW5kZWZpbmVkKHZhbHVlKSB8fCBfLmlzTnVsbCh2YWx1ZSkgfHwK LSAgICAgICAgICAgIFN0cmluZyh2YWx1ZSkucmVwbGFjZSgvXlxzK3xccyskL2csICcnKSA9PSAn JykpIHsKLQorICAgICAgICBpZiAoIShfLmlzVW5kZWZpbmVkKHZhbHVlKSB8fCBfLmlzTnVsbCh2 YWx1ZSkgfHwgU3RyaW5nKHZhbHVlKSA9PT0gJycpKSB7CiAgICAgICAgICAgaWYgKCFmaWVsZCkg ewogICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvd2ViL3Bn YWRtaW4vYnJvd3Nlci90ZW1wbGF0ZXMvYnJvd3Nlci9qcy9tZXNzYWdlcy5qcyBiL3dlYi9wZ2Fk bWluL2Jyb3dzZXIvdGVtcGxhdGVzL2Jyb3dzZXIvanMvbWVzc2FnZXMuanMKaW5kZXggNzYyMWNh M2FlLi40MTMwMWM0ZmMgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVtcGxhdGVz L2Jyb3dzZXIvanMvbWVzc2FnZXMuanMKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci90ZW1wbGF0 ZXMvYnJvd3Nlci9qcy9tZXNzYWdlcy5qcwpAQCAtMjYsOCArMjYsOCBAQCBkZWZpbmUoCiAgICAg J1NRTF9OT19DSEFOR0UnOiBnZXR0ZXh0KCdOb3RoaW5nIGNoYW5nZWQnKSwKICAgICAnTVVTVF9C RV9JTlQnIDogZ2V0dGV4dCgiJyVzJyBtdXN0IGJlIGFuIGludGVnZXIuIiksCiAgICAgJ01VU1Rf QkVfTlVNJyA6IGdldHRleHQoIiclcycgbXVzdCBiZSBhIG51bWVyaWMuIiksCi0gICAgJ01VU1Rf R1JfRVEnIDogZ2V0dGV4dCgiJXMnIG11c3QgYmUgZ3JlYXRlciB0aGFuIG9yIGVxdWFsIHRvICVk LiIpLAotICAgICdNVVNUX0xFU1NfRVEnIDogZ2V0dGV4dCgiJyVzJyBtdXN0IGJlIGxlc3MgdGhh biBvciBlcXVhbCB0byAlZC4iKSwKKyAgICAnTVVTVF9HUl9FUScgOiBnZXR0ZXh0KCInJXMnIG11 c3QgYmUgZ3JlYXRlciB0aGFuIG9yIGVxdWFsIHRvICVzLiIpLAorICAgICdNVVNUX0xFU1NfRVEn IDogZ2V0dGV4dCgiJyVzJyBtdXN0IGJlIGxlc3MgdGhhbiBvciBlcXVhbCB0byAlcy4iKSwKICAg ICAnU1RBVElTVElDU19MQUJFTCc6IGdldHRleHQoIlN0YXRpc3RpY3MiKSwKICAgICAnU1RBVElT VElDU19WQUxVRV9MQUJFTCc6IGdldHRleHQoIlZhbHVlIiksCiAgICAgJ05PREVfSEFTX05PX1NR TCc6IGdldHRleHQoIk5vIFNRTCBjb3VsZCBiZSBnZW5lcmF0ZWQgZm9yIHRoZSBzZWxlY3RlZCBv YmplY3QuIiksCg== --0000000000006bf84405995471c5--