public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Anil Sahoo <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Regarding feature #3319
Date: Tue, 20 Aug 2024 10:14:04 +0530
Message-ID: <CAM9w-_n-Uh=rvV6CTESUnoiiUaUa2vxao7SJBVrrv1E0uMWRpQ@mail.gmail.com> (raw)
In-Reply-To: <CAO+oWtDjAydE7p8XSj4pW3WnXtgdoB+vQxC5AxsfdTsaVBRwbw@mail.gmail.com>
References: <CAO+oWtC0aHG_7D69OiHvjHfpt9fJt=Q0LhPu_2oLCD71c1QORw@mail.gmail.com>
<CA+OCxoz=3WbRzir+sP9qba97Tn4YrRV0bq5CFcVNtFsNKZ+5Lw@mail.gmail.com>
<CAO+oWtAS2D3G_+rTOn2iY0HJLkJMjr2D6WNui+X8jZ_CSGiT_w@mail.gmail.com>
<CAM9w-_=Y4ht5P9-PeDz++Sk5EAKU9jKkvTTNBU+mQEzWo0BoPw@mail.gmail.com>
<CAO+oWtDjAydE7p8XSj4pW3WnXtgdoB+vQxC5AxsfdTsaVBRwbw@mail.gmail.com>
Hi Anil,
There can be multiple query tools open with large files. Not entirely sure
if storing in SQLite DB is a good idea.
External databases won't come in the picture as 99.99% users will not use
external DB for desktop app. We're only doing this for desktop app.
And also consider the case where a SQL file is opened with some unsaved
changes.
On Tue, Aug 20, 2024 at 9:11 AM Anil Sahoo <[email protected]>
wrote:
> Hi Aditya,
>
> As we are already storing the query history in the pgAdmin 4's database
> file.
> I am planning to store the information the same way. That can be an
> internal database file like SQLite or external database.
>
> Let me know if you all have any suggestions on this.
>
> Thanks
> Anil
> --
>
> <http://www.enterprisedb.com;
>
> *Anil Sahoo*
>
> Software Engineer
>
> www.enterprisedb.com
>
> Power to Postgres
>
> <https://www.linkedin.com/company/edbpostgres;
> <https://twitter.com/edbpostgres?lang=en;
> <https://www.facebook.com/EDBpostgres;
> <https://www.instagram.com/EDBpostgres/;
>
>
> On Mon, Aug 19, 2024 at 11:40 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Anil,
>>
>> On Mon, Aug 12, 2024 at 3:02 PM Anil Sahoo <[email protected]>
>> wrote:
>>
>>> Hi,
>>>
>>> Yes, We will store the details that are needed to re-establish the
>>> connection.
>>>
>>
>> How/Where are you planning to store the information? Query text could be
>> large.
>>
>>>
>>> Regards
>>> Anil
>>> --
>>>
>>> <http://www.enterprisedb.com;
>>>
>>> *Anil Sahoo*
>>>
>>> Software Engineer
>>>
>>> www.enterprisedb.com
>>>
>>> Power to Postgres
>>>
>>> <https://www.linkedin.com/company/edbpostgres;
>>> <https://twitter.com/edbpostgres?lang=en;
>>> <https://www.facebook.com/EDBpostgres;
>>> <https://www.instagram.com/EDBpostgres/;
>>>
>>>
>>> On Mon, Aug 12, 2024 at 2:08 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Mon, 12 Aug 2024 at 06:50, Anil Sahoo <[email protected]>
>>>> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>>
>>>>> This feature #3319
>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/3319;, demands the
>>>>> Workspace and the Query tool panel to be saved before exiting the
>>>>> application and on restart it will show earlier opened panels.
>>>>>
>>>>>
>>>>> We are already saving the Browser layout, Query tool layout and the
>>>>> Object explorer tree state but to save the contents of panels we will
>>>>> initially start with the Query tool. The below implementation will be done,
>>>>>
>>>>> 1. Store the query tool panels and the list of connections present
>>>>> in each query tool panel and the active connection
>>>>> 2. Store the query that is written in the editor
>>>>> 3. Store the contents of scratch pad
>>>>>
>>>>> The main reason that this has never been worked on is that there is no
>>>> way to restore the state of a connection to what it was and be sure we've
>>>> got it right. How do you propose to handle that? I assume in a similar way
>>>> to the warnings we give if a connection has to be re-established?
>>>>
>>>>>
>>>>>
>>>>>
>>>>> We will use debouncing to store the workspace data and all other data
>>>>> related to panels in the pgAdmin 4's configured database file. Through
>>>>> debouncing we will be able to call the API at certain intervals of user
>>>>> interaction, and it will update the stored data related to workspace and
>>>>> all other panels.
>>>>>
>>>>
>>>> OK.
>>>>
>>>> --
>>>> Dave Page
>>>> pgAdmin: https://www.pgadmin.org
>>>> PostgreSQL: https://www.postgresql.org
>>>> EDB: https://www.enterprisedb.com
>>>>
>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>
>>>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>> <https://www.enterprisedb.com/;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Regarding feature #3319
In-Reply-To: <CAM9w-_n-Uh=rvV6CTESUnoiiUaUa2vxao7SJBVrrv1E0uMWRpQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox