Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glo68-00045X-JN for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 04:55:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1glo65-0004d8-Kn for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 04:55:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glo65-0004cZ-Es for pgadmin-hackers@lists.postgresql.org; Tue, 22 Jan 2019 04:55:37 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glo62-0008Kv-2r for pgadmin-hackers@postgresql.org; Tue, 22 Jan 2019 04:55:36 +0000 Received: by mail-lf1-x129.google.com with SMTP id n18so17074856lfh.6 for ; Mon, 21 Jan 2019 20:55:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3K0wjrZcimOeqIjIQlfvD6UQ6/EX2LVFQWmvTDVat/0=; b=P2Fya7+O+3CZ7f01l++nPpP2U84va84asi5Ojz2R3gg7nl/5MzGRumKw+mHqfLDu2+ bDocMhQsZykeN8wKaRYo18l6aq20QmRVTF9A9gj2aJX7GhQsskqVDeIqE1exE8iFS60f Osd7l6EHCAXAHa6rHAtDt+OxzlKVBRtNTHnxlcQ2ogk+hfctoPzLrfI/AjXL//wV6css +ybjnoYL6AI0conRNBWQPxrGlBWuQ87MzMkabRubr568TFTGbyptj4AN4HhsvfvNltKv mfzHueZrqjbkYkr5vULtd5yc1uHfaqFwI7TvWxwnnx/sL+vOJQM3LDbh/PreDSa2PV1w +h5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3K0wjrZcimOeqIjIQlfvD6UQ6/EX2LVFQWmvTDVat/0=; b=uL9LW4um9kkfslTog7VWCexA8cLbBc8sLXZCSOmRdeosFyq1CrJRB0Bt8yceIx2ToG HQRzYyur+52rHc5tPeZ9Qk+ov0TfD6P9/B6j/58na4kCWP02FdP/2OlGYe7kxvRDs8BT 7gyOJKyjC9COXHKSWnXV8nu/gFVS8+ULx4vRuMDNqneipCSmkQg6fK91Dllf/xGn2QVw UcZq/EsIWUBeeZvzSRDls8bpdgettYmYSTrPDlOh7UM21Dp+bxB1Oy/po6WG7NShiiHi 1GW108LDeUwYiKeThD56wgyYQyZeQS6ydBu0tz7jIhZLL+qhYw8PBFCscDSfTMaC+yXh TSYg== X-Gm-Message-State: AJcUukfk7MpUUXxZNI8N55hsyKlFWgwT+i+S81GrC0+C9Fs7g96reaIu eqftyZmN20aLe8yLfY0iriJfLuyu4HpWYJCaMwiusg== X-Google-Smtp-Source: ALg8bN5NKPw2gvda5jEjwulJDfp1QzFURwkHMnOue/yOXquKZPIsc3EGdV58XMj2kmwzaLkrqcZwoewKKKveX76Bzzw= X-Received: by 2002:a19:d04d:: with SMTP id h74mr19159376lfg.52.1548132932745; Mon, 21 Jan 2019 20:55:32 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Tue, 22 Jan 2019 10:25:21 +0530 Message-ID: Subject: Re: Remove hacky way to open/close the dropdown-submenu To: Ashesh Vashi Cc: "khushboo.vashi" , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000008595a5058004c94c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000008595a5058004c94c Content-Type: text/plain; charset="UTF-8" Hi Ashesh, I am getting a syntax error on bundle. After fixing that, please look into this scenario: Using keyboard shortcuts open object menu, for eg on table node. Go to any submenu using keyboard and go to any submenu and press enter. Now open object menu again using keyboard shortcut, the submenu remains open. It should be closed. Everything looks fine to me except the above. On Tue, Jan 22, 2019 at 10:07 AM Ashesh Vashi wrote: > Any update? > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > > On Thu, Jan 17, 2019 at 7:39 PM Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Hi Aditya/Khushboo, >> >> I can see a hacky way to open/close the dropdown-submenu in the menu.js >> file. >> I've followed a more general way to open/close any submenu in the >> dropdown list, instead of just 'Objects' menu. >> >> Can you please review it, and let me know your thoughts? >> Let me know if you have any other better approach. >> >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --0000000000008595a5058004c94c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ashesh,

I am getting a syntax error on bundle.=C2=A0
Af= ter fixing that,=C2=A0 please look=C2=A0into this scenario:
Using keyboard = shortcuts open object menu, for eg on table node. Go to any submenu using k= eyboard and go to any submenu and press enter.
Now open object menu again u= sing keyboard shortcut, the submenu remains open. It should be closed.

=
Everything looks fine to me except the above.


On Tue, Jan 22= , 2019 at 10:07 AM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Any update?

--

Thanks & Reg= ards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Po= stgreSQL Company


http://www.linkedin.com/in/asheshvashi



On Th= u, Jan 17, 2019 at 7:39 PM Ashesh Vashi <ashesh.vashi@enterprisedb.com> w= rote:
Hi Aditya/Khushboo,

I can see a hacky way to op= en/close the dropdown-submenu in the menu.js file.
I've follo= wed a more general way to open/close any submenu in the dropdown list, inst= ead of just 'Objects' menu.

Can you please= review it, and let me know your thoughts?
Let me know if you hav= e any other better approach.
=C2=A0

--=

Thanks= & Regards,

Ashesh Vashi
EnterpriseDB = INDIA: Ent= erprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi



--
Thanks and Rega= rds,
Aditya Toshniwa= l
Softw= are Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
&q= uot;Don't Complain about Heat, Plant a tree"
--0000000000008595a5058004c94c--