public inbox for [email protected]  

help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][RM3679] Query Tool not working
Date: Thu, 3 Jan 2019 13:06:49 +0530
Message-ID: <CAM9w-_n1z8P2mW8=nQXqwVFqA=89wk=-dAgw-C_izb6-2MYGQQ@mail.gmail.com> (raw)

Hi Hackers,

This is related to a very difficult to reproduce issue where query tool
opens blank. Note the disconnected icon, not to be confused with another
issue where resizing the query tool works and icon is connected.
Somehow, this occurred on my system (screenshot attached). It turned out to
be a webpack issue and many users are facing this (in other projects).
A workaround suggested by
https://github.com/webpack/webpack/issues/6094#issuecomment-413178158 is
applied in the attached patch.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


Attachments:

  [image/png] Screenshot 2019-01-03 at 12.17.45 PM.png (477.7K, 3-Screenshot%202019-01-03%20at%2012.17.45%20PM.png)
  download | view image

  [application/octet-stream] RM3679.patch (715B, 4-RM3679.patch)
  download | inline diff:
diff --git a/web/webpack.config.js b/web/webpack.config.js
index 2e214fc7..10ae9969 100644
--- a/web/webpack.config.js
+++ b/web/webpack.config.js
@@ -19,7 +19,10 @@ const webpackShimConfig = require('./webpack.shim');
 const PRODUCTION = process.env.NODE_ENV === 'production';
 const OptimizeCssAssetsPlugin = require('optimize-css-assets-webpack-plugin');
 const ExtractTextPlugin = require('extract-text-webpack-plugin');
-const extractStyle = new ExtractTextPlugin('[name].css');
+const extractStyle = new ExtractTextPlugin({
+  filename: '[name].css',
+  allChunks: true,
+});
 const envType = PRODUCTION ? 'production': 'development';
 const HardSourceWebpackPlugin = require('hard-source-webpack-plugin');
 

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][RM3679] Query Tool not working
  In-Reply-To: <CAM9w-_n1z8P2mW8=nQXqwVFqA=89wk=-dAgw-C_izb6-2MYGQQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox