Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gluLD-000399-Nx for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 11:35:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gluLC-0006ny-Es for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 11:35:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gluLC-0006nT-5I for pgadmin-hackers@lists.postgresql.org; Tue, 22 Jan 2019 11:35:38 +0000 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gluL9-0003ty-Ic for pgadmin-hackers@postgresql.org; Tue, 22 Jan 2019 11:35:37 +0000 Received: by mail-lj1-x22b.google.com with SMTP id g11-v6so20298123ljk.3 for ; Tue, 22 Jan 2019 03:35:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U6cMvoQxHJvLn+5h2ZvYJ4Jt9wqsNh+8s8hgjr+Qbzo=; b=ibIg0jeEBkUuz5KoMdxNl96ofKELE/1oNuIho7iRlCu5feJr730FAIVHdqXqWgCWUI 9YQRnygWhTku8wH1c+CWwSdrUcKf3Axly1aJaj+gfOpk4Z/uh0zFTyX6Rn1Y7KzUCLO+ RbnQkAU4VPKrF6G6q3p7eN4WNwkcdSPrK+lXe2gOWB6o4E2XCzt9MoqdPLrlj6ytVyxI xTIrpq3tLJG0A2Jdo43J9lCPOIujANHKDy07smbh+KxIER6fNB+z7Y9dizfItRQmR3Nd LZw/KWXWFJK3MlsidjEToafjY7s9t+ijv1OquCF7WZs/MCjNsvRXvfcU6wpL7GanzzKY FCOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U6cMvoQxHJvLn+5h2ZvYJ4Jt9wqsNh+8s8hgjr+Qbzo=; b=Q7kirywxXuAOijgN4fUvIInDKnTTFQYW8/QvksYoIt9W+NbT/VtQg/+Jz7ULUR1fcl RWXgOGocKSgrTF/myV04DJs3W/OFdYiHfHufBXEyu0+cU8eqle0rqAdMftM5nr2GICas YvmuSO913LJPoC9nxbOVTLCnlEkWdZcrxNRmxfSt57JRy9B795xHpCTrWpSwFXtWBeea bf/eER8xmJj/9Fh7Dtnhs2Qu8UHjHMTfFD6W9xsdOXNGq6qlJW96W1VHlFegtqCrPPC4 NjXq7OGpN0UxIbR1WT+9pmAOzfYD9+WmPxCkWv3L7INEmU42Kq6+X8ziZ245yZU7vp8C dc+g== X-Gm-Message-State: AJcUukfGSRXr8z4F3I1ONkKtzp5yw0s9fnc9FtzrMFP5yyG4VCKFKCaW t51x4bDPQBr9KDdI5+kPHDgfCrm4IHs1lxDUTcPnTQ== X-Google-Smtp-Source: ALg8bN4vHXPzLdl8+twoRaVvBpWxLS+TElVvqfwYxI7kDjKFz6KsWPYexirjHnyuZFzo30jHykTa7sWkwNctZIrVUKo= X-Received: by 2002:a2e:2c02:: with SMTP id s2-v6mr2647476ljs.118.1548156934021; Tue, 22 Jan 2019 03:35:34 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Tue, 22 Jan 2019 17:05:21 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000001c26ff05800a60c7" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001c26ff05800a60c7 Content-Type: text/plain; charset="UTF-8" Hi Khushboo, There is improvement than before but the UI still lags. I tested with 2000 tables and statistics on Tables node. I would also suggest to add further rows only if scrolling down. Rows adding can be avoided even if the scroll does not take to the last element. Currently, if I scroll slightly down it add rows and if I scroll back up it adds more. I think the scroll up fetch can be avoided. On Mon, Jan 21, 2019 at 4:43 PM Akshay Joshi wrote: > Hi Aditya > > Can you please review it. > > On Thu, Jan 17, 2019 at 11:36 AM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the RM 3664 - Statistic panel hangs >> when 1000+ tables >> >> The statistics tab hangs with more rows. So, now the rows will be pushed >> in the backgrid collection in bunches on scroll event to fix this issue. >> >> Thanks, >> Khushboo >> > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --0000000000001c26ff05800a60c7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Khushboo,

There is improvement than before but the UI s= till lags. I tested with 2000 tables and statistics on Tables node.
I would= also suggest to add further rows only if scrolling down. Rows adding can b= e avoided even if the scroll does not take to the last element.
Currently, = if I scroll slightly down it add rows and if I scroll back up it adds more.= I think the scroll up fetch can be avoided.

On Mon, Jan 21, 2019 at 4= :43 PM Akshay Joshi <ak= shay.joshi@enterprisedb.com> wrote:
Hi Aditya=C2=A0

<= div>Can you please review it.

On Thu, Jan = 17, 2019 at 11:36 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> w= rote:
Hi,

Please find the attached patch to fix the R= M 3664 - Statistic panel hangs when 1000+ tables

T= he statistics tab hangs with more rows. So, now the rows will be pushed in = the backgrid collection in bunches on scroll event to fix this issue.
=

Thanks,
Khushboo


--
Akshay Joshi
Sr. Software Architect
<= div>

Phone: +91 20-3058-9517
Mobi= le: +91 976-788-8246


--
Thanks and Rega= rds,
Aditya Toshniwa= l
Softw= are Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
&q= uot;Don't Complain about Heat, Plant a tree"
--0000000000001c26ff05800a60c7--