Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go2oJ-00028i-Ob for pgadmin-hackers@arkaria.postgresql.org; Mon, 28 Jan 2019 09:02:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1go2oG-0007pG-BS for pgadmin-hackers@arkaria.postgresql.org; Mon, 28 Jan 2019 09:02:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go2oG-0007p8-5j for pgadmin-hackers@lists.postgresql.org; Mon, 28 Jan 2019 09:02:28 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go2o8-0006Fy-Hn for pgadmin-hackers@postgresql.org; Mon, 28 Jan 2019 09:02:27 +0000 Received: by mail-lj1-x243.google.com with SMTP id k15-v6so13481890ljc.8 for ; Mon, 28 Jan 2019 01:02:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=RJIhoqMLAJv/rjSZbsr6m62pqBkd6IFN+2xvLBJhajs=; b=vnmqLjU/PdJCW6uCHYdO9AOxqoq027yce5bt4vJOBDislkTVoFEVoczk4RlzTUsqE8 +gA5Vq+nQWTtLfx1xW90YMCxz6UpkafURbUH8US2Gjt50DDY/KJRBJhtEOIsmDo8+2J0 qiZvuhGxD34+iKpJZyBJNIYEoeii1JcuMpKTM5c+zfxVS09xk5f8TqmvXzp2cPKhttl1 4Z1v4rIDBsr0HqYvI2x8LngtT3YgFsAOQMRtPVYnW9fmZk60yIQhu9EbQESNJ+UQRmwg n05oXz0/j7gcK6lPbnoxPkiNMFKjxc5IIGB+zOwBzo0LMTiz5Q47lIdoVc8E5XfUHZ+7 KBZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=RJIhoqMLAJv/rjSZbsr6m62pqBkd6IFN+2xvLBJhajs=; b=UZr21Sw2ESfHLULYWqjhWTlV/8iRQfvK1/x14gLpo4gWM+VBL+8VKSOy8qvX5HV7po qxbIq//mz6sXsAG7Wg232kuRQa6rpiVn+LqWc/TjOqFX0Rwm+CbkNSaTVs3I2ob6wDRF KPi4HEa1xsoPPaWpvczDpcT+WLS4L1gkkAVMzelAOL9adnfK5tI7nUEWpyhd63JEsBYL vlx3I0k0mAZi3e6/b5a1O11YlRYSBHkub8EEdp9QRl1qnJKWCH530ocyIi9ev5cs/lI/ xZqpvN7RO/MZU+ETBzq+ZXjJ2Hjwjt4I1aPDgqLN+P55M6ZJxv8v+/L03mngbtH/+jgg r3PA== X-Gm-Message-State: AJcUukeiS4tlTEXR69eYRTsqOI3jeM58+S4jxz/oCzpUcatB4AnwcrJ/ yfbj/6yBfVHOd8bwhDcDgQAqnDO56ef9R63/drpv3Zw4fzI= X-Google-Smtp-Source: ALg8bN4TOTWXzTUnuuR2tSIJWV4OONSdI70kZp969mkNFc6V/f566SNU6NgbP2BJ3XKdtBkkTWdwH8JXUU9XlUpI5Gw= X-Received: by 2002:a2e:4784:: with SMTP id u126-v6mr16356715lja.124.1548666139073; Mon, 28 Jan 2019 01:02:19 -0800 (PST) MIME-Version: 1.0 From: Aditya Toshniwal Date: Mon, 28 Jan 2019 14:32:07 +0530 Message-ID: Subject: [pgAdmin4][RM3903] Query Tool Initialization Error To: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000190442058080eff8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000190442058080eff8 Content-Type: multipart/alternative; boundary="00000000000019043f058080eff6" --00000000000019043f058080eff6 Content-Type: text/plain; charset="UTF-8" Hi Hackers, Attached is the patch to fix "Query Tool Initialization Error" which occurs on opening query tool for some users. The problem was, request data was sent from client but was not read by back end service. In flask, if you receive POST data in a request you *must* read it before returning a response. Also removed a dead code, which was not referred/used anywhere. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --00000000000019043f058080eff6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

Attached is the patch to fix = "Query Tool Initialization Error" which occurs on opening query t= ool for some users.
The problem was, request data was sent from client but = was not read by back end service. In flask,=C2=A0if you receive POST data in a request you=C2=A0must=C2=A0read it before returning a response.<= /div>
= Also removed a dead code, which was not referred/used anywhere.

<= div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">Kindly= review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0Ent= erpriseDB Software Solutions |=C2=A0Pun= e
"Don't Complain = about Heat, Plant a tree"
<= /div>
--00000000000019043f058080eff6-- --000000000000190442058080eff8 Content-Type: application/octet-stream; name="RM3903.patch" Content-Disposition: attachment; filename="RM3903.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrg3t81s0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2RhdGFncmlkL19faW5pdF9fLnB5IGIvd2Vi L3BnYWRtaW4vdG9vbHMvZGF0YWdyaWQvX19pbml0X18ucHkKaW5kZXggNzA5ZTE2NGYuLmRlZDA2 ZGVjIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi90b29scy9kYXRhZ3JpZC9fX2luaXRfXy5weQor KysgYi93ZWIvcGdhZG1pbi90b29scy9kYXRhZ3JpZC9fX2luaXRfXy5weQpAQCAtMzA2LDggKzMw NiwxNSBAQCBkZWYgaW5pdGlhbGl6ZV9xdWVyeV90b29sKHNnaWQsIHNpZCwgZGlkPU5vbmUpOgog ICAgICAgICBkaWQ6IERhdGFiYXNlIElkCiAgICAgIiIiCiAgICAgY29ubmVjdCA9IFRydWUKLSAg ICBpZiAoJ3JlY3JlYXRlJyBpbiByZXF1ZXN0LmFyZ3MgYW5kCi0gICAgICAgICAgICByZXF1ZXN0 LmFyZ3NbJ3JlY3JlYXRlJ10gPT0gJzEnKToKKyAgICByZXFBcmdzID0gTm9uZQorICAgICMgUmVh ZCB0aGUgZGF0YSBpZiBwcmVzZW50LiBTa2lwcGluZyByZWFkIG1heSBjYXVzZSBjb25uZWN0aW9u CisgICAgIyByZXNldCBlcnJvciBpZiBkYXRhIGlzIHNlbnQgZnJvbSB0aGUgY2xpZW50CisgICAg aWYgcmVxdWVzdC5kYXRhOgorICAgICAgICByZXFBcmdzID0gcmVxdWVzdC5kYXRhCisKKyAgICBy ZXFBcmdzID0gcmVxdWVzdC5hcmdzCisgICAgaWYgKCdyZWNyZWF0ZScgaW4gcmVxQXJncyBhbmQK KyAgICAgICAgICAgIHJlcUFyZ3NbJ3JlY3JlYXRlJ10gPT0gJzEnKToKICAgICAgICAgY29ubmVj dCA9IEZhbHNlCiAgICAgIyBDcmVhdGUgYXN5bmNocm9ub3VzIGNvbm5lY3Rpb24gdXNpbmcgcmFu ZG9tIGNvbm5lY3Rpb24gaWQuCiAgICAgY29ubl9pZCA9IHN0cihyYW5kb20ucmFuZGludCgxLCA5 OTk5OTk5KSkKZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2RhdGFncmlkL3N0YXRpYy9q cy9kYXRhZ3JpZC5qcyBiL3dlYi9wZ2FkbWluL3Rvb2xzL2RhdGFncmlkL3N0YXRpYy9qcy9kYXRh Z3JpZC5qcwppbmRleCA4NTFkNTNmZi4uZWE2MWRkN2EgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWlu L3Rvb2xzL2RhdGFncmlkL3N0YXRpYy9qcy9kYXRhZ3JpZC5qcworKysgYi93ZWIvcGdhZG1pbi90 b29scy9kYXRhZ3JpZC9zdGF0aWMvanMvZGF0YWdyaWQuanMKQEAgLTQwNywxMSArNDA3LDIwIEBA IGRlZmluZSgncGdhZG1pbi5kYXRhZ3JpZCcsIFsKICAgICAgICAgaWYgKHJlY3JlYXRlKSB7CiAg ICAgICAgICAgYmFzZVVybCArPSAnP3JlY3JlYXRlPTEnOwogICAgICAgICB9CisKKyAgICAgICAg LyogU2VuZCB0aGUgZGF0YSBvbmx5IGlmIHJlcXVpcmVkLiBTZW5kaW5nIG5vbiByZXF1aXJlZCBk YXRhIG1heQorICAgICAgICAgKiBjYXVzZSBjb25uZWN0aW9uIHJlc2V0IGVycm9yIGlmIGRhdGEg aXMgbm90IHJlYWQgYnkgZmxhc2sgc2VydmVyCisgICAgICAgICAqLworICAgICAgICBsZXQgcmVx RGF0YSA9IG51bGw7CisgICAgICAgIGlmKHNxbF9maWx0ZXIgIT0gJycpIHsKKyAgICAgICAgICBy ZXFEYXRhID0gSlNPTi5zdHJpbmdpZnkoc3FsX2ZpbHRlcik7CisgICAgICAgIH0KKwogICAgICAg ICAkLmFqYXgoewogICAgICAgICAgIHVybDogYmFzZVVybCwKICAgICAgICAgICBtZXRob2Q6ICdQ T1NUJywKICAgICAgICAgICBkYXRhVHlwZTogJ2pzb24nLAotICAgICAgICAgIGRhdGE6IEpTT04u c3RyaW5naWZ5KHNxbF9maWx0ZXIpLAorICAgICAgICAgIGRhdGE6IHJlcURhdGEsCiAgICAgICAg ICAgY29udGVudFR5cGU6ICdhcHBsaWNhdGlvbi9qc29uJywKICAgICAgICAgfSkKICAgICAgICAg LmRvbmUoZnVuY3Rpb24ocmVzKSB7CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi90b29scy9zcWxl ZGl0b3Ivc3RhdGljL2pzL3NxbGVkaXRvci5qcyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRv ci9zdGF0aWMvanMvc3FsZWRpdG9yLmpzCmluZGV4IDc4ZDM2OGM5Li44ODVkMDJiOSAxMDA2NDQK LS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3N0YXRpYy9qcy9zcWxlZGl0b3IuanMK KysrIGIvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3N0YXRpYy9qcy9zcWxlZGl0b3IuanMK QEAgLTk2LDcgKzk2LDYgQEAgZGVmaW5lKCd0b29scy5xdWVyeXRvb2wnLCBbCiAgICAgICAnY2xp Y2sgI2J0bi1pbmNsdWRlLWZpbHRlcic6ICdvbl9pbmNsdWRlX2ZpbHRlcicsCiAgICAgICAnY2xp Y2sgI2J0bi1leGNsdWRlLWZpbHRlcic6ICdvbl9leGNsdWRlX2ZpbHRlcicsCiAgICAgICAnY2xp Y2sgI2J0bi1yZW1vdmUtZmlsdGVyJzogJ29uX3JlbW92ZV9maWx0ZXInLAotICAgICAgJ2NsaWNr ICNidG4tYXBwbHknOiAnb25fYXBwbHknLAogICAgICAgJ2NsaWNrICNidG4tY2FuY2VsJzogJ29u X2NhbmNlbCcsCiAgICAgICAnY2xpY2sgI2J0bi1jb3B5LXJvdyc6ICdvbl9jb3B5X3JvdycsCiAg ICAgICAnY2xpY2sgI2J0bi1wYXN0ZS1yb3cnOiAnb25fcGFzdGVfcm93JywKQEAgLTE0NzUsMTgg KzE0NzQsNiBAQCBkZWZpbmUoJ3Rvb2xzLnF1ZXJ5dG9vbCcsIFsKICAgICAgICk7CiAgICAgfSwK IAotICAgIC8vIENhbGxiYWNrIGZ1bmN0aW9uIGZvciBvayBidXR0b24gY2xpY2suCi0gICAgb25f YXBwbHk6IGZ1bmN0aW9uKCkgewotICAgICAgdmFyIHNlbGYgPSB0aGlzOwotCi0gICAgICAvLyBU cmlnZ2VyIHRoZSBhcHBseV9maWx0ZXIgc2lnbmFsIHRvIHRoZSBTcWxFZGl0b3JDb250cm9sbGVy IGNsYXNzCi0gICAgICBzZWxmLmhhbmRsZXIudHJpZ2dlcigKLSAgICAgICAgJ3BnYWRtaW4tc3Fs ZWRpdG9yOmJ1dHRvbjphcHBseV9maWx0ZXInLAotICAgICAgICBzZWxmLAotICAgICAgICBzZWxm LmhhbmRsZXIKLSAgICAgICk7Ci0gICAgfSwKLQogICAgIC8vIENhbGxiYWNrIGZ1bmN0aW9uIGZv ciBjYW5jZWwgYnV0dG9uIGNsaWNrLgogICAgIG9uX2NhbmNlbDogZnVuY3Rpb24oKSB7CiAgICAg ICAkKCcjZmlsdGVyJykuYWRkQ2xhc3MoJ2Qtbm9uZScpOwpAQCAtMjA4NCw3ICsyMDcxLDYgQEAg ZGVmaW5lKCd0b29scy5xdWVyeXRvb2wnLCBbCiAgICAgICAgIHNlbGYub24oJ3BnYWRtaW4tc3Fs ZWRpdG9yOmJ1dHRvbjppbmNsdWRlX2ZpbHRlcicsIHNlbGYuX2luY2x1ZGVfZmlsdGVyLCBzZWxm KTsKICAgICAgICAgc2VsZi5vbigncGdhZG1pbi1zcWxlZGl0b3I6YnV0dG9uOmV4Y2x1ZGVfZmls dGVyJywgc2VsZi5fZXhjbHVkZV9maWx0ZXIsIHNlbGYpOwogICAgICAgICBzZWxmLm9uKCdwZ2Fk bWluLXNxbGVkaXRvcjpidXR0b246cmVtb3ZlX2ZpbHRlcicsIHNlbGYuX3JlbW92ZV9maWx0ZXIs IHNlbGYpOwotICAgICAgICBzZWxmLm9uKCdwZ2FkbWluLXNxbGVkaXRvcjpidXR0b246YXBwbHlf ZmlsdGVyJywgc2VsZi5fYXBwbHlfZmlsdGVyLCBzZWxmKTsKICAgICAgICAgc2VsZi5vbigncGdh ZG1pbi1zcWxlZGl0b3I6YnV0dG9uOmNvcHlfcm93Jywgc2VsZi5fY29weV9yb3csIHNlbGYpOwog ICAgICAgICBzZWxmLm9uKCdwZ2FkbWluLXNxbGVkaXRvcjpidXR0b246cGFzdGVfcm93Jywgc2Vs Zi5fcGFzdGVfcm93LCBzZWxmKTsKICAgICAgICAgc2VsZi5vbigncGdhZG1pbi1zcWxlZGl0b3I6 YnV0dG9uOmxpbWl0Jywgc2VsZi5fc2V0X2xpbWl0LCBzZWxmKTsKQEAgLTMyNjQsNDkgKzMyNTAs NiBAQCBkZWZpbmUoJ3Rvb2xzLnF1ZXJ5dG9vbCcsIFsKICAgICAgICAgfSk7CiAgICAgICB9LAog Ci0gICAgICAvLyBUaGlzIGZ1bmN0aW9uIHdpbGwgYXBwbHkgdGhlIGZpbHRlci4KLSAgICAgIF9h cHBseV9maWx0ZXI6IGZ1bmN0aW9uKCkgewotICAgICAgICB2YXIgc2VsZiA9IHRoaXMsCi0gICAg ICAgICAgc3FsID0gc2VsZi5ncmlkVmlldy5maWx0ZXJfb2JqLmdldFZhbHVlKCk7Ci0KLSAgICAg ICAgc2VsZi50cmlnZ2VyKAotICAgICAgICAgICdwZ2FkbWluLXNxbGVkaXRvcjpsb2FkaW5nLWlj b246c2hvdycsCi0gICAgICAgICAgZ2V0dGV4dCgnQXBwbHlpbmcgdGhlIGZpbHRlci4uLicpCi0g ICAgICAgICk7Ci0KLSAgICAgICAgLy8gTWFrZSBhamF4IGNhbGwgdG8gaW5jbHVkZSB0aGUgZmls dGVyIGJ5IHNlbGVjdGlvbgotICAgICAgICAkLmFqYXgoewotICAgICAgICAgIHVybDogdXJsX2Zv cignc3FsZWRpdG9yLmFwcGx5X2ZpbHRlcicsIHsKLSAgICAgICAgICAgICd0cmFuc19pZCc6IHNl bGYudHJhbnNJZCwKLSAgICAgICAgICB9KSwKLSAgICAgICAgICBtZXRob2Q6ICdQT1NUJywKLSAg ICAgICAgICBjb250ZW50VHlwZTogJ2FwcGxpY2F0aW9uL2pzb24nLAotICAgICAgICAgIGRhdGE6 IEpTT04uc3RyaW5naWZ5KHNxbCksCi0gICAgICAgIH0pCi0gICAgICAgIC5kb25lKGZ1bmN0aW9u KHJlcykgewotICAgICAgICAgIHNlbGYudHJpZ2dlcigncGdhZG1pbi1zcWxlZGl0b3I6bG9hZGlu Zy1pY29uOmhpZGUnKTsKLSAgICAgICAgICBzZXRUaW1lb3V0KAotICAgICAgICAgICAgZnVuY3Rp b24oKSB7Ci0gICAgICAgICAgICAgIGlmIChyZXMuZGF0YS5zdGF0dXMpIHsKLSAgICAgICAgICAg ICAgICAkKCcjZmlsdGVyJykuYWRkQ2xhc3MoJ2Qtbm9uZScpOwotICAgICAgICAgICAgICAgICQo JyNlZGl0b3ItcGFuZWwnKS5yZW1vdmVDbGFzcygnc3FsLWVkaXRvci1idXN5LWZldGNoaW5nJyk7 Ci0gICAgICAgICAgICAgICAgLy8gUmVmcmVzaCB0aGUgc3FsIGdyaWQKLSAgICAgICAgICAgICAg ICBxdWVyeVRvb2xBY3Rpb25zLmV4ZWN1dGVRdWVyeShzZWxmKTsKLSAgICAgICAgICAgICAgfSBl bHNlIHsKLSAgICAgICAgICAgICAgICBhbGVydGlmeS5hbGVydChnZXR0ZXh0KCdBcHBseSBGaWx0 ZXIgRXJyb3InKSwgcmVzLmRhdGEucmVzdWx0KTsKLSAgICAgICAgICAgICAgfQotICAgICAgICAg ICAgfSwgMTAKLSAgICAgICAgICApOwotICAgICAgICB9KQotICAgICAgICAuZmFpbChmdW5jdGlv bihlKSB7Ci0gICAgICAgICAgc2VsZi50cmlnZ2VyKCdwZ2FkbWluLXNxbGVkaXRvcjpsb2FkaW5n LWljb246aGlkZScpOwotICAgICAgICAgIGxldCBtc2cgPSBodHRwRXJyb3JIYW5kbGVyLmhhbmRs ZVF1ZXJ5VG9vbEFqYXhFcnJvcigKLSAgICAgICAgICAgIHBnQWRtaW4sIHNlbGYsIGUsICdfYXBw bHlfZmlsdGVyJywgW10sIHRydWUKLSAgICAgICAgICApOwotICAgICAgICAgIGFsZXJ0aWZ5LmFs ZXJ0KGdldHRleHQoJ0FwcGx5IEZpbHRlciBFcnJvcicpLCBtc2cpOwotICAgICAgICB9KTsKLSAg ICAgIH0sCi0KICAgICAgIC8vIFRoaXMgZnVuY3Rpb24gd2lsbCBjb3B5IHRoZSBzZWxlY3RlZCBy b3cuCiAgICAgICBfY29weV9yb3c6IGNvcHlEYXRhLAogCg== --000000000000190442058080eff8--