Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp9gg-00030N-4a for pgadmin-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 10:35:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gp9ge-0008Ru-H3 for pgadmin-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 10:35:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp9ge-0008Rn-9g for pgadmin-hackers@lists.postgresql.org; Thu, 31 Jan 2019 10:35:12 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp9ga-0003DN-Sl for pgadmin-hackers@postgresql.org; Thu, 31 Jan 2019 10:35:11 +0000 Received: by mail-lf1-x132.google.com with SMTP id y11so1934286lfj.4 for ; Thu, 31 Jan 2019 02:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pI07EJcP1DnO7baZ5dpg713XirLDJXjPLfetPCk1wNc=; b=073thTOmw/sO47iMXTAkt8yXocCBI4c307+LWxutpsmRY/cSMtlyK5Dd7GR93QsiHS HH776Q9xfymTfwtlStu/8F9eZ/VKK4YkB87njr+bpEqgsaj68gNkZJyQJCW+ITsiv/rg OsPLfm6GzNfesuq17u5SIMenWM89CGoShgMMEdEocElyl011xMxo7+GPqoKTG4mCJqf7 /mP0+7WEVDMfKzJi+aPczBTgz+neWXiLT1Bq2eP6r+FwXXqLex1PD68Hspo/kvTwxc3R +mtJR9bHxMT/zDxyA+OjLkaWGMPEXqOt0Jw0YRomxmrhHZ5nyWn/vA+mBoFjvLi8bOh0 /7ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pI07EJcP1DnO7baZ5dpg713XirLDJXjPLfetPCk1wNc=; b=pif5Bt1DdUHajBOC7sVoh1djjHYkTa63+w+fn7oHYnAjBMJQZdtoH19ytBGxzelrTv lXRFlfnfmNMPGdK9H2OfZyPGV+5gNwpBl3HwEiirM05UYDO2CVPnuMCZ00pUydbM5IsE 8iO3AAJ/fAjtB4V94FhWpSMRMuEDgy905ppf00DvHx2tN6msBO3R1e8hVC+tpZWDo9ur 1w6gaMOAtrpKps76ajzMI42epwrHer8neVSXrIGqsU0FFF9YPzF7Jb00fJZsoVZs6L7z k3N+Merlngptsv/CyWXf2Uy/JvgoMPqaSTPVTtOuAAihrUlBILCxNIF9VRWioaLN7ysS UhtA== X-Gm-Message-State: AJcUukeQLOq3jEee9CkuLrTw51LprTiXmY2AYArh6QuC1DAfYUfCtQJt 25IcIFkYA0c1o4E1MMr9RDmTGiZoIvf+I66FYKORGg== X-Google-Smtp-Source: ALg8bN58W+pzzxp47mLOWpEiBjPTaWJp3Kdewdq8WWxevACwc7NApgo1O0PCUkkQt5VsiFnrnV/x26qzkVP3K1Bqp9A= X-Received: by 2002:a19:f510:: with SMTP id j16mr28522344lfb.35.1548930907258; Thu, 31 Jan 2019 02:35:07 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Thu, 31 Jan 2019 16:04:56 +0530 Message-ID: Subject: Re: Remove hacky way to open/close the dropdown-submenu To: Ashesh Vashi Cc: "khushboo.vashi" , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000008259bc0580be9453" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000008259bc0580be9453 Content-Type: text/plain; charset="UTF-8" Hi Ashesh, The patch looks good to me. On Thu, Jan 31, 2019 at 3:34 PM Ashesh Vashi wrote: > On Thu, Jan 31, 2019 at 2:38 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Ashesh, >> >> All works good, except one small change. Submenus should be closed if I >> press Esc and then reopen the menu. >> > Please find the updated patch to resolve the review comments. > > -- Thanks, Ashesh > >> >> On Thu, Jan 31, 2019 at 11:32 AM Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> Hi Aditya, >>> >>> On Tue, Jan 22, 2019 at 10:25 AM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Ashesh, >>>> >>>> I am getting a syntax error on bundle. >>>> After fixing that, please look into this scenario: >>>> Using keyboard shortcuts open object menu, for eg on table node. Go to >>>> any submenu using keyboard and go to any submenu and press enter. >>>> Now open object menu again using keyboard shortcut, the submenu remains >>>> open. It should be closed. >>>> >>> Please find the updated patch with all comments fixed. >>> Now - whenever the callback for the menu is called (menu toggling), it >>> will close the existing submenu(s) too. >>> >>> Please review it, and let me know. >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi >>> * >>> >>> >>>> >>>> Everything looks fine to me except the above. >>>> >>>> >>>> On Tue, Jan 22, 2019 at 10:07 AM Ashesh Vashi < >>>> ashesh.vashi@enterprisedb.com> wrote: >>>> >>>>> Any update? >>>>> >>>>> -- >>>>> >>>>> Thanks & Regards, >>>>> >>>>> Ashesh Vashi >>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>> >>>>> >>>>> >>>>> *http://www.linkedin.com/in/asheshvashi* >>>>> >>>>> >>>>> >>>>> On Thu, Jan 17, 2019 at 7:39 PM Ashesh Vashi < >>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Hi Aditya/Khushboo, >>>>>> >>>>>> I can see a hacky way to open/close the dropdown-submenu in the >>>>>> menu.js file. >>>>>> I've followed a more general way to open/close any submenu in the >>>>>> dropdown list, instead of just 'Objects' menu. >>>>>> >>>>>> Can you please review it, and let me know your thoughts? >>>>>> Let me know if you have any other better approach. >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Thanks & Regards, >>>>>> >>>>>> Ashesh Vashi >>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> >>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>> >>>>>> >>>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>> "Don't Complain about Heat, Plant a tree" >>>> >>> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --0000000000008259bc0580be9453 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ashesh,

The patch looks good to me.

On Thu, Jan 31= , 2019 at 3:34 PM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Thu, Jan 31, 2019 at 2:38 PM Aditya Toshniwal <aditya.tos= hniwal@enterprisedb.com> wrote:

H= i=C2=A0Ashesh,

All works good, except one s= mall change. Submenus should be closed if I press Esc and then reopen the m= enu.
Please find the updated patch to resolve = the review comments.

-- Thanks, Ashesh=C2=A0
=

On Thu, Jan 31, 2019 at 11:32 A= M Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
= Hi Aditya,

On Tue, Jan 22, 2019 at 10:25 AM Aditya Toshn= iwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Ashesh,
=

I am getting a syntax error on bundle.=C2=A0
After fixing that,=C2=A0 pl= ease look=C2=A0into this scenario:
Using keyboard shortcuts open object menu, for eg on table node.= Go to any submenu using keyboard and go to any submenu and press enter.
Now open object menu again= using keyboard shortcut, the submenu remains open. It should be closed.
Please find the updated patch with all comments = fixed.
Now - whenever the callback for the menu is called (menu t= oggling), it will close the existing submenu(s) too.

Please review it, and let me know.

--

Thanks & Regards,

Ashesh VashiEnterpriseD= B INDIA:=C2=A0Enterprise PostgreSQL Company


=

http://www.linkedin.com/in/asheshvashi

=C2=A0

Everyth= ing looks fine to me except the above.


On Tue, Jan 22, 2019 at 10:07 AM Ashesh Vashi= <ash= esh.vashi@enterprisedb.com> wrote:
Any update?

= --

Thanks & Regards,

Ashesh Vashi
Ente= rpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi



On Thu, Jan 17, 2019 at 7:39 PM Ashesh Vashi <= ;ashesh.= vashi@enterprisedb.com> wrote:
Hi Aditya/Khushboo,

I can see a hacky way to open/close the dropdown-submenu in the menu.js = file.
I've followed a more general way to open/close any subm= enu in the dropdown list, instead of just 'Objects' menu.

Can you please review it, and let me know your thoughts?
Let me know if you have any other better approach.
=C2=A0=
--

Thanks & Regard= s,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postg= reSQL Company


http://www.linkedin.com/in/asheshvashi



--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software S= olutions |=C2=A0Pune
<= span style=3D"font-family:"trebuchet ms",sans-serif;font-size:x-s= mall">"Don't Complain about Heat, Plant a = tree"


--
Thanks and Regards,
Aditya Toshniwal
=
Software Engineer |=C2=A0E= nterpriseDB Software Solutions |=C2=A0P= une
"Don't Complai= n about Heat, Plant a tree"


--
Thanks and Rega= rds,
Aditya Toshniwa= l
Softw= are Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
&q= uot;Don't Complain about Heat, Plant a tree"
--0000000000008259bc0580be9453--