Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j69f0-0002rF-Dw for pgadmin-hackers@arkaria.postgresql.org; Mon, 24 Feb 2020 09:04:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j69ez-0003gq-0L for pgadmin-hackers@arkaria.postgresql.org; Mon, 24 Feb 2020 09:04:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j69ey-0003gi-Ou for pgadmin-hackers@lists.postgresql.org; Mon, 24 Feb 2020 09:04:16 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j69ev-0007Ys-Hx for pgadmin-hackers@postgresql.org; Mon, 24 Feb 2020 09:04:16 +0000 Received: by mail-ed1-x52a.google.com with SMTP id r21so11034401edq.0 for ; Mon, 24 Feb 2020 01:04:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KP75M21v+Sl8aPzt1Jow4SKFayZdgd8rmBhVm6iFmxE=; b=nduJndWaWtzOGDN2ruzbsgPL0PBIuUKJVarB1Ah4+BZnfetYbuzevh7SwOBsl0YeqZ /8IlbYduLRW0fy04bmO4t2QyVbWXSKEigao57fyPusnrxfAepbGkRwPKOyYOrB82expR jB8CIiJxwbqW79IEHVeXsgZ/YIZNzuJHFYlvII/iRbdu/h3lef4Wn/RV/RYWNPcmjuJ7 aKIzreas8r0ttJ4ZEgsz8gRDOJ9ITxxUcOMEshLMtKW6W6J+47WSuv2QuYLbVaufqnS9 CF1MUzDWA3xwUapDoDFk1VTuTd+l9xi7dgxTNgN06D7724kEM7W4gghPHNL/QRLKVUnA uv6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KP75M21v+Sl8aPzt1Jow4SKFayZdgd8rmBhVm6iFmxE=; b=n6pO0OruzS0G9CPUG/oNNuYNF2BNzFYYEKBtNrmbokySIFWpoZgXu1pf42szoifeMb hBG56B6rqQkXH7IYMSv6pdXFW+uFliVYib98YYMWyjGXHnTuwhxthHrWoiaQPKo0OCyw z0XbCDqJkcgsfW4z5jyFtjdjMoYMA9SQQFmdQYQnX/GiVI/lVCGKUHBYUVWSfXvy17Fk sbBx+ZEsI/MAbbs6ewwVnHjE2i/pQ/Irc6iRV4qgtcDwzTKTB46WZJxhiYhCV8YtOSAR 6ZQCReJe4McRDqiZsuCw+DSg7HtJT1WGU8bc7+WvPxXkffvR23jBcrd7BLtF3iEIBJ1+ NQig== X-Gm-Message-State: APjAAAUtEENaqmVl9iKrjAY8zjCP1e/JRSlmJCn10PyNUEff5c77LGvV fyaabMwXamFqMECEgcRHFSOin6T2TKM0KrKLtZ2l4U2IrClEWyuTMHwIsp3zraPDFQQSmZcx/0p z4sImPxBQykwv8BnlhWTLWemBHAbVeZOgwnT6zghFRmL6YIWx0vCq8cjKKXBQVS+nHaC9InEWYZ lx7lrVtH//uQJhH4pLUW2T7cYMIsJ3mlve6KtDg0TNjtSqtY4/vhg= X-Google-Smtp-Source: APXvYqzp2UY84iAViI3jrwrIeNE0pnV3YcxEGqEec+SqzaUxGSCXVZ5K2vnHcZSCN5oMm/i62p6vvyR9nR+E7KtgQ0g= X-Received: by 2002:aa7:c38e:: with SMTP id k14mr44598112edq.309.1582535052086; Mon, 24 Feb 2020 01:04:12 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Mon, 24 Feb 2020 14:33:36 +0530 Message-ID: Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify To: Pradip Parkale Cc: Ashesh Vashi , pgadmin-hackers , Akshay Joshi Content-Type: multipart/alternative; boundary="0000000000009feb63059f4ea767" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009feb63059f4ea767 Content-Type: text/plain; charset="UTF-8" Hi Pradip, - commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content div.active')); + $(alertifyDialog.elements.dialog).find('[tabindex]:not([tabindex="-1"]').first().focus(); Use the same common function with commonUtils.findAndSetFocus(alertifyDialog.elements.dialog)). It will handle the focus. Also, make the required changes mentioned on the pull request - https://github.com/EnterpriseDB/AlertifyJS/pull/1 On Fri, Feb 21, 2020 at 11:19 AM Akshay Joshi wrote: > Hi Aditya > > Can you please review this patch. > > On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale < > pradip.parkale@enterprisedb.com> wrote: > >> Please find the attached patch. >> >> On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> Forgot to attach the patch? >>> >>> On Wed, 19 Feb 2020 at 16:58, Pradip Parkale < >>> pradip.parkale@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is a patch for accessibility issue related Alertifyjs. >>>> >>>> 1. Added hidden label to satisfy accessibility. >>>> 2. Added label with sr-only class. >>>> 3. Added tabindex to move the mouse control to the maximize button >>>> using the tab key. >>>> >>>> >>>> Please note that this patch also includes the fix for the >>>> RM-5143 Accessibility issue to maximize the panel for backup and restore >>>> windows and all other places. >>>> -- >>>> Thanks & Regards, >>>> Pradip Parkale >>>> QMG, EnterpriseDB Corporation >>>> >>> -- >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> >>> >> >> >> -- >> Thanks & Regards, >> Pradip Parkale >> QMG, EnterpriseDB Corporation >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --0000000000009feb63059f4ea767 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Pradip,

- =C2=A0 =C2= =A0commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.t= ab-content div.active'));
+ =C2=A0 =C2=A0$(alertifyDialog.elements.d= ialog).find('[tabindex]:not([tabindex=3D"-1"]').first().f= ocus();

Use the same commo= n function with commonUtils.findAndSetFocus(alertifyDialog.elements.dialog)= ). It will handle the focus.
Also, make the required changes mentioned on the pull request -=C2= =A0https://github.com/EnterpriseDB/AlertifyJS/pull/1


On Fri, Feb 21, 2020= at 11:19 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya

<= div>Can you please review this patch.

On Wed, Feb 19, 2020 at 5:04 PM = Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Please find th= e attached patch.

On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi <ashesh.vashi@en= terprisedb.com> wrote:
--


--
Thanks & Regards,
=
Pradip Parkale
QMG, EnterpriseDB C= orporation


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,Aditya Toshniwal
pgAdmin Hacker | Sr. S= oftware Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat= , Plant a TREE"
=
--0000000000009feb63059f4ea767--