Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go5fV-0003vT-7M for pgadmin-hackers@arkaria.postgresql.org; Mon, 28 Jan 2019 12:05:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1go5fU-000133-11 for pgadmin-hackers@arkaria.postgresql.org; Mon, 28 Jan 2019 12:05:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go5fT-00010p-R9 for pgadmin-hackers@lists.postgresql.org; Mon, 28 Jan 2019 12:05:35 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go5fO-00022w-Dk for pgadmin-hackers@postgresql.org; Mon, 28 Jan 2019 12:05:35 +0000 Received: by mail-lj1-x241.google.com with SMTP id c19-v6so13981275lja.5 for ; Mon, 28 Jan 2019 04:05:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NIloOSy+i0K4Z7CHcXBB8Az+BDD/f/NzMkPuDZsFLxo=; b=CLzBGAiYp03bUCZN729qmb0FssarcVJNApQhcyIpgftZHOW7SjRRmK8pCfrMKkphpi UbMGAC+ZVFxxBeR72gaJNsa9aoR3oOsHnB3m3epq9A0SrXPBhvsU8fn0FftgjSJ3C151 mI5F9zY75b5zoiSIf4vV25l75a7H0vlupti7NrIjpBxULATANHKS7WLq5oD/ZSqO/0fU vygu1w0eOJNEZCO9v53ypMhEYQzfh6KMPWbhtp4dMugP1OrtksKMgRZFur6HJG8pa8eI roDBkugmqtcPo3nPVKYcdk8SuftzwfUHSdo/59cesIpoX8AFn1g/XEr6gZ7VvmYrlbmJ XEBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NIloOSy+i0K4Z7CHcXBB8Az+BDD/f/NzMkPuDZsFLxo=; b=mjTdQ8biaq6BB7LQh6D5ZuxoHa/js93hjt0z1+Wueojvgl3FhU3urcEC2STNMobtVI dvNmAKNil6T1bK8Cxtvh3Z8h5x/IMi0gQhPf28ruJZ/Fn1BRnmu7doIHY4v9n8kKV2UA xoCufYZ8PYmOMurbnMfSVcur4OXAR4EYvlg5eI3yCa6HlpdTKrh/wMphu/Z7HDKt4mij ShI+w2BbunUKzHR+DmBFvlIb9D4u8sdMQn6ETU+7MY5+dgR0io3G0/jYLK8CrLxpIcDi Vw+aFqUNGp3tGVP3hg34lwHkMz0bRkm+oo8xwJFJnsVD6mxxItZWEwDQf5ZJru/T2gGM 5DcQ== X-Gm-Message-State: AHQUAuZjT4+mpnQkLGDwQaBgL/98xAcOIUmF9gYEr11ykrW5pBaZknf7 O0VNUW7c5IBYNAbVr8GpmJVQPSlorSx1ngMb/Z1xcQ== X-Google-Smtp-Source: ALg8bN6tYQKq7BtUTByk/PAkGi9NxDFvI95Ycl5tHPPbBH+117lq3pSe4cyiTs86hHrePGYgBXBCbd/4sEFj4OUbySs= X-Received: by 2002:a2e:2c02:: with SMTP id s2-v6mr1133384ljs.118.1548677128639; Mon, 28 Jan 2019 04:05:28 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Mon, 28 Jan 2019 17:35:17 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000001fef390580837ebd" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001fef390580837ebd Content-Type: text/plain; charset="UTF-8" Hi Dave, On Mon, Jan 28, 2019 at 5:01 PM Dave Page wrote: > Hi > > On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal > wrote: > > > > Hi Hackers, > > > > Attached is the patch to fix failing SQL editor related feature tests. > > The failure is occurring mostly because of send_keys function of > selenium which sometimes does not input the complete text. The change will > use Codemirror javascript object to set the text. > > > > I have also added new args flag "--modules" which can be used after > --pkg where you can test a specific module file under the pkg. This is not > so useful for build but definitely helpful for the developers. > > One of the most common failures I see is failure to fill in the > details on the Add Server dialogue (it might type half of an entry, > then just hang). Should we get rid of all uses of send_keys? > Setting the text using javascript executor can be done. send_keys simulate an actual person, so if you try to set a disabled text box using send_keys, it won't. Places where disabled fields doesn't matter, send_keys can be removed. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --0000000000001fef390580837ebd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

On Mon, Jan 28, 2019 at 5:01 PM = Dave Page <dpage@pgadmin.org>= ; wrote:
Hi

On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal
<= aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix failing SQL editor related feature tests.=
> The failure is occurring mostly because of send_keys function of selen= ium which sometimes does not input the complete text. The change will use C= odemirror javascript object to set the text.
>
> I have also added new args flag "--modules" which can be use= d after --pkg where you can test a specific module file under the pkg. This= is not so useful for build but definitely helpful for the developers.

One of the most common failures I see is failure to fill in the
details on the Add Server dialogue (it might type half of an entry,
then just hang). Should we get rid of all uses of send_keys?
Setting the text using javascript executor can be done. send_keys simula= te an actual person, =C2=A0so if you try to set a disabled text box usin= g send_keys, it won't. Places where disabled fields doesn't matter,= send_keys can be removed.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Rega= rds,
Aditya Toshniwa= l
Softw= are Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
&q= uot;Don't Complain about Heat, Plant a tree"
--0000000000001fef390580837ebd--