Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hg66i-0006cH-9a for pgadmin-hackers@arkaria.postgresql.org; Wed, 26 Jun 2019 11:28:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hg66g-0002l7-Ue for pgadmin-hackers@arkaria.postgresql.org; Wed, 26 Jun 2019 11:28:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hg66g-0002jI-Jm for pgadmin-hackers@lists.postgresql.org; Wed, 26 Jun 2019 11:28:54 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hg66c-0006vM-UX for pgadmin-hackers@postgresql.org; Wed, 26 Jun 2019 11:28:54 +0000 Received: by mail-lj1-x242.google.com with SMTP id 16so1785330ljv.10 for ; Wed, 26 Jun 2019 04:28:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3GLOu9P8eULiwp3QmMR5Tkf6yVawYmeX1PP/J/AtuLk=; b=LGg86b/Z0+SIWA9Gfq3zJ7Er7rHoV3xhuFaQsVPFNWpvAlN52PVpCvC1O9JPRPyWSP nVXY2zlKgtQQypdNatneMtwhlLLL+GsblqJUPjREowi9u/lPb+of0hpG1vjJ26jjxZnL L1dIY+BAIxiN1Df5hkYwJKtTv/13BqFksbc4940FMQxmU+QGbjYuNxwCXYxQ9VzIzssH qsGRsNDLvnN3aNQ1Mw4Dnt+zg+GxnP385LU2gC8lXMUD6i22/4ezg0jDQOmVoktsX5nH WEv04pZdRETMTxhOUfZ7nVb1P+tVtc7JO0PCw66BjzisCB1qma0GHNrNIug0JA7AwesX ziCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3GLOu9P8eULiwp3QmMR5Tkf6yVawYmeX1PP/J/AtuLk=; b=D3MxRnehAPc+VvN3Pb6xr8L+mGUPPOm1N3V+WOXHStWt4TGBvZ8SbT9CO7t6X9FE6N ghv998TRE6yVk6TBfZkyzNAY1EjjBLouz/KFIT4zjC7TMorjPcRdZNifOrsat75Yr2mu 12FOgNkTkgX1UrLlBgmGntET4jtYdgOYvHLBgxmMSn8jgo3v9m6fYkChEmw1aWKv9gny JEzIhQTk/NM1T/fuFJOYvesDJXvx1bR/RtJxP03tPK8FzM4mkwt5c9ZCbVClHor4mmM7 KJP3Ul+8FEzlwJXhUdiaUzG2oKiqmdO4mdsLajtI9reyZjj9+YVGRuirjy91mILtdpja h6gw== X-Gm-Message-State: APjAAAXeTf6f1gfkz5kin4MIPYmyU+xysEsNHJb/+Q+hJKU5exEkwYR2 tYrr+6UpOe5KDIRr2yyHTAJHCQZo4mrDGQX0agVYjA== X-Google-Smtp-Source: APXvYqzDbh0RwLmTeOWfNKtk8zJUDfaE2vh6qwsbaNozJdnWqs70QT0WFgGomPnK4VK2SrOJurFzuB3z4VXQXNQI8KU= X-Received: by 2002:a2e:9bc6:: with SMTP id w6mr2693224ljj.156.1561548529101; Wed, 26 Jun 2019 04:28:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Wed, 26 Jun 2019 16:58:13 +0530 Message-ID: Subject: Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000062ed4c058c385966" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000062ed4c058c385966 Content-Type: text/plain; charset="UTF-8" Hi, On Wed, Jun 26, 2019 at 4:51 PM Dave Page wrote: > Hi > > On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to allow tree nodes to be dragged and dropped in >> query editor wherever you take the drop cursor. The drop text will be fully >> qualified and double quoted if required. >> For functions/procedures it will drop the the label stripping away the >> parameter names, with empty pair of round brackets. It will also set the >> focus cursor inside the brackets if there were params otherwiser to the end >> of text. >> For adding a node type, you need to register it in browser.js along with >> a callback function which will return drop text along with cursor >> positioning and selection. Currently, I have registered for "table >> partition type sequence package view mview foreign_table edbvar schema >> column edbfunc function edbproc procedure". >> >> Please note, the drag design customisation is not supported in IE. >> > > I think for functions/procedures, we should include placeholders for the > parameters, so the user has a hint about what they need to fill in to > complete the call. > I can fill in the parameter names same as tree node, with cursor selection on all the params ? > > Also; shouldn't there be a doc update? > Yeah :/ Should there be any screenshots ? > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --00000000000062ed4c058c385966 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

=
On Wed, Jun 26, 2019 at 4:51 PM Dave = Page <dpage@pgadmin.org> wro= te:
Hi

On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal <aditya.toshniw= al@enterprisedb.com> wrote:
Hi Hackers,

<= /div>
Attached is the patch to= allow tree nodes to be dragged and dropped in query editor wherever you ta= ke the drop cursor. The drop text will be fully qualified and double quoted= if required.
For functi= ons/procedures it will drop the the label stripping away the parameter name= s, with empty pair of round brackets. It will also set the focus cursor ins= ide the brackets if there were params otherwiser to the end of text.
<= div>For adding a node type, = you need to register it in browser.js along with a callback function which = will return drop text along with cursor positioning and selection. Currentl= y, I have=C2=A0registered for &qu= ot;table partition type sequence package view mview foreign_table edbvar sc= hema column edbfunc function edbproc procedure".

Please note, the drag design customisation is not supported in= IE.

I think for functio= ns/procedures, we should include placeholders for the parameters, so the us= er has a hint about what they need to fill in to complete the call.
I can fill in the parameter names same as tree node= , with cursor selection on all the params ?

Also; shouldn't there be a doc update?
Yeah :/
Should there be any screenshots ?= =C2=A0

Thanks.
=C2=A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake<= br>
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company=


--
Adi= tya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"
--00000000000062ed4c058c385966--