Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lX0Nm-00024D-Cs for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Apr 2021 11:42:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lX0Nl-00044D-8Q for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Apr 2021 11:42:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lX0Nl-000445-21 for pgadmin-hackers@lists.postgresql.org; Thu, 15 Apr 2021 11:42:01 +0000 Received: from mail-vs1-xe2b.google.com ([2607:f8b0:4864:20::e2b]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lX0Nc-0002vG-PL for pgadmin-hackers@postgresql.org; Thu, 15 Apr 2021 11:41:59 +0000 Received: by mail-vs1-xe2b.google.com with SMTP id b20so11687140vsr.11 for ; Thu, 15 Apr 2021 04:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=reG8i8D4VoS5MaxE+9oF6KEnQazKF0uPIvISZtxzLU4=; b=dhvZhaduUB7nQYor66yOCe1QBRkL45s63jD4l7sJipWUdGYHihp3SWNL1uYQj2Ub2T q7dvEcQdgJSh/2YQ00YlinfmaO9VlF5O+JboSd12X9LwEQrcusnqZstLmv5N5VJYfl0r CRKeM1O164BVrIZlm4QLyGo7VTwaMVdUeo4ndYiLRCNolJeH3qMULKtUagkWc48tTSiV gzuSmfPR5iSWtI0yAOx0H7Ay/mzxD6HlTwTYySdA8H13JHG8JAD96u+QG7aAosXiLxJC SdeCUo8/QRoaAL0nCO8WakxxG6w4oTd+ldcgCvk4/tN1npIq6hG9QEDEIt2PdzbdWsZJ rVCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=reG8i8D4VoS5MaxE+9oF6KEnQazKF0uPIvISZtxzLU4=; b=enYkMeI4KAJcoKRNKdV6h0Jt+clS1tyx3tB6eMmKFe7BQiUn1GXSYJc1tnjGeJxnkV ahqIbyBJJ3PIIGkWfphCYW/s+QgVAjFHSKNr/IpNBMGxzBcANZyI2bb5PhtX1J/qBXUY rglC/y450KuXkD7/9fW/2cU0vlQ60XKXGVM1GDTSX0Dru0guEGIvoIIFY0fsLRWmtJUW 3JSoVvCb73srv4JiyqKx2gAE+mWOIqdSqbNFnvq9CZ9uJGFgPGJ37Ywo1YCMgOGvaSCd rgLxRnuUR2Qz46jHKDtLdEk2gU2kXMNhFYOFWrAJinyatw+pOGXXTaLqGJLyZBtAhJaN pZGQ== X-Gm-Message-State: AOAM531qI6mrn9yOwUPGPwSmdU609MiTc2e2IWs6SsAKmEE4+q3hbE2l Pu17K46krNGlD85sVAhBOI6XWgvl3whhrOWlrp3ih3eb9Inp1cESYIoxjjytjPCSbCo4t8sp4bq 58gWSwl8fWdmESjEgkmr5we1JzCklNRKTQjvKao5YnBIlSOkJin00Zs+JUXE5uQIyhz9kL+Xn0/ sqC+b3r/mmduuXBtzQPvfw4M8X3KzugUEKOucEWfPldXQzO9NkjXZxkgxV5gKcy0KBKQ== X-Google-Smtp-Source: ABdhPJyTvW2cioVSwOJtIecM8p0KR311FOMfkmSl1/wXsglC+3XfkgxV1KU6GjOwm15ugtk5/vVqYiNUwRBsIQejJwI= X-Received: by 2002:a05:6102:3094:: with SMTP id l20mr1591971vsb.22.1618486910488; Thu, 15 Apr 2021 04:41:50 -0700 (PDT) MIME-Version: 1.0 From: Aditya Toshniwal Date: Thu, 15 Apr 2021 17:11:14 +0530 Message-ID: Subject: [pgAdmin]RM6334] SQL panel show blank screen when detach panel. To: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000005fccf105c0015965" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000005fccf105c0015965 Content-Type: multipart/alternative; boundary="0000000000005fccef05c0015963" --0000000000005fccef05c0015963 Content-Type: text/plain; charset="UTF-8" Hi Hackers, Attached patch fixes the SQL panel blank screen issue with a minimal change. I've also reverted all other existing code changes done for this. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --0000000000005fccef05c0015963 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

Attached patch fixes the SQL panel blank scree= n issue with a minimal change.
I've also reverted all other existing co= de changes done for this.

Please review.

--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"
--0000000000005fccef05c0015963-- --0000000000005fccf105c0015965 Content-Type: application/octet-stream; name="RM6334.patch" Content-Disposition: attachment; filename="RM6334.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_knitaaku0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL2Jyb3dzZXIuanMgYi93 ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9icm93c2VyLmpzCmluZGV4IDQzNTg1NzdhZi4u NGZmYjVlZTVhIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9icm93 c2VyLmpzCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL2Jyb3dzZXIuanMKQEAg LTQ4OSwxMiArNDg5LDYgQEAgZGVmaW5lKCdwZ2FkbWluLmJyb3dzZXInLCBbCiAgICAgICBzZXRU aW1lb3V0KGZ1bmN0aW9uKCkgewogICAgICAgICBvYmouZWRpdG9yLnNldFZhbHVlKCctLSAnICsg c2VsZWN0X29iamVjdF9tc2cpOwogICAgICAgICBvYmouZWRpdG9yLnJlZnJlc2goKTsKLSAgICAg ICAgLyogSW4gY2FzZSBvZiBSdW50aW1lIHdlIG5lZWQgdG8gbWFrZSBoZWlnaHQgb2Ygc3FsX3Rl eHRhcmVhCi0gICAgICAgICAqIHRvIDEwMSUgdG8gZml4IHRoZSBibGFjayBzY3JlZW4gaXNzdWUg d2l0aCBOV2pzLgotICAgICAgICAgKi8KLSAgICAgICAgaWYgKHBnQWRtaW5bJ3BnYWRtaW1fcnVu dGltZSddID09PSAnVHJ1ZScpIHsKLSAgICAgICAgICAkKCcucGctcGFuZWwtY29udGVudCAuc3Fs X3RleHRhcmVhJykuYWRkQ2xhc3MoJ3J1bnRpbWVfc3FsX3RleHRhcmVhJyk7Ci0gICAgICAgIH0K ICAgICAgIH0sIDEwKTsKIAogICAgICAgLy8gSW5pdGlhbGlzZSB0aGUgdHJlZXZpZXcKZGlmZiAt LWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVtcGxhdGVzL2Jyb3dzZXIvanMvdXRpbHMuanMg Yi93ZWIvcGdhZG1pbi9icm93c2VyL3RlbXBsYXRlcy9icm93c2VyL2pzL3V0aWxzLmpzCmluZGV4 IDZhZTQzZTQ5Zi4uODU5N2RmNDgzIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3Rl bXBsYXRlcy9icm93c2VyL2pzL3V0aWxzLmpzCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVt cGxhdGVzL2Jyb3dzZXIvanMvdXRpbHMuanMKQEAgLTQ3LDcgKzQ3LDYgQEAgZGVmaW5lKCdwZ2Fk bWluLmJyb3dzZXIudXRpbHMnLAogICBwZ0FkbWluWydjc3JmX3Rva2VuX2hlYWRlciddID0gJ3t7 IGN1cnJlbnRfYXBwLmNvbmZpZy5nZXQoJ1dURl9DU1JGX0hFQURFUlMnKVswXSB9fSc7CiAgIHBn QWRtaW5bJ2NzcmZfdG9rZW4nXSA9ICd7eyBjc3JmX3Rva2VuKCkgfX0nOwogICBwZ0FkbWluWydz ZXJ2ZXJfbW9kZSddID0gJ3t7IGN1cnJlbnRfYXBwLmNvbmZpZy5nZXQoJ1NFUlZFUl9NT0RFJykg fX0nOwotICBwZ0FkbWluWydwZ2FkbWltX3J1bnRpbWUnXSA9ICd7eyBjdXJyZW50X2FwcC5QR0FE TUlOX1JVTlRJTUUgfX0nOwogCiAgIC8qIEdldCB0aGUgaW5hY3Rpdml0eSByZWxhdGVkIGNvbmZp ZyAqLwogICBwZ0FkbWluWyd1c2VyX2luYWN0aXZpdHlfdGltZW91dCddID0ge3sgY3VycmVudF9h cHAuY29uZmlnLmdldCgnVVNFUl9JTkFDVElWSVRZX1RJTUVPVVQnKSB9fTsKZGlmZiAtLWdpdCBh L3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZm9ybS5wZ2FkbWluLmpzIGIvd2ViL3BnYWRtaW4v c3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMKaW5kZXggNGVjNWQ3OGNjLi44ZjcwZmQzYzAg MTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZm9ybS5wZ2FkbWluLmpzCisr KyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZm9ybS5wZ2FkbWluLmpzCkBAIC0xODY4LDcg KzE4NjgsNiBAQCBkZWZpbmUoWwogICAgICAgICAgICAgfSkuZG9uZShmdW5jdGlvbihyZXMpIHsK ICAgICAgICAgICAgICAgc2VsZi5zcWxDdHJsLmNsZWFySGlzdG9yeSgpOwogICAgICAgICAgICAg ICBzZWxmLnNxbEN0cmwuc2V0VmFsdWUocmVzLmRhdGEpOwotICAgICAgICAgICAgICBzZWxmLnNl dENvZGVNaXJyb3JIZWlnaHQob2JqKTsKICAgICAgICAgICAgIH0pLmZhaWwoZnVuY3Rpb24oKSB7 CiAgICAgICAgICAgICAgIHNlbGYubW9kZWwudHJpZ2dlcigncGdhZG1pbi12aWV3Om1zcWw6ZXJy b3InLCBzZWxmLm1ldGhvZCwgbm9kZSwgYXJndW1lbnRzKTsKICAgICAgICAgICAgIH0pLmFsd2F5 cyhmdW5jdGlvbigpIHsKQEAgLTE4ODQsNyArMTg4Myw2IEBAIGRlZmluZShbCiAgICAgICAgIH0K ICAgICAgICAgdGhpcy5zcWxDdHJsLnJlZnJlc2guYXBwbHkodGhpcy5zcWxDdHJsKTsKICAgICAg IH0KLSAgICAgIHRoaXMuc2V0Q29kZU1pcnJvckhlaWdodChvYmopOwogICAgIH0sCiAgICAgb25Q YW5lbFJlc2l6ZWQ6IGZ1bmN0aW9uKG8pIHsKICAgICAgIGlmIChvICYmIG8uY29udGFpbmVyKSB7 CkBAIC0xOTAwLDcgKzE4OTgsNiBAQCBkZWZpbmUoWwogICAgICAgICAgICAgJ2hlaWdodDogJyAr ICgkdGFiQ29udGVudC5oZWlnaHQoKSArIDgpICsgJ3B4ICFpbXBvcnRhbnQ7JwogICAgICAgICAg ICk7CiAgICAgICAgIH0KLSAgICAgICAgdGhpcy5zcWxDdHJsLnNldFNpemUoJHRhYkNvbnRlbnQu d2lkdGgoKSArICdweCcsICR0YWJDb250ZW50LmhlaWdodCgpICsgJ3B4Jyk7CiAgICAgICB9CiAg ICAgfSwKICAgICByZW1vdmU6IGZ1bmN0aW9uKCkgewpAQCAtMTkxNiwyNiArMTkxMyw2IEBAIGRl ZmluZShbCiAKICAgICAgIEJhY2tmb3JtLkNvbnRyb2wuX19zdXBlcl9fLnJlbW92ZS5hcHBseSh0 aGlzLCBhcmd1bWVudHMpOwogICAgIH0sCi0gICAgc2V0Q29kZU1pcnJvckhlaWdodDogZnVuY3Rp b24ob2JqKSB7Ci0gICAgICAvLyBGaXggZm9yIG1hYyBvcyBjb2RlLW1pcnJvciBzaG93aW5nIGJs YWNrIHNjcmVlbi4KLSAgICAgIHZhciB0eHRBcmVhID0gJCgnLnBnYWRtaW4tY29udHJvbHMgLnBn LWVsLXNtLTEyIC5TUUwgPiAuQ29kZU1pcnJvciA+IGRpdiA+IHRleHRhcmVhJykuZmlyc3QoKTsK LSAgICAgIHR4dEFyZWEuY3NzKCd6LWluZGV4JywgLTEpOwotICAgICAgdmFyICR0YWJDb250ZW50 ID0gJCgnLmJhY2tmb3JtLXRhYiA+IC50YWItY29udGVudCcpLmZpcnN0KCk7Ci0gICAgICB2YXIg JHNxbFBhbmUgPSAkdGFiQ29udGVudC5maW5kKCcuQ29kZU1pcnJvciA+IGRpdiA+IHRleHRhcmVh Jyk7Ci0gICAgICBmb3IobGV0IGk9MDsgaTwkc3FsUGFuZS5sZW5ndGg7IGkrKykgeyQoJHNxbFBh bmVbaV0pLmNzcygnei1pbmRleCcsIC0xKTt9Ci0KLSAgICAgICR0YWJDb250ZW50ID0gJCgnLmJh Y2tmb3JtLXRhYiA+IC50YWItY29udGVudCcpLmZpcnN0KCk7Ci0gICAgICAkc3FsUGFuZSA9ICR0 YWJDb250ZW50LmZpbmQoJ2Rpdltyb2xlPXRhYnBhbmVsXS50YWItcGFuZS4nICsgb2JqLnRhYi5p bm5lclRleHQpOwotICAgICAgLy8gU2V0IGhlaWdodCB0byBDb2RlTWlycm9yLgotICAgICAgaWYg KCRzcWxQYW5lLmhhc0NsYXNzKCdhY3RpdmUnKSkgewotICAgICAgICAkc3FsUGFuZS5maW5kKCcu Q29kZU1pcnJvcicpLmNzcygKLSAgICAgICAgICAnY3NzVGV4dCcsCi0gICAgICAgICAgJ2hlaWdo dDogJyArICgkdGFiQ29udGVudC5oZWlnaHQoKSkgKyAncHggIWltcG9ydGFudDsnCi0gICAgICAg ICk7Ci0gICAgICAgICRzcWxQYW5lLmZpbmQoJy5Db2RlTWlycm9yJykuY3NzKCd6LWluZGV4Jywg OTkpOwotICAgICAgfQotICAgIH0KLQogICB9KTsKICAgLyoKICAgICogTnVtZXJpYyBpbnB1dCBD b250cm9sIGZ1bmN0aW9uYWxpdHkganVzdCBsaWtlIGJhY2tncmlkCmRpZmYgLS1naXQgYS93ZWIv cGdhZG1pbi9zdGF0aWMvc2Nzcy9fd2ViY2FiaW4ucGdhZG1pbi5zY3NzIGIvd2ViL3BnYWRtaW4v c3RhdGljL3Njc3MvX3dlYmNhYmluLnBnYWRtaW4uc2NzcwppbmRleCAwY2JjODZmZDcuLmM5MTdj NTMxZCAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL3Njc3MvX3dlYmNhYmluLnBnYWRt aW4uc2NzcworKysgYi93ZWIvcGdhZG1pbi9zdGF0aWMvc2Nzcy9fd2ViY2FiaW4ucGdhZG1pbi5z Y3NzCkBAIC04OCw4ICs4OCw2IEBACiAgIHotaW5kZXg6IDEwNTAgIWltcG9ydGFudDsKIAogICAm LndjRnJhbWUsICYgLndjUGFuZWxCYWNrZ3JvdW5kIHsKLSAgICBib3JkZXItYm90dG9tLWxlZnQt cmFkaXVzOiAkY2FyZC1ib3JkZXItcmFkaXVzOwotICAgIGJvcmRlci1ib3R0b20tcmlnaHQtcmFk aXVzOiAkY2FyZC1ib3JkZXItcmFkaXVzOwogICAgIG1heC13aWR0aDogMTAwJTsKICAgICBtYXgt aGVpZ2h0OiAxMDAlOwogICB9CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0 b3Ivc3RhdGljL3Njc3MvX3NxbGVkaXRvci5zY3NzIGIvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRp dG9yL3N0YXRpYy9zY3NzL19zcWxlZGl0b3Iuc2NzcwppbmRleCBlOWQ5YTUzYzAuLjhiYTNlNWVi ZCAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3N0YXRpYy9zY3NzL19z cWxlZGl0b3Iuc2NzcworKysgYi93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3Ivc3RhdGljL3Nj c3MvX3NxbGVkaXRvci5zY3NzCkBAIC0xNCwxMiArMTQsNiBAQAogICBoZWlnaHQ6IDEwMCU7CiB9 CiAKLS53Y0Zsb2F0aW5nIHsKLSAgJiAucnVudGltZV9zcWxfdGV4dGFyZWEgewotICAgIGhlaWdo dDogMTAxJSAhaW1wb3J0YW50OwotICB9Ci19Ci0KIC5zcWxfdGV4dGFyZWEgLkNvZGVNaXJyb3It c2Nyb2xsIHsKICAgei1pbmRleDogMDsKIH0K --0000000000005fccf105c0015965--