public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM5268] Wrong SQL generated when we update FTS Configuration and FTS Dictionary
Date: Tue, 31 Mar 2020 11:21:28 +0530
Message-ID: <CAM9w-_nLi+a8E=5eXW98XbFHH1gmYBbjR8pJSphgjh5gkdvMTg@mail.gmail.com> (raw)
Hi Hackers,
Attached is a tiny patch to fix SQL generated when any token in FTS
Configuration or any option in FTS Dictionary is changed.
Please review.
--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] RM5268.patch (1.6K, 3-RM5268.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js
index ab4838ea5..ba13f498a 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js
@@ -19,6 +19,7 @@ define('pgadmin.node.fts_configuration', [
// Model for tokens control
var TokenModel = pgAdmin.Browser.Node.Model.extend({
+ idAttribute: 'token',
defaults: {
token: undefined,
dictname: undefined,
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/static/js/fts_dictionary.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/static/js/fts_dictionary.js
index 91f1d23fa..08666e80c 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/static/js/fts_dictionary.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/static/js/fts_dictionary.js
@@ -19,8 +19,9 @@ define('pgadmin.node.fts_dictionary', [
// Extend the browser's node model class to create a option/value pair
var OptionLabelModel = pgAdmin.Browser.Node.Model.extend({
+ idAttribute: 'option',
defaults: {
- options: undefined,
+ option: undefined,
value: undefined,
},
// Define the schema for the Options
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgAdmin][RM5268] Wrong SQL generated when we update FTS Configuration and FTS Dictionary
In-Reply-To: <CAM9w-_nLi+a8E=5eXW98XbFHH1gmYBbjR8pJSphgjh5gkdvMTg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox