Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQVb0-0008JK-7b for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Oct 2020 13:04:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kQVaz-0002dR-3p for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Oct 2020 13:04:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQVay-0002dJ-Tv for pgadmin-hackers@lists.postgresql.org; Thu, 08 Oct 2020 13:04:32 +0000 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kQVav-00063A-6c for pgadmin-hackers@postgresql.org; Thu, 08 Oct 2020 13:04:32 +0000 Received: by mail-ej1-x643.google.com with SMTP id e22so8018589ejr.4 for ; Thu, 08 Oct 2020 06:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xAV8Ku352PJxNLWZNNPh+8fPyN83hKvFqELRT/hmPGU=; b=DwL/OXFPE5sFSqosKEbgHCpBsd9ajlbUpTbP74HtF3KEb5XjmASQgbdaMhb62sdKrw Nr61YmhmDMsy8zxZrjDesM40+x/PgVUlpyLJRQO1r/vCQC50dwEFCI9Q7NStM1Z2Tx6V +jx13f9FWMVxSnC8wYXWa2IOaySruqtPQ1NRHpJFbZWToZJvYdL0ftRG3WuDdAlh47Tf AFcY3BY9GBta6/PnrBbjFGGqywYdui6eUMOlMMbePUimGWB4cFFFZn20wWgvW8UKIk18 QEqpV5NUb8m6DZJwm6wCri4DowP0AWZ/ocO8xS/bv4FmTlKsW/dXIk4PG/aJtXpI7aPQ ysiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xAV8Ku352PJxNLWZNNPh+8fPyN83hKvFqELRT/hmPGU=; b=MXhMiSqDmvyWZ8Ui6jXJOABUMa68evXeX7xEucV7yZYuGr8FRXwHsVXfWkzd8XAJtN XkJSwei2Q8n4ePsb1CiOWOxVvhZXS96sKiwSF9myjdWeRpIEy8YEn8k1qLuv9n+Yi0y1 5G//I3glPBEOU6O10ZZGE2c/uk2ZvRLQG8oA9nqcrFOQHck0kwVMNg62gcN91erur4Lb Q9vwr5PbYp1xuEqA8ufPnlilWt9LcrGknOwJqMM7MudQ9qb8YJLIB3fGtUkqXrEJMIt3 Dlvl867iV9rP+yoVwMISkmCYhJi12qgQWniS8b48ioVeLniX0902r2esO5n3OAU3n2jJ PV6A== X-Gm-Message-State: AOAM53278EzgZSpOxPwtso5x8SU1UmaGlKSUK5dxn7NfZLBxJsPK9iwQ g9zgiLKgz0rOj1Eb7s3fPh3WZyT4QZHdP3hssh84txLwyuAeLR5trA+t4vSu5JXYkrGQKjeiZgE 5asg+cVoakIvDUnqkBdvxZoMU3lmYXMgcQ8LO4r951CEcgSEIarWlA2iy6LQh7kE3XXT75L4woD dAb9fVU7Kt7ssIRLDuSFIkVd6hITXlGR/PWxht53oIJM2cHxTZ8r6WZ/f0F/fHJqc= X-Google-Smtp-Source: ABdhPJwmcovIEavCnUbXl8xMt/f8yOvPSxKQkx7hsd+KfktKaVo5gOWQcCtJHQAsocYLlUUdaJcoMwnV5+IJjkLyr8g= X-Received: by 2002:a17:907:4365:: with SMTP id nd5mr8889195ejb.56.1602162265101; Thu, 08 Oct 2020 06:04:25 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Thu, 8 Oct 2020 18:33:45 +0530 Message-ID: Subject: Re: [pgAdmin][RM4855] Renaming a file removes the file extension To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000b0118905b1287835" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b0118905b1287835 Content-Type: multipart/alternative; boundary="000000000000b0118705b1287833" --000000000000b0118705b1287833 Content-Type: text/plain; charset="UTF-8" Hi, Attached patch will add the .sql when saving a file and and format -> sql selected, no matter what the file name is. Please review. On Thu, Oct 8, 2020 at 6:27 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Sep 28, 2020 at 6:08 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix a bug where extension file extension is >> stripped on renaming a file. >> Pleasure review. >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Sr. Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --000000000000b0118705b1287833 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Attached patch will add the .sql = when saving a file and and format -> sql selected, no matter what the fi= le name is.
Please review.

On Thu, Oct 8, 2020 at = 6:27 PM Akshay Joshi <a= kshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.
On Mon, = Sep 28, 2020 at 6:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com<= /a>> wrote:
<= div dir=3D"ltr">
Hi Hackers,

Attached is the patch to fix a bug where extens= ion file extension is stripped on renaming a file.
Pleasure=C2=A0review.

--


--


--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Softwa= re Engineer | edbpostgres.com<= /font>
"Don't Complain about Heat, Plant a TREE&qu= ot;
--000000000000b0118705b1287833-- --000000000000b0118905b1287835 Content-Type: application/octet-stream; name="RM4855.part2.patch" Content-Disposition: attachment; filename="RM4855.part2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kg0u0ku70 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL21pc2MvZmlsZV9tYW5hZ2VyL3N0YXRpYy9qcy9jcmVh dGVfZGlhbG9ndWUuanMgYi93ZWIvcGdhZG1pbi9taXNjL2ZpbGVfbWFuYWdlci9zdGF0aWMvanMv Y3JlYXRlX2RpYWxvZ3VlLmpzCmluZGV4IDI2OGQ4ZDcyNy4uOGU1M2U4NWM2IDEwMDY0NAotLS0g YS93ZWIvcGdhZG1pbi9taXNjL2ZpbGVfbWFuYWdlci9zdGF0aWMvanMvY3JlYXRlX2RpYWxvZ3Vl LmpzCisrKyBiL3dlYi9wZ2FkbWluL21pc2MvZmlsZV9tYW5hZ2VyL3N0YXRpYy9qcy9jcmVhdGVf ZGlhbG9ndWUuanMKQEAgLTE1Nyw5ICsxNTcsNyBAQCBtb2R1bGUuZXhwb3J0cyA9ICBBbGVydGlm eS5kaWFsb2coJ2NyZWF0ZU1vZGVEbGcnLCBmdW5jdGlvbigpIHsKICAgICAgICAgICBzZXAgPSAn XFwnOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKCghbmV3RmlsZS5pbmNsdWRlcygnLicpIHx8 Ci0gICAgICAgICAgICBuZXdGaWxlLnNwbGl0KCcuJykucG9wKCkuaW5jbHVkZXMoc2VwKSkgJiYK LSAgICAgICAgICAgIGV4dCAhPSAnKicpIHsKKyAgICAgICAgaWYgKGV4dCAhPSAnKicpIHsKICAg ICAgICAgICBuZXdGaWxlID0gbmV3RmlsZSArICcuJyArIGV4dDsKICAgICAgICAgICAkKCcuc3Rv cmFnZV9kaWFsb2cgI3VwbG9hZGVyIC5pbnB1dC1wYXRoJykudmFsKG5ld0ZpbGUpOwogICAgICAg ICB9Cg== --000000000000b0118905b1287835--