Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haz9k-0000E0-Pv for pgadmin-hackers@arkaria.postgresql.org; Wed, 12 Jun 2019 09:02:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1haz9i-0007xX-EJ for pgadmin-hackers@arkaria.postgresql.org; Wed, 12 Jun 2019 09:02:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haz9h-0007xQ-Rk for pgadmin-hackers@lists.postgresql.org; Wed, 12 Jun 2019 09:02:54 +0000 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haz9W-0005CR-71 for pgadmin-hackers@postgresql.org; Wed, 12 Jun 2019 09:02:52 +0000 Received: by mail-lf1-x143.google.com with SMTP id a25so11476380lfg.2 for ; Wed, 12 Jun 2019 02:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zKONNA/FT9p+Ix0syhnWZHyWP8ZGHqFmRLJNu8mVKvw=; b=oD81Yq8r3rWPLO3GF0Z/Geol/NlmavutMMj+fbgeJOIeIcH3hxwloafeaY7wUZbaXU S/wG+6EHL56Yn0zwk7cCsKlVmEQGJxw3pkPOPMhBKgYhHUG4NTtJbRStB103nE5hzt6e n36WFJD4w2AndS1JjXgJsCi2w+TOrNFdk4skAdGmqWeISTnLg4LF7wXaJyGHwOmyPqza zNZ5gemlrFHMVrT6aEsaeoUBrtN+A1I1wDLeMQERyUJelrQfuzoq1Lo9PqIwbnpFRP6+ 0NQ8gMPUHElqlJRhZMD9USeluteu1jIYjA5XNEfYLpg/ybdG/SMKMJSCvQTShz2+mMvK EAcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zKONNA/FT9p+Ix0syhnWZHyWP8ZGHqFmRLJNu8mVKvw=; b=s5sPIpZRFGPch1ZSUQnOavBtLA9MoAn5lYZ8hgbj05rYLX0JGimAqfY7pEAk/EFU1z vWHm+NStpefxFP5V0+wqBvbIDIeHUtKAEPE+p0UphWB2sxk3B+kkuPJ+qMgfYo236AYF b6cKBWNDI1+4R8fQAAJTTsvaiPttfpjUSOdvzhqg9pUVDUyVehbpZFZX1FZ4b7FV55Qf HdaIYgSi+C2j0RP5J3w1wLCZl4w2LF8HVT7chGyZ4Fb7exC3CbXyUuUjVXZ5q8u7Y8iH 1oOvK4tSB7IYTbsQINbesH2pqMuSvLDG9PQs1M0NnJ9TkKEaYORq1iPeTEhCRtRtLMna 6ldg== X-Gm-Message-State: APjAAAWNR7a/9RdLHKWGRP70I32MLnB06DusHwyszjA2eCC0hYvjzI5t nXfD14Nv8QcHznmyc6bYdlD1GUxg0eBxnlsEcXV5mFIh X-Google-Smtp-Source: APXvYqwiuOlUAvFctLkxRISlXTo2P/meAVZ0ZSnXg5fLQm84R0btGomt/8kYi3F+by1kXzlIqdB7hNcB9XoivrEKRRE= X-Received: by 2002:a19:c14f:: with SMTP id r76mr30886687lff.70.1560330160261; Wed, 12 Jun 2019 02:02:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Wed, 12 Jun 2019 14:32:04 +0530 Message-ID: Subject: Re: [pgAdmin][RM3782] Debugger title should show connection and object details To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ef6a57058b1cac0a" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ef6a57058b1cac0a Content-Type: text/plain; charset="UTF-8" Hi, On Wed, Jun 12, 2019 at 1:54 PM Dave Page wrote: > Hi > > On Wed, Jun 12, 2019 at 7:03 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to add more information on connection details to >> debugger panel title and content title similar to Query Tool and View/Edit >> data. >> Adding the object name with arguments is not a good idea for the panel >> title, so I have kept to connection details similar to query tool. The >> content title will have all the details. >> >> Kindly review. >> > > I think not having the function name in there is a big limitation. > > With all this hacking going on, I think what we need to do is stop and > make this configurable as has been both requested by users and suggested by > us. > > I propose adding 2 preference options for each tab type. Each of these > would be a string with placeholders, one for the tab title, and one for the > tab tooltip. For example: > > - Query Tool > * Placeholders: %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST% > * Tab title default: %DATABASE% on %SERVER% > * Tooltip title default: Query Tool: %DATABASE% on %USERNAME%@%SERVER% > > - View Data > * Placeholders: %TABLE%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, > %PORT%, %HOST% > * Tab title default: %SCHEMA%.%TABLE% in %DATABASE% on %SERVER% > * Tooltip title default: View/Edit Data: %SCHEMA%.%TABLE% in %DATABASE% > on %USERNAME%@%SERVER% > > - Script > * Placeholders: %ACTION%, %OBJECT%, %SCHEMA%, %DATABASE%, %SERVER%, > %USERNAME%, %PORT%, %HOST% > * Tab title default: %ACTION% %SCHEMA%.%OBJECT% in %DATABASE% on %SERVER% > * Tooltip title default: %ACTION% Script: %SCHEMA%.%OBJECT% > in %DATABASE% on %USERNAME%@%SERVER% > > - Debugger > * Placeholders: %FUNCTION_ARGS%, %FUNCTION_NOARGS%, %SCHEMA%, > %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST% > * Tab title default: %FUNCTION_NOARGS%.%OBJECT% in %DATABASE% on %SERVER% > * Tooltip title default: Debugger: %SCHEMA%.%FUNCTION_ARGS% > in %DATABASE% on %USERNAME%@%SERVER% > > Or something like that. Thoughts? > Yes, this could be a nice feature. I think tooltip title customisation is not needed, we can just set it as prefix + tab title. Some users asked for in-place rename of tab title. I'm not sure if it is feasible to implement, but should we consider it also ? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --000000000000ef6a57058b1cac0a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

=
On Wed, Jun 12, 2019 at 1:54 PM Dave = Page <dpage@pgadmin.org> wro= te:
Hi

On Wed, Jun 12, 2019 at 7:03 AM Aditya Toshniwal <aditya.toshniw= al@enterprisedb.com> wrote:
Hi Hackers,

<= /div>
Attached is the patch to= add more information on connection details to debugger panel title and con= tent title similar to Query Tool and View/Edit data.
Adding the object name with arguments is not a= good=C2=A0idea for the panel title, so I have kept to connection details s= imilar to query tool. The content title will have all the details.

Kindly revie= w.

I think not havi= ng the function name in there is a big limitation.

With all this hacking going on, I think what we need to do is stop and mak= e this configurable as has been both requested by users and suggested by us= .

I propose adding 2 preference options for each t= ab type. Each of these would be a string with placeholders, one for the tab= title, and one for the tab tooltip. For example:

= - Query Tool
=C2=A0 * Placeholders: %DATABASE%, %SERVER%, %USERNA= ME%, %PORT%, %HOST%
=C2=A0 * Tab title default: %DATABASE% on %SE= RVER%
=C2=A0 * Tooltip title default: Query Tool: %DATABASE% on %= USERNAME%@%SERVER%

- View Data
=C2= =A0 * Placeholders: %TABLE%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, %P= ORT%, %HOST%
=C2=A0 * Tab title default: %SCHEMA%.%TABLE% in %DAT= ABASE% on %SERVER%
=C2=A0 * Tooltip title default: View/Edit Data= : %SCHEMA%.%TABLE% in=C2=A0%DATABASE% on %USERNAME%@%SERVER%

- Script
=C2=A0 * Placeholders: %ACTION%, %= OBJECT%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%
=C2=A0 * Tab title default: %ACTION% %SCHEMA%.%OBJECT% in %DATABASE% on = %SERVER%
=C2=A0 * Tooltip title default: %ACTION% Script: %SCHEMA= %.%OBJECT% in=C2=A0%DATABASE% on %USERNAME%@%SERVER%

- Debugger
=C2=A0 * Placeholders: %FUNCTION_ARGS%, = %FUNCTION_NOARGS%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOS= T%
=C2=A0 * Tab title default: %FUNCTION_NOARGS%.%OBJECT% in %DAT= ABASE% on %SERVER%
=C2=A0 * Tooltip title default: Debugger: %SCH= EMA%.%FUNCTION_ARGS% in=C2=A0%DATABASE% on %USERNAME%@%SERVER%
<= div>
Or something like that. Thoughts?
Yes, this could be a nice feature. I think tooltip title customisation i= s not needed, we can just set it as=C2=A0 prefix=C2=A0+ tab title. Some use= rs asked for in-place rename of tab title. I'm not sure if it is feasib= le to implement, but should we consider it also ?

--
Dav= e Page
Blog: h= ttp://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:= http://www.enter= prisedb.com
The Enterprise PostgreSQL Company


--
Adi= tya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"
--000000000000ef6a57058b1cac0a--