Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp8Kh-0007Ac-B1 for pgadmin-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 09:08:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gp8Kg-0008Jb-44 for pgadmin-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 09:08:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp8Kf-0008Hw-Mq for pgadmin-hackers@lists.postgresql.org; Thu, 31 Jan 2019 09:08:25 +0000 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp8KY-0001UQ-5K for pgadmin-hackers@postgresql.org; Thu, 31 Jan 2019 09:08:24 +0000 Received: by mail-lj1-x231.google.com with SMTP id x85-v6so2027008ljb.2 for ; Thu, 31 Jan 2019 01:08:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+m7e7acPi2zTttX2R/y9mNhhJJMvBUqqFzQLCXROkuc=; b=SEpch9A5NU9J0ad1vk+jBR0BuhKZlRzJHwEZ6WtsHrll8IYAvJnrB9aoyThfIZbBcH kdSKh17QGJ4+97/wvrXS08gxZaYuRMZ38iYqu0AGI45IJU8fmwOf0JR9gnugt/r4l/Jn LVuYnBvpnmGsyWcB1gkII4iD+Fp0oZlvuALnOnEjcSsftu0zgv7xoj2UMRu8xnjDt6mX yI5lYWDs5WfFkaUc90q8JeI6/xMbYqJcq0Dc0Qb5oQmCT04xwukP5u+pGbLF7islDiGe pGynKe8MGa7i9TFGKksqQk5LXkRc20mkCJaIkjS363x8nQ3Xe3qv/h1S2H2xbIUzdRoC VXsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+m7e7acPi2zTttX2R/y9mNhhJJMvBUqqFzQLCXROkuc=; b=pwSFpufgIRBksvCIFdnB6S34JMwHZ17m8PwABL2CiAxFe9csEO/+wDvtVrN/uWWa47 StuF+QzQryAh027AcuHDIrgQrnRwGSczSoARl+S9FQazYsfBdDZv6phcp120pZpVD7+s +28UJbkPkemDV8e2pZAEfiuUofaJEO6WP6QfNMRPNlWV0RXJBYYGxlwHQVfMgTH2R40t MqQrbyN77gyfhe3TDmzbgAmnKBc7QQRLqx54YeVYhZip4LAvzFKjAjcsf9fHqs7RbGCd SE3eFEu5I3mQdParcH8Nb3NyRWsYDGrSC8w2eNqZlA9wcXSO5cX7Jn+SpCRDih8Oanvn Ln/g== X-Gm-Message-State: AHQUAuYykWbX0tGy069iOvh5kzGPRYr3/Ulxlz2Q+wVX2G6pQCS3mjcv qkQSJFh74kLcOORgBXkNnJPVFvyziXNgE+3cH3XMww== X-Google-Smtp-Source: ALg8bN4azuR55D7Z0vt74iL4FSD2OBi1ojyEwSyQbpwr1kbMICfiiXpgh+UV/2wApERmwVcMw8F10r7JyjY2Pqo9NVk= X-Received: by 2002:a2e:2c02:: with SMTP id s2-v6mr10999364ljs.118.1548925695942; Thu, 31 Jan 2019 01:08:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Thu, 31 Jan 2019 14:38:04 +0530 Message-ID: Subject: Re: Remove hacky way to open/close the dropdown-submenu To: Ashesh Vashi Cc: "khushboo.vashi" , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e3fd8d0580bd5dee" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e3fd8d0580bd5dee Content-Type: text/plain; charset="UTF-8" Hi Ashesh, All works good, except one small change. Submenus should be closed if I press Esc and then reopen the menu. On Thu, Jan 31, 2019 at 11:32 AM Ashesh Vashi wrote: > Hi Aditya, > > On Tue, Jan 22, 2019 at 10:25 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Ashesh, >> >> I am getting a syntax error on bundle. >> After fixing that, please look into this scenario: >> Using keyboard shortcuts open object menu, for eg on table node. Go to >> any submenu using keyboard and go to any submenu and press enter. >> Now open object menu again using keyboard shortcut, the submenu remains >> open. It should be closed. >> > Please find the updated patch with all comments fixed. > Now - whenever the callback for the menu is called (menu toggling), it > will close the existing submenu(s) too. > > Please review it, and let me know. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi > * > > >> >> Everything looks fine to me except the above. >> >> >> On Tue, Jan 22, 2019 at 10:07 AM Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> Any update? >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> >>> >>> >>> On Thu, Jan 17, 2019 at 7:39 PM Ashesh Vashi < >>> ashesh.vashi@enterprisedb.com> wrote: >>> >>>> Hi Aditya/Khushboo, >>>> >>>> I can see a hacky way to open/close the dropdown-submenu in the menu.js >>>> file. >>>> I've followed a more general way to open/close any submenu in the >>>> dropdown list, instead of just 'Objects' menu. >>>> >>>> Can you please review it, and let me know your thoughts? >>>> Let me know if you have any other better approach. >>>> >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> >>>> >>> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" --000000000000e3fd8d0580bd5dee Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Ashesh,

All works good, except one small change. S= ubmenus should be closed if I press Esc and then reopen the menu.

On T= hu, Jan 31, 2019 at 11:32 AM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
Hi Aditya,

On Tue, Jan 22, 2019 at 10:25 AM Adi= tya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Ashe= sh,

I am getting a syntax error on bundle.= =C2=A0
After fixing that= ,=C2=A0 please look=C2=A0into this scenario:
Using keyboard shortcuts open object menu, for eg on t= able node. Go to any submenu using keyboard and go to any submenu and press= enter.
Now open object = menu again using keyboard shortcut, the submenu remains open. It should be = closed.
Please find the updated patch with all= comments fixed.
Now - whenever the callback for the menu is call= ed (menu toggling), it will close the existing submenu(s) too.
Please review it, and let me know.

<= p style=3D"margin:0pt">--

= Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvas= hi

=C2=A0<= /div>

Everything looks fine to me except the above.


On Tue, Jan 22,= 2019 at 10:07 AM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
=
An= y update?

=

--<= /p>

Thanks & Regards,=

Ashesh Vashi
EnterpriseDB INDIA: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">Enterprise Postgre= SQL Company


http://www.linkedin.com/in/asheshvashi



On Thu, Jan 17, 2019 at 7:3= 9 PM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Aditya/Khush= boo,

I can see a hacky way to open/close the dropdown-su= bmenu in the menu.js file.
I've followed a more general way t= o open/close any submenu in the dropdown list, instead of just 'Objects= ' menu.

Can you please review it, and let me k= now your thoughts?
Let me know if you have any other better appro= ach.
=C2=A0

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi



--
Thanks and Regards,
Aditya Toshniwal
<= div>Software Engineer |=C2=A0En= terpriseDB Software Solutions |=C2=A0Pu= ne
"Don't Complain= about Heat, Plant a tree"


--
Thanks and Rega= rds,
Aditya Toshniwa= l
Softw= are Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
&q= uot;Don't Complain about Heat, Plant a tree"
--000000000000e3fd8d0580bd5dee--