Re: Disabled or Not applicable Tabs design

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Zaid Shabbir <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Disabled or Not applicable Tabs design
Date: Fri, 21 Feb 2025 17:10:04 +0530
Message-ID: <CAM9w-_nXKgNC6KHKz_pTt+OvzTDu6GjVVEPU5+V4dn-07rOsvA@mail.gmail.com> (raw)
In-Reply-To: <CABCJe_X=J14OHfeOJ9S9X-qrF7c2k4X5gBJFNphoe+8C5aQ4AA@mail.gmail.com>
References: <CAM9w-_mAk-qGH=9Z9KUAE+2h-WM7+dgPHfX-vJ-7b3NY6wEQ_g@mail.gmail.com>
	<CA+OCxowh9naNcC9Kc8g+ej9XDEynAhOzFZU1zYxpwuzyc_FBSg@mail.gmail.com>
	<CAM9w-_mdCPXbS2DZUHaYZnr+p_OLvqnf+U0pbcAD28G29k8BEA@mail.gmail.com>
	<CAM9w-_=BTVyHPFoXSNfcCaamAhRxRyVFFNRnOPKMsFxpm-uGQw@mail.gmail.com>
	<CABCJe_WTdRKMVA=zKdgBYsKdP9VMPnESxPPpYGg5Scc6rpZt9A@mail.gmail.com>
	<CAM9w-_n_ChSmn33=tQKwBmSQ=2Jw=gxLA+rKuUG7N8wPm3kw7w@mail.gmail.com>
	<CABCJe_X=J14OHfeOJ9S9X-qrF7c2k4X5gBJFNphoe+8C5aQ4AA@mail.gmail.com>

Hi Zaid,

Changing tab design will need changes in the complete application. It also
needs to be discussed with everyone before changing it.
Anyway, it should not be part of the task I'm working on. You can open a
separate thread for discussions.

On Fri, Feb 21, 2025 at 5:03 PM Zaid Shabbir <[email protected]> wrote:

> Hello,
>
> Some other samples for the tabular window.
>
> [image: Screenshot 2025-02-21 at 4.29.30 PM.png]
>
> Aditiya it's just a suggestion, you can use the most suitable layout and
> colors.
>
> Regards,
> Zaid Shabbir
>
>
>
> On Fri, Feb 21, 2025 at 3:59 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Zaid,
>>
>> On Fri, Feb 21, 2025 at 4:26 PM Zaid Shabbir <[email protected]>
>> wrote:
>>
>>> Hello Aditya,
>>>
>>> The above design looks good to me. We could improve visibility by adding
>>> vertical and horizontal lines in a combination of blue, gray, and black.
>>> Blue represents the current active tab, gray indicates a disabled tab, and
>>> black signifies available clickable options.
>>>
>>> e.g.
>>>
>>> [image: Sample.png]
>>>
>> That doesn't match the pgAdmin design. The colors which you mentioned are
>> already being used.
>>
>>>
>>> Regards,
>>>
>>> Zaid Shabbir
>>>
>>> On Fri, Feb 21, 2025 at 3:32 PM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Updated design:
>>>>
>>>> [image: image.png]
>>>>
>>>> On Fri, Feb 21, 2025 at 3:56 PM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> On Fri, Feb 21, 2025 at 3:21 PM Dave Page <[email protected]> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, 21 Feb 2025 at 09:38, Aditya Toshniwal <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Hackers,
>>>>>>>
>>>>>>> I've been working on a new feature to restore a plain SQL using the
>>>>>>> pgAdmin restore dialog. Internally, it will select pg_restore or psql based
>>>>>>> on the format.
>>>>>>>
>>>>>>> Now, when restoring plain format the tabs like Data Options,
>>>>>>> Query Options are not applicable. So instead of going and disabling all the
>>>>>>> fields under these tabs, I think we can simply disable the complete tab.
>>>>>>>
>>>>>>> I've come up with the following UI design for the disabled tabs. The
>>>>>>> tabs will enable/disable based on the format selected.
>>>>>>>
>>>>>>> Please share your feedback on this.
>>>>>>>
>>>>>>>
>>>>>>> [image: image.png]
>>>>>>>
>>>>>>
>>>>>> Normally when something is disabled, it is simply greyed out and made
>>>>>> to not respond to input. Why not do the same here instead of designing a
>>>>>> new way of indicating disabled state?
>>>>>>
>>>>> I thought of adding an icon for better accessibility. Greying is
>>>>> pretty straightforward.
>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>> pgEdge: https://www.pgedge.com
>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Thanks,
>>>>> Aditya Toshniwal
>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>>> <https://www.enterprisedb.com/;
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>> <https://www.enterprisedb.com/;
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>> <https://www.enterprisedb.com/;
>> "Don't Complain about Heat, Plant a TREE"
>>
>

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [image/png] image.png (65.5K, 3-image.png)
  download | view image

  [image/png] image.png (82.5K, 4-image.png)
  download | view image

  [image/png] Sample.png (19.9K, 5-Sample.png)
  download | view image

  [image/png] Screenshot 2025-02-21 at 4.29.30 PM.png (105.1K, 6-Screenshot%202025-02-21%20at%204.29.30%20PM.png)
  download | view image

view thread (12+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Disabled or Not applicable Tabs design
  In-Reply-To: <CAM9w-_nXKgNC6KHKz_pTt+OvzTDu6GjVVEPU5+V4dn-07rOsvA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox