Re: Open preferences in new tab

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Usman Khan <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Open preferences in new tab
Date: Mon, 26 May 2025 12:12:14 +0530
Message-ID: <CAM9w-_nXmM+L6aJQ_UEd6iK4QFtdU0GM10YRKkbdtFPqa6jDEQ@mail.gmail.com> (raw)
In-Reply-To: <CANVC+RFPXp4P+YL8g3L2Pp7KrAHHf9kzaX3wSbodnwd9UkBR=Q@mail.gmail.com>
References: <CAM9w-_nxDRh-pmOVZ42HBKzfs_SkkajdSRLf200i1C0jGV2-vw@mail.gmail.com>
	<CANVC+RHNgmcqM3Ft=7BzaUjyE39+qvfo4VfEnGVFbFC-mg8pkQ@mail.gmail.com>
	<CAM9w-_=oLEr+OQXKH=sQLek5mgXtUH0XBWzdG=vfU63j=giZKw@mail.gmail.com>
	<CANVC+RFjLrQZV6CAGswPgNOHVxy+tcMk06mkZY5=ZNNURGFPYw@mail.gmail.com>
	<CAM9w-_nQA4P+QNNzY_UnkNBodgrL2GaBLsDxnacP0y5t-r2dYw@mail.gmail.com>
	<CANVC+RGHs7PBY4f4XAnApw1z4P9PSHHkvwNtBy1FSFz=PhN8yw@mail.gmail.com>
	<CAM9w-_n+T4TOuCRrqGz+bH7uyxMQ4q-2vgUWCzH4SQNzwT=Rtg@mail.gmail.com>
	<CANVC+RFPXp4P+YL8g3L2Pp7KrAHHf9kzaX3wSbodnwd9UkBR=Q@mail.gmail.com>

Hi Usman,

No we will not highlight, we will only show filtered items like VSCode.

On Mon, May 26, 2025 at 12:08 PM Usman Khan <[email protected]> wrote:

> Hi Aditya,
>
> Let me clarify it with the following example, if a user searches for
> 'Support screen readers', if this option or text exists in more than one
> preferences in the left panel, it should highlight or filtered them(show
> them in the left panel) and the right panel should show all the fields for
> selected option in the left panel(*In your reply above it gave me
> impression you only want to show matching filed/fields in the right panel
> and not all*.).
>
> The following pictorial examples from PyCharm is given
>
>    1. Where the searched text is found only in one left panel
>    options/preferences
>    2. Where the searched text is found in more than one
>    options/preferences and now user can browse them to find exact option
>
>
> [image: image.png]
>
> [image: image.png]
>
>
> On Mon, May 26, 2025 at 9:59 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Usman,
>>
>> On Sat, May 24, 2025 at 6:39 PM Usman Khan <[email protected]> wrote:
>>
>>>
>>>
>>> On Thu, May 22, 2025 at 4:33 PM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Usman,
>>>>
>>>> On Thu, May 22, 2025 at 4:45 PM Usman Khan <[email protected]> wrote:
>>>>
>>>>> Okay.
>>>>>
>>>>> In my opinion, filtering the items only in the left panel would be
>>>>> enough - the user can browse through  them one by one to find what he wants.
>>>>>
>>>>
>>>> Then there is no point in implementing search. I believe search should
>>>> work for labels and help messages.
>>>>
>>> If a user wants to update multiple fields for a particular option in the
>>> left panel then searching one field and only listing that in the right
>>> panel would not be enough. I think it would need further discussion then
>>> for this implementation, is there any ticket created for this ? Can you
>>> please share it?
>>>
>>
>> What's the point of searching for the left tree where it is easily
>> accessible and right in front of you? Search will help on the actual
>> preferences which are not visible until you click the tree item.
>> Let me be clear, the tree will not hide. It will show only those items
>> which contains the filtered preferences similar to PyCharm or VSCode.
>>
>> then if a user wants to
>>>>
>>>
>>>>> On Thu, May 22, 2025 at 3:08 PM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Usman,
>>>>>>
>>>>>> I'm not entirely sure how it will work since there can be
>>>>>> limitations. But what I'm trying to do is upon typing for search:
>>>>>> 1. Only filtered items will be visible.
>>>>>> 2. Left tree will show only those items which have the filtered items.
>>>>>>
>>>>>> On Thu, May 22, 2025 at 1:16 PM Usman Khan <[email protected]> wrote:
>>>>>>
>>>>>>> Hi Aditya,
>>>>>>>
>>>>>>> This is a useful feature and much needed as well, Can you briefly
>>>>>>> explain how the search would work, for example if someone search for a term
>>>>>>> like 'maximum', will it highlight all matching options in the left panel or
>>>>>>> would it jump to the first matched option?
>>>>>>>
>>>>>>> On Thu, May 22, 2025 at 12:02 PM Aditya Toshniwal <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi Hackers,
>>>>>>>>
>>>>>>>> I am adding a search box to the preferences. I was also thinking of
>>>>>>>> opening preferences in a tab instead of dialog. Advantages being - less
>>>>>>>> scroll and more space, consistency with other features like user
>>>>>>>> management, processes.
>>>>>>>> Below is a rough design. Please let me know your thoughts.
>>>>>>>>
>>>>>>>> [image: image.png]
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Thanks,
>>>>>>>> Aditya Toshniwal
>>>>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>>>>>> <https://www.enterprisedb.com/;
>>>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Thanks,
>>>>>> Aditya Toshniwal
>>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>>>> <https://www.enterprisedb.com/;
>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>> <https://www.enterprisedb.com/;
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>> <https://www.enterprisedb.com/;
>> "Don't Complain about Heat, Plant a TREE"
>>
>

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [image/png] image.png (371.4K, 3-image.png)
  download | view image

  [image/png] image.png (186.2K, 4-image.png)
  download | view image

  [image/png] image.png (237.7K, 5-image.png)
  download | view image

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Open preferences in new tab
  In-Reply-To: <CAM9w-_nXmM+L6aJQ_UEd6iK4QFtdU0GM10YRKkbdtFPqa6jDEQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox