public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4320] PgAdmin 4 fails to accept ssh password
Date: Tue, 25 Jun 2019 11:29:48 +0530
Message-ID: <CAM9w-_ncTLyZBFBHrX9Mycb1fLPT7Mc6WWf=_PZW6f=uM2C4RA@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDe9PYRzmDKR_by81Q=VFK8OSswvVQCZ9dTensvGDd-rLw@mail.gmail.com>
References: <CAM9w-_mUCS=uqoqvV9kZvyHn2nGyLjHuG8Z5di0B=La_xugQ1g@mail.gmail.com>
<CANxoLDe9PYRzmDKR_by81Q=VFK8OSswvVQCZ9dTensvGDd-rLw@mail.gmail.com>
Hi Hackers,
Based on the latest comments on the RM,
https://redmine.postgresql.org/issues/4320#change-16998 - Replaced
server_manager.py on my Win 10 system - could login and run queries, etc -
but eventually got "create_ssh_tunnel() missing 1 required positional
argument: 'tunnel_password'",attached is the patch to fix the issue.
Kindly review and consider this for the upcoming release.
On Wed, Jun 5, 2019 at 12:11 PM Akshay Joshi <[email protected]>
wrote:
> Thanks patch applied.
>
> On Wed, Jun 5, 2019 at 10:44 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix a regression of Master Password #4184 where
>> SSH tunnel connection using password is failing.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] RM4320.part2.patch (848B, 3-RM4320.part2.patch)
download | inline diff:
diff --git a/web/pgadmin/utils/driver/psycopg2/server_manager.py b/web/pgadmin/utils/driver/psycopg2/server_manager.py
index ae1cc709..8ae46c2e 100644
--- a/web/pgadmin/utils/driver/psycopg2/server_manager.py
+++ b/web/pgadmin/utils/driver/psycopg2/server_manager.py
@@ -348,7 +348,9 @@ WHERE db.oid = {0}""".format(did))
# Check SSH Tunnel needs to be created
if self.use_ssh_tunnel == 1 and \
not self.tunnel_created:
- status, error = self.create_ssh_tunnel()
+ status, error = self.create_ssh_tunnel(
+ self.tunnel_password
+ )
# Check SSH Tunnel is alive or not.
self.check_ssh_tunnel_alive()
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM4320] PgAdmin 4 fails to accept ssh password
In-Reply-To: <CAM9w-_ncTLyZBFBHrX9Mycb1fLPT7Mc6WWf=_PZW6f=uM2C4RA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox