MIME-Version: 1.0
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Fri, 10 Apr 2020 11:48:52 +0530
Message-ID: 
 <CAM9w-_ndFNQshhg5QT9wUWL9TjB_k9QPC_XeiQ7UjXuj0NXYVQ@mail.gmail.com>
Subject: [pgAdmin][RM4969] JSONB and JSON field editing
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000036b07805a2e9b76b"
Precedence: bulk

--00000000000036b07805a2e9b76b
Content-Type: multipart/alternative; boundary="00000000000036b07705a2e9b769"

--00000000000036b07705a2e9b769
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

Attached is the patch fix issue for jsonb and json field editing. Making
the field blank throws a validation error. The patch will set json, jsonb
to null when set to blank.

Please review.

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

--00000000000036b07705a2e9b769
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">Hi Hackers,</div><div class=3D"gmail_default" style=3D"font-fam=
ily:verdana,sans-serif"><br></div><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif">Attached is the patch fix issue for jsonb and =
json field editing. Making the field blank throws a validation error. The p=
atch will set json, jsonb to null when set to blank.</div><div class=3D"gma=
il_default" style=3D"font-family:verdana,sans-serif"><br></div><div class=
=3D"gmail_default" style=3D"font-family:verdana,sans-serif">Please review.<=
/div><div><br></div>-- <br><div dir=3D"ltr" class=3D"gmail_signature" data-=
smartmail=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><=
div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><font size=3D"2=
" color=3D"#000000" face=3D"verdana, sans-serif">Thanks and Regards,</font>=
<div><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2" col=
or=3D"#000000" face=3D"verdana, sans-serif">Aditya Toshniwal</font></span><=
/div><div><font face=3D"verdana, sans-serif"><span style=3D"background-colo=
r:rgb(255,255,255)"><font size=3D"2" color=3D"#000000">pgAdmin Hacker | Sr.=
 Software Engineer |=C2=A0EnterpriseDB India |=C2=A0</font></span><span sty=
le=3D"color:rgb(0,0,0)">Pune</span></font></div><div><font color=3D"#38761d=
" face=3D"verdana, sans-serif" size=3D"1">&quot;Don&#39;t Complain about He=
at, Plant a TREE&quot;</font></div></div></div></div></div></div></div></di=
v></div></div></div></div>

--00000000000036b07705a2e9b769--

--00000000000036b07805a2e9b76b
Content-Type: application/octet-stream; name="RM4969.patch"
Content-Disposition: attachment; filename="RM4969.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_k8tsusrb0>
X-Attachment-Id: f_k8tsusrb0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9zbGlja2dyaWQvZWRpdG9ycy5qcyBi
L3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9zbGlja2dyaWQvZWRpdG9ycy5qcwppbmRleCAxZGNjMjlk
OWIuLjE2NDdkNGI4MiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL2pzL3NsaWNrZ3Jp
ZC9lZGl0b3JzLmpzCisrKyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9zbGlja2dyaWQvZWRpdG9y
cy5qcwpAQCAtMTEwLDcgKzExMCw3IEBAIGltcG9ydCBnZXR0ZXh0IGZyb20gJ3NvdXJjZXMvZ2V0
dGV4dCc7CiAgICAgICAgIGdyaWQuY29waWVkX3Jvd3Nbcm93XVtjZWxsXSA9IDE7CiAgICAgICB9
CiAgICAgfSBlbHNlIHsKLSAgICAgIGlmKGNvbHVtbl90eXBlID09PSAnanNvbmInKSB7CisgICAg
ICBpZihjb2x1bW5fdHlwZSA9PT0gJ2pzb25iJyAmJiBzdGF0ZSAhPSBudWxsKSB7CiAgICAgICAg
IGl0ZW1bYXJncy5jb2x1bW4uZmllbGRdID0gSlNPTkJpZ051bWJlci5zdHJpbmdpZnkoSlNPTkJp
Z051bWJlci5wYXJzZShzdGF0ZSkpOwogICAgICAgfSBlbHNlIHsKICAgICAgICAgaXRlbVthcmdz
LmNvbHVtbi5maWVsZF0gPSBzdGF0ZTsKQEAgLTM2MSw3ICszNjEsNyBAQCBpbXBvcnQgZ2V0dGV4
dCBmcm9tICdzb3VyY2VzL2dldHRleHQnOwogICAgIHRoaXMubG9hZFZhbHVlID0gZnVuY3Rpb24o
aXRlbSkgewogICAgICAgdmFyIGRhdGEgPSBkZWZhdWx0VmFsdWUgPSBpdGVtW2FyZ3MuY29sdW1u
LmZpZWxkXTsKICAgICAgIC8qIElmIGpzb25iIG9yIGFycmF5ICovCi0gICAgICBpZihhcmdzLmNv
bHVtbi5jb2x1bW5fdHlwZV9pbnRlcm5hbCA9PT0gJ2pzb25iJyAmJiAhQXJyYXkuaXNBcnJheShk
YXRhKSkgeworICAgICAgaWYoYXJncy5jb2x1bW4uY29sdW1uX3R5cGVfaW50ZXJuYWwgPT09ICdq
c29uYicgJiYgIUFycmF5LmlzQXJyYXkoZGF0YSkgJiYgZGF0YSAhPSBudWxsKSB7CiAgICAgICAg
IGRhdGEgPSBKU09OQmlnTnVtYmVyLnN0cmluZ2lmeShKU09OQmlnTnVtYmVyLnBhcnNlKGRhdGEp
LCBudWxsLCA0KTsKICAgICAgIH0gZWxzZSBpZiAoQXJyYXkuaXNBcnJheShkYXRhKSkgewogICAg
ICAgICB2YXIgdGVtcCA9IFtdOwpAQCAtNDA2LDcgKzQwNiw5IEBAIGltcG9ydCBnZXR0ZXh0IGZy
b20gJ3NvdXJjZXMvZ2V0dGV4dCc7CiAgICAgICBpZihhcmdzLmNvbHVtbi5jb2x1bW5fdHlwZV9p
bnRlcm5hbCA9PT0gJ2pzb25iJyB8fAogICAgICAgICAgIGFyZ3MuY29sdW1uLmNvbHVtbl90eXBl
X2ludGVybmFsID09PSAnanNvbicpIHsKICAgICAgICAgdHJ5IHsKLSAgICAgICAgICBKU09OLnBh
cnNlKCRpbnB1dC52YWwoKSk7CisgICAgICAgICAgaWYoJGlucHV0LnZhbCgpICE9ICcnKXsKKyAg
ICAgICAgICAgIEpTT04ucGFyc2UoJGlucHV0LnZhbCgpKTsKKyAgICAgICAgICB9CiAgICAgICAg
IH0gY2F0Y2goZSkgewogICAgICAgICAgICRpbnB1dC5hZGRDbGFzcygncGctdGV4dC1pbnZhbGlk
Jyk7CiAgICAgICAgICAgcmV0dXJuIHsK
--00000000000036b07805a2e9b76b--