public inbox for [email protected]  

help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed
Date: Fri, 18 Jan 2019 16:28:25 +0530
Message-ID: <CAM9w-_ndk-Cwsz_tNBHeOQLNi86fZ6PCdjj9ia0=LVVJYqLraA@mail.gmail.com> (raw)

Hi Hackers,

Attached is the patch to fix correct the buttons for json/jsonb type column
data editing.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


Attachments:

  [application/octet-stream] RM3891.patch (1.4K, 3-RM3891.patch)
  download | inline diff:
diff --git a/web/pgadmin/preferences/static/js/preferences.js b/web/pgadmin/preferences/static/js/preferences.js
index 88a50bd1..058a9d07 100644
--- a/web/pgadmin/preferences/static/js/preferences.js
+++ b/web/pgadmin/preferences/static/js/preferences.js
@@ -375,9 +375,9 @@ define('pgadmin.preferences', [
             dialogContentCleanup();
 
             $container.append(
-              '<div class=\'pg-el-3 preferences_tree aciTree\'></div>'
+              '<div class=\'pg-el-md-3 preferences_tree aciTree\'></div>'
             ).append(
-              '<div class=\'pg-el-9 preferences_content\'>' +
+              '<div class=\'pg-el-md-9 preferences_content\'>' +
               gettext('Category is not selected.') +
               '</div>'
             );
diff --git a/web/pgadmin/static/js/slickgrid/editors.js b/web/pgadmin/static/js/slickgrid/editors.js
index 86f460ec..18bba9e9 100644
--- a/web/pgadmin/static/js/slickgrid/editors.js
+++ b/web/pgadmin/static/js/slickgrid/editors.js
@@ -307,8 +307,8 @@
       $input = getTextArea().appendTo($wrapper);
       $buttons = getButtons(true).appendTo($wrapper);
 
-      $buttons.find('button:first').on('click', this.save);
-      $buttons.find('button:last').on('click', this.cancel);
+      $buttons.find('button:first').on('click', this.cancel);
+      $buttons.find('button:last').on('click', this.save);
       $input.on('keydown', this.handleKeyDown);
 
       scope.position(args.position);

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed
  In-Reply-To: <CAM9w-_ndk-Cwsz_tNBHeOQLNi86fZ6PCdjj9ia0=LVVJYqLraA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox