Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1Srd-0006pN-9D for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jan 2021 11:38:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l1Srb-0006np-Dl for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jan 2021 11:38:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1Sra-0006mp-OH for pgadmin-hackers@lists.postgresql.org; Mon, 18 Jan 2021 11:38:27 +0000 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l1SrW-0006bO-2m for pgadmin-hackers@postgresql.org; Mon, 18 Jan 2021 11:38:25 +0000 Received: by mail-lj1-x22c.google.com with SMTP id n8so9066219ljg.3 for ; Mon, 18 Jan 2021 03:38:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oBtdzfwdS0pX9o8qh03uNnI3EEzEVFPxYrDd6PHAjcI=; b=HmXhsPSQQePwfgdEScEes899mkuNet85kGF+va3SHZ35CyeUWry7S95blM7SMqsgOp 6AUtojUoKKty3jTz9QjizRrwekyvNewxUHjIoi+T6iSV4cJFPMp0x8d9FigIbBisP8Ws r/gYQmJ5SjNU/8EGSFdfomWvfSY3WXRGAfKU7Ds1AdT68RIHPo0IK/PxB2WvfdhrHIcn EC0CuhfUNBh9i6kzUwc3zoiTBsUnKscR2fW1pJxRqZpddtwbO578Fk/JnsUM6ETTm3RH Wgq2uadYbOBdNE7PPiVw3luTezaYSPmUTlz8CZFUERs7pu+A64Q6Xe++JlXIYaGSThx5 BpjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oBtdzfwdS0pX9o8qh03uNnI3EEzEVFPxYrDd6PHAjcI=; b=kuxkAYR8QOGvCVHjgReiq3Y6J3K+KodyEtbYtf7k0cOvhAX+kr0lM3CSqulBWYETDl ocM2HzkWwsM5e2XX9lQ7Y9B+6jeR//F3mtPuaImsn/dRrE7We+IhdhmHjThLDL8inLc3 I7Nugc4i52exKyHSAEQ8vjZRLaMeu130KlnTki4MMP4vOj581oJeo+TF9iYy8nGLSRud tocwrRQIxiqByhHkX8M+l2TPCmejw+P8HFqan90owSv11ohUW1Gwg+Dq8yu2zR+kgxSo GTfqowDTPl2F2te7pw+ly1rpcEIt3ZSdks3hHH3aTn0eNV7r/zvLd/MTG8hRWkF9tJgD ithw== X-Gm-Message-State: AOAM532mEUVyRl+JphWPIQHOp0g4zzmxKDXgLsfoj+ZvZeMi1zujk0xF Eh7QMNqBOLHBjzp+cwSkdfe38AYqhTnzcxTac4xSWLJom2FdAT+P6JcZW7YfJuUxmEu8/fsT3Kz IyDVRSBLgmxJ67I/5SfaB8iNLFpOeX3Y2Ypmb1XbX4ZdPwtjGB0/sBW6Lmj/80Wm0Q8F69YztoK 90Z2GdsD45ciRAldmxXBa6S7xj7801Vz5jc11M3JG/DtQfmjS2D45DFP//Vw== X-Google-Smtp-Source: ABdhPJy+O3ZWr76X9WtdlgmwSGFoxhVCV8kShoWFhXQgvFRJ3NujxNyOLlQ6gAFvZJPZ/JLzBAbTze6zRtHsV3cmfhQ= X-Received: by 2002:a05:651c:1129:: with SMTP id e9mr9902910ljo.135.1610969899170; Mon, 18 Jan 2021 03:38:19 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Mon, 18 Jan 2021 17:07:42 +0530 Message-ID: Subject: Re: [pgAdmin][RM1802] ERD Tool (Beta) To: Akshay Joshi Cc: Khushboo Vashi , pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000095a51105b92b28f2" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000095a51105b92b28f2 Content-Type: multipart/alternative; boundary="00000000000095a50f05b92b28f0" --00000000000095a50f05b92b28f0 Content-Type: text/plain; charset="UTF-8" OK, So the changes have worked. But still failing at one more place. Attached the patch fixes it. On Mon, Jan 18, 2021 at 4:40 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Jan 18, 2021 at 2:58 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi, >> >> The jasmine test cases are working fine on my local machine. The test >> cases are successful on jenkins other than on linux, not sure why. >> I have made some fixes by looking at the log. Please review and try. >> >> On Mon, Jan 18, 2021 at 1:10 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Mon, Jan 18, 2021 at 10:34 AM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Akshay, >>>> >>>> I forgot to remove few of the dependencies which are not required as of >>>> now (may be in future). Attached patch removes those dependencies from >>>> package.json. >>>> >>>> On Sat, Jan 16, 2021 at 5:08 PM Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Thanks, patch applied. >>>>> >>>>> On Fri, Jan 15, 2021 at 7:01 PM Aditya Toshniwal < >>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> I've fixed the issues. You can find the comments inline. >>>>>> I've also added PropTypes for the components for increased validation. >>>>>> >>>>>> On Tue, Jan 12, 2021 at 12:18 PM Khushboo Vashi < >>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Aditya, >>>>>>> >>>>>>> The functionalities and the code looks good to me, however some of the comments as below: >>>>>>> >>>>>>> >>>>>>> - Correct the comments at some places (3 occurrences found in /erd/__init__.py) which mention Schema diff instead of ERD. >>>>>>> >>>>>>> Some comments in the JS/JSX file regarding components/functions (For example, IconButton (forwardRef), Bodywidget etc.) would >>>>>>> >>>>>>> be great help as we all are new to React. >>>>>>> >>>>>>> Done. Added comments to the components. >>>>>> >>>>>>> >>>>>>> - Remove the unused imports (for ex bad_request) in /erd/__init__.py >>>>>>> >>>>>>> Removed. >>>>>> >>>>>>> >>>>>>> - Remove commented code >>>>>>> >>>>>>> # req_args = request.args >>>>>>> # if ('recreate' in req_args and >>>>>>> # req_args['recreate'] == '1'): >>>>>>> # connect = False >>>>>>> >>>>>>> Removed. >>>>>> >>>>>>> >>>>>>> - TableNode.jsx, below two lines can be combined. >>>>>>> >>>>>>> import { PortModelAlignment, DefaultNodeModel } from >>>>>>> '@projectstorm/react-diagrams'; >>>>>>> import { PortWidget } from '@projectstorm/react-diagrams'; >>>>>>> >>>>>>> Done. >>>>>> >>>>>>> >>>>>>> - onImageClick function in BodyWidget.jsx is no use I think, so it should be removed. >>>>>>> >>>>>>> I wanted to keep the code as it will be used in future. Anyway, I've >>>>>> removed the code. >>>>>> >>>>>>> >>>>>>> - I got some console errors while adding/editing tables. Refer to the attached screenshot. >>>>>>> >>>>>>> I tried but I didn't get any. Looking at the screenshot, the error >>>>>> is from the underlying library. Can't do much in this. >>>>>> >>>>>>> >>>>>>> - In the column Edit Mode, while deleting the primary key, it gives the error, which does not go away with any further modifications. >>>>>>> >>>>>>> Fixed. >>>>>> >>>>>>> >>>>>>> - While generating the SQL, if the server is disconnected, a proper error message should be thrown, right now some server side error is coming. >>>>>>> >>>>>>> It will show connection lost error now. Fixed. >>>>>> >>>>>>> >>>>>>> - Please remove ... from the menu title (New ERD Project(Beta)...) as it is not opening a dialog. >>>>>>> >>>>>>> Done. >>>>>> >>>>>>> >>>>>>> - For large data sets, generate ERD hangs. >>>>>>> >>>>>>> It shows the spinner and waits for the response to come from the >>>>>> back end. I've used the existing table fetching code which is used at other >>>>>> places. I'll create an RM to improve the back end code for fetching the >>>>>> tables data which will help the schema diff tool as well. >>>>>> >>>>>>> >>>>>>> - Opening the ERD panel in a new window is not working, it opens in the same tab even if you have set the Preference "Open in new browser tab" to True. >>>>>>> >>>>>>> Fixed. Added the setting in "Tab settings". >>>>>> >>>>>>> >>>>>>> - No shortcut is provided to open the ERD Tool. >>>>>>> >>>>>>> A shortcut is helpful if we are using it frequently. ERD tool won't >>>>>> be used that frequently. We already have a limited number of keys >>>>>> available for shortcuts. I think we should roll out without shortcut for >>>>>> now. If there is a user demand for it then we can think of adding it. >>>>>> >>>>>>> >>>>>>> - SonarQube fixes required. >>>>>>> >>>>>>> Fixed. >>>>>> >>>>>>> >>>>>>> - >>>>>>> >>>>>>> *Suggestion:* >>>>>>> >>>>>>> While removal of the FK link, If any of the table is selected, it is being deleted with FK link. >>>>>>> Either we should warn the user OR make 2 different buttons for FK removal and table removal as the user may be confused if the selected table is also removed with the FK. >>>>>>> >>>>>>> I've added a confirmation dialog which will show the number of >>>>>> tables and links selected. This way user will know what he has selected >>>>>> before deleting. >>>>>> >>>>>>> *Observations:* >>>>>>> >>>>>>> Lodash has been used in this module in place of Underscore, though >>>>>>> the dependency is already introduced by another module, >>>>>>> but we have mentioned it in the package.json file, which is somewhat >>>>>>> not convincing to me. >>>>>>> Lodash is more advanced than Underscore but we should pick anyone as >>>>>>> it will be easy to manage. >>>>>>> >>>>>>> TL;DR; we cannot. >>>>>> lodash is a peer dependency for react-diagrams (and some existing >>>>>> modules in pgAdmin) so it will come to package.json without choice. We >>>>>> cannot remove underscore because it is a dependency of backbone. Underscore >>>>>> is outdated, and I cannot migrate the complete pgAdmin code. So, I >>>>>> decided to go with 100/0 method. All the new codes will use lodash only as >>>>>> we'll phase out underscore with time. Just like jQuery vs ReactJS. >>>>>> >>>>>>> >>>>>>> >>>>>>> Table dialog code is duplicate of the table node, as it was >>>>>>> difficult to extend it because it was attached to the tree. >>>>>>> So, we need to keep in mind that while implementing React in >>>>>>> pgAdmin, the nodes should be properly detached from the tree itself, so we >>>>>>> can reuse it. >>>>>>> >>>>>>> Yes. I agree. We need to separate out data source from UI going >>>>>> forward with React. >>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Khushboo >>>>>>> >>>>>>> >>>>>>> On Mon, Dec 28, 2020 at 10:53 AM Khushboo Vashi < >>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Fri, Dec 25, 2020 at 4:34 PM Akshay Joshi < >>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Khushboo, >>>>>>>>> >>>>>>>>> Can you please review it? >>>>>>>>> >>>>>>>>> On it. >>>>>>>> >>>>>>>>> On Fri, Dec 25, 2020 at 3:31 PM Aditya Toshniwal < >>>>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi Hackers, >>>>>>>>>> >>>>>>>>>> Attached patch introduces ERD Tool(Beta) to pgAdmin. Below are >>>>>>>>>> the details: >>>>>>>>>> 1) Create a diagram from scratch or generate for an existing DB. >>>>>>>>>> 2) Generate "Create" DDL from the diagram. >>>>>>>>>> 3) Save the diagram and resume it later. >>>>>>>>>> 4) Supports basic table fields, one-to-many relationships, >>>>>>>>>> many-to-many relationships, adding notes. >>>>>>>>>> 5) Test cases added with 75-80% test coverage. >>>>>>>>>> >>>>>>>>>> Please review. >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Thanks, >>>>>>>>>> Aditya Toshniwal >>>>>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>>>>>> >>>>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Thanks & Regards* >>>>>>>>> *Akshay Joshi* >>>>>>>>> *pgAdmin Hacker | Principal Software Architect* >>>>>>>>> *EDB Postgres * >>>>>>>>> >>>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>>> >>>>>>>> >>>>>> >>>>>> -- >>>>>> Thanks, >>>>>> Aditya Toshniwal >>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>> >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> *pgAdmin Hacker | Principal Software Architect* >>>>> *EDB Postgres * >>>>> >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>> >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --00000000000095a50f05b92b28f0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
OK, So the changes have worked. But still failing at one more p= lace.
Attached the patch fixes it.

On Mon, Jan 18, 2021 at 4:40 PM Aks= hay Joshi <akshay.joshi= @enterprisedb.com> wrote:
Thanks, patch applied.

On Mon, Jan 18, 202= 1 at 2:58 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wro= te:
= Hi,

The jasmine test cases are working=C2=A0fine on my local machine. = The test cases are successful on jenkins other than on linux, not sure why.=
I have made some fixes by looking at the log. Please review and try.
=

= On Mon, Jan 18, 2021 at 1:10 PM Akshay Joshi <akshay.joshi@enterprisedb.com&= gt; wrote:
Thanks, patch applied.

=
On Mon, Jan 18, 2021 at 10:34 AM Adit= ya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Akshay,

=
I forgot to remove few of the dependencies which are not required as of no= w (may be in future). Attached patch removes those dependencies from packag= e.json.

On Sat, Jan 16, 2021 at 5:08 PM Akshay Joshi <akshay.joshi@enterpri= sedb.com> wrote:
Thanks, patch applied.

On Fri, Jan 15, 2021 at 7:01= PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

I've fixed the issues. Y= ou can find the comments inline.
I'= ;ve also added PropTypes for the components for increased validation.

On Tue, Jan 12, 2021 at 12:18 PM Khushboo Vashi <khushboo.vashi@ent= erprisedb.com> wrote:
Hi Aditya,
The functionalities and t=
he code looks good to me, however some of the comments as below:
  • =
Correct the comments at some places (3 occurrences found  in /erd/__init__.py)  which mention Schema diff i=
nstead of ERD.
Some comments in the JS/JSX fi=
le regarding components/functions (For example, IconButton (forwardRef), Bo=
dywidget etc.) would
be great help as we all are new to React.
Done. Added comments to the compo= nents.
  • Remove the unused imports (for ex bad_request) in=
 /erd/__init__.py
Removed.<= /span>=C2=A0
  • Remove commented code
# req_args =3D request.args
# if ('recreate&#= 39; in req_args and
# =C2=A0 =C2=A0 req_args['recreate'] =3D=3D = '1'):
# =C2=A0 =C2=A0 connect =3D False
<= /div>
Removed.=C2=A0
  • <=
font face=3D"arial, sans-serif">TableNode.jsx, below two lines can be combi=
ned.
import { PortModelAl= ignment, DefaultNodeModel } from '@projectstorm/react-diagrams';import { PortWidget } from '@projectstorm/react-diagrams';<= /blockquote>
Done.=C2=A0
  • onImag= eClick function in BodyWidget.jsx is no use I think, so it should be remove= d.
I wanted to keep the cod= e as it will be used in future. Anyway, I've removed the code.
  • I got some console errors while adding/editing tables. Refer to =
the attached screenshot.
I = tried but I didn't get any. Looking at the screenshot, the error is fro= m the underlying library. Can't do much in this.=C2=A0
  • In the column Edit Mode, while deleting the primary key, it gives the er=
ror, which does not go away with any further modifications.
Fixed.=C2=A0
  • While gene=
rating the SQL, if the server is disconnected, a proper error message shoul=
d be thrown, right now some server side error is coming. 
    • <=
/pre>
    It will show connection lost error now. Fixe= d.=C2=A0
    • Please remove ... from the menu title (New ERD =
Project(Beta)...) as it is not opening a dialog.
    Done.=C2=A0
    • For large data sets, g=
enerate ERD hangs.
    It shows= the spinner and waits for the response to come from the back end. I've= used the existing table fetching code which is used at other places. I'= ;ll create an RM to improve the back end code for fetching the tables data = which will help the schema diff tool as well.
  • Opening th=
e ERD panel in a new window is not working, it opens in the same tab even i=
f you have set the Preference "Open in new browser tab" to True.<=
/font>
    • Fixed. Added the setting in= "Tab settings".
    • No shortcut is provided to op=
en the ERD Tool.
    A shortcut= is helpful if we are using it frequently. ERD tool won't be used that = frequently.=C2=A0We already have a limited number of keys available for = shortcuts. I think we should roll out without shortcut for now. If there is= a user demand for it then we can think of adding it.
    = 
    • So=
narQube fixes required.
    Fix= ed.=C2=A0
    Suggestion:
    While removal of the FK link, If any of the table is selected, it is=
 being deleted with FK link.
    Either we should warn the user OR make 2 dif=
ferent buttons for FK removal and table removal as the user may be confused=
 if the selected table is also removed with the FK.
    <= /blockquote>
    I've added a confirmation dialog w= hich will show the number of tables and links selected. This way user will = know what he has selected before deleting.
    <= /blockquote>
    =
Observations:
    TL;DR; we cann= ot.
    lodash is a peer dependency for react-diagrams (and some e= xisting modules in pgAdmin) so it will come to package.json without choice.= We cannot remove underscore because it is a dependency of backbone. Unders= core is outdated, and I cannot migrate the complete pgAdmin code.=C2=A0S= o, I decided to go with 100/0 method. All the new codes will use lodash onl= y as we'll phase out underscore with time. Just like jQuery vs ReactJS.=
    =

    Table dialog code is duplicate of the table node, as it was d= ifficult to extend it because it was attached to the tree.
    So, we need t= o keep in mind that while implementing React in pgAdmin, the nodes should b= e properly detached from the tree itself, so we can reuse it.
    Yes. I agree. We need to separate out data so= urce from UI going forward=C2=A0with React.

    Thanks,
    Khushboo


    On Mon, Dec 28, 2020 at 10:53 AM Khushboo Vashi <khushboo.vashi@e= nterprisedb.com> wrote:


    =
    On Fri, Dec 25, 2020 at 4:34 PM Akshay Joshi <akshay.josh= i@enterprisedb.com> wrote:
    = Hi Khushboo,

    <= div>Can you please review it?
    =

    On it.=C2=A0
    On Fri, Dec 25, 2020 at 3:= 31 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
    =
    Hi Hackers,

    Attached patch introduces ERD Tool(Beta) to pgAdmin. Below are th= e details:
    1) Create a di= agram from scratch or generate for an existing DB.
    2) Generate "Create" DDL from the diagr= am.
    3) Save the diagram a= nd resume it later.
    4) Su= pports basic table fields, one-to-many relationships, many-to-many relation= ships, adding notes.
    5) T= est cases added with 75-80% test coverage.

    Pl= ease review.

    <= /div>--
    Than= ks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    "Don't Complain ab= out Heat, Plant a TREE"


    --
    Thanks & Regards
    Akshay Joshi
    = pgAdmin Hacker | Principal Software Ar= chitect
    EDB Po= stgres
    Mobile: +91 976-788-8246

    <= /div>


    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Principal Softw= are Architect
    EDB Po= stgres
    Mobile: +91 976-788-8246



    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Principal Softw= are Architect
    EDB Po= stgres
    Mobile: +91 976-788-8246



    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Principal Softw= are Architect
    EDB Po= stgres
    Mobile: +91 976-788-8246



    --
    Thanks,
    Aditya Toshniwal
    pgAdmin hacker=C2=A0| Sr. Softwa= re Engineer | edbpostgres.com<= /font>
    "Don't Complain about Heat, Plant a TREE&qu= ot;
    --00000000000095a50f05b92b28f0-- --00000000000095a51105b92b28f2 Content-Type: application/octet-stream; name="RM1801.jasmine_v2.patch" Content-Disposition: attachment; filename="RM1801.jasmine_v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kk2huz7o0 ZGlmZiAtLWdpdCBhL3dlYi9yZWdyZXNzaW9uL2phdmFzY3JpcHQvZXJkL3VpX2NvbXBvbmVudHMv bG9hZGVyX3NwZWMuanMgYi93ZWIvcmVncmVzc2lvbi9qYXZhc2NyaXB0L2VyZC91aV9jb21wb25l bnRzL2xvYWRlcl9zcGVjLmpzCmluZGV4IGIxNGVkMzBhYS4uYjczYjY5MDk4IDEwMDY0NAotLS0g YS93ZWIvcmVncmVzc2lvbi9qYXZhc2NyaXB0L2VyZC91aV9jb21wb25lbnRzL2xvYWRlcl9zcGVj LmpzCisrKyBiL3dlYi9yZWdyZXNzaW9uL2phdmFzY3JpcHQvZXJkL3VpX2NvbXBvbmVudHMvbG9h ZGVyX3NwZWMuanMKQEAgLTEyLDcgKzEyLDcgQEAgZGVzY3JpYmUoJ0VSRCBMb2FkZXInLCAoKT0+ ewogCiAgIGl0KCc8TG9hZGVyIC8+IGNvbXAnLCAoKT0+ewogICAgIGxldCBsb2FkZXJDb21wID0g c2hhbGxvdyg8TG9hZGVyIC8+KTsKLSAgICBleHBlY3QobG9hZGVyQ29tcC5pc0VtcHR5UmVuZGVy KCkpLnRvQmVUcnVlKCk7CisgICAgZXhwZWN0KGxvYWRlckNvbXAuaXNFbXB0eVJlbmRlcigpKS50 b0JlVHJ1dGh5KCk7CiAKICAgICBsb2FkZXJDb21wLnNldFByb3BzKHttZXNzYWdlOiAndGVzdCBt ZXNzYWdlJ30pOwogICAgIGV4cGVjdChsb2FkZXJDb21wLmZpbmQoJy5wZy1zcC10ZXh0JykudGV4 dCgpKS50b0JlKCd0ZXN0IG1lc3NhZ2UnKTsK --00000000000095a51105b92b28f2--